diff options
| author | Prasanna Kumar Kalever <prasanna.kalever@redhat.com> | 2018-01-29 17:02:07 +0530 |
|---|---|---|
| committer | Prasanna Kumar Kalever <prasanna.kalever@redhat.com> | 2018-02-08 12:30:49 +0530 |
| commit | d7ebb697457fc4b8562bb1475a6832f1badb15f8 (patch) | |
| tree | 7f17403413bb4d8e9ef5c0b09f0564f406ed45df /rpc/glfs-operations.c | |
| parent | 540e81676b1011dcf85fbe5cd6739a4f2143b2ab (diff) | |
replace strcat and strcpy with their secure versions
Change-Id: If98ce7b7e50901ee130bbe190a12664ec0adb8c2
Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Diffstat (limited to 'rpc/glfs-operations.c')
| -rw-r--r-- | rpc/glfs-operations.c | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/rpc/glfs-operations.c b/rpc/glfs-operations.c index b1f68ac..838d3c7 100644 --- a/rpc/glfs-operations.c +++ b/rpc/glfs-operations.c @@ -301,22 +301,22 @@ blockStuffMetaInfo(MetaInfo *info, char *line) switch (blockMetaKeyEnumParse(opt)) { case GB_META_VOLUME: - strcpy(info->volume, strchr(line, ' ')+1); + GB_STRCPYSTATIC(info->volume, strchr(line, ' ') + 1); break; case GB_META_GBID: - strcpy(info->gbid, strchr(line, ' ')+1); + GB_STRCPYSTATIC(info->gbid, strchr(line, ' ') + 1); break; case GB_META_SIZE: - sscanf(strchr(line, ' ')+1, "%zu", &info->size); + sscanf(strchr(line, ' '), "%zu", &info->size); break; case GB_META_HA: - sscanf(strchr(line, ' ')+1, "%zu", &info->mpath); + sscanf(strchr(line, ' '), "%zu", &info->mpath); break; case GB_META_ENTRYCREATE: - strcpy(info->entry, strchr(line, ' ')+1); + GB_STRCPYSTATIC(info->entry, strchr(line, ' ') + 1); break; case GB_META_PASSWD: - strcpy(info->passwd, strchr(line, ' ')+1); + GB_STRCPYSTATIC(info->passwd, strchr(line, ' ') + 1); break; default: @@ -325,15 +325,15 @@ blockStuffMetaInfo(MetaInfo *info, char *line) goto out; if(GB_ALLOC(info->list[0]) < 0) goto out; - strcpy(info->list[0]->addr, opt); - strcpy(info->list[0]->status, strchr(line, ' ')+1); + GB_STRCPYSTATIC(info->list[0]->addr, opt); + GB_STRCPYSTATIC(info->list[0]->status, strchr(line, ' ') + 1); info->nhosts = 1; } else { if(GB_REALLOC_N(info->list, info->nhosts+1) < 0) goto out; for (i = 0; i < info->nhosts; i++) { if(!strcmp(info->list[i]->addr, opt)) { - strcpy(info->list[i]->status, strchr(line, ' ')+1); + GB_STRCPYSTATIC(info->list[i]->status, strchr(line, ' ') + 1); flag = 1; break; } @@ -341,8 +341,8 @@ blockStuffMetaInfo(MetaInfo *info, char *line) if (!flag) { if(GB_ALLOC(info->list[info->nhosts]) < 0) goto out; - strcpy(info->list[info->nhosts]->addr, opt); - strcpy(info->list[info->nhosts]->status, strchr(line, ' ')+1); + GB_STRCPYSTATIC(info->list[info->nhosts]->addr, opt); + GB_STRCPYSTATIC(info->list[info->nhosts]->status, strchr(line, ' ') + 1); info->nhosts++; } } |