glusterfs-afrv1.git/rpc/rpc-transport/socket, branch v3.4.0qa3

socket: fix double-free when ssl_setup_connection fails

2012-11-23T10:10:43+00:00

Change-Id: I893b166da28f4c21e582ed477399c4bc0c1d20e1
BUG: 877903
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4208
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

socket: fix SSL breakage from re/connect handling changes

2012-11-12T15:17:13+00:00

Change-Id: Ia1f5aeec5628b61cad8a10a9cdc6d9f1c67ec653
BUG: 873367
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4158
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

build: libraries must be in LDADD/LIBADD

2012-10-03T19:32:14+00:00

Libraries must not be listed in LDFLAGS, because _order is important_.
Details see
http://stackoverflow.com/questions/4241683/linker-flags-in-wrong-place
http://www.gentoo.org/proj/en/qa/asneeded.xml#doc_chap2_sect3

Change-Id: I0479456d6702748c555031bb20641ce430732ec7
BUG: 862082
Original-author: Jan Engelhardt 
Signed-off-by: Jan Engelhardt 
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4030
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

build: split CPPFLAGS from CFLAGS

2012-10-03T19:26:45+00:00

Automake provides a separate variable for preprocessor flags
(*_CPPFLAGS). They are already uses in a few places, so make it
consistent and use it everywhere. Note that cflags obtained from
pkg-config often are cppflags, which is why LIBXML2_CFLAGS moves with
into AM_CPPFLAGS, for example.

Change-Id: I15feed1d18b2ca497371271c4b5876d5ec6289dd
BUG: 862082
Original-author: Jan Engelhardt 
Signed-off-by: Jan Engelhardt 
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4029
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

build: remove useless explicit -fPIC -shared from

2012-10-03T19:24:59+00:00

 CFLAGS

libtool will automatically add "-fPIC" to the compiler command line as
needed, so there is no need to specify it separately.

"-shared" is normally a linker flag and has an odd effect when used with
libtool --mode=compile, namely that it inhibits production of static
objects. For that however, using AC_DISABLE_STATIC is a lot simpler.

Change-Id: Ic4cba0fad18ffd985cf07f8d6951a976ae59a48f
BUG: 862082
Original-author: Jan Engelhardt 
Signed-off-by: Jan Engelhardt 
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4027
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

build: remove -nostartfiles flag

2012-10-02T20:11:43+00:00

The "-nostartfiles" is a discouraged option and is documented to
potentially result in undesired behavior. Since I see no reason why it
should be in glusterfs, remove it.

Change-Id: I56f2b08874516ebad91447b2583ca2fb776bb7ab
BUG: 862082
Original-author: Jan Engelhardt 
Signed-off-by: Jan Engelhardt 
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4018
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

build: consolidate common compilation flags into one variable

2012-10-01T23:44:50+00:00

Some -D flags are present in all files, so collect them.
This adds -D${GF_HOST_OS} to some compiler command lines,
but this should not be a problem.

Change-Id: I1aeb346143d4984c9cc4f2750c465ce09af1e6ca
BUG: 862082
Original-author: Jan Engelhardt 
Signed-off-by: Jan Engelhardt 
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4013
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

rpc/socket: Wrong Log-File Error-Message

2012-09-05T15:21:04+00:00

Problem:
The port changed in rpc-clnt.c:rpc_clnt_reconfig was not being
updated to the variable peerinfo.identifier before the logging.

Change-Id: Ic56a74738c6f7664e9719b125a014126cea69141
BUG: 847211
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/3894
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Shishir Gowda 
Reviewed-by: Anand Avati

socket: code cleanup

2012-08-23T09:17:43+00:00

* for more review friendly way

* reduce the level of indirections at each line.

Change-Id: I82ace7683fb281d97a64da724f054ece28215054
Signed-off-by: Amar Tumballi 
BUG: 764890
Reviewed-on: http://review.gluster.org/3839
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

misleading/wrong keep-alive error message in log

2012-08-19T16:28:53+00:00

Gluster NFS and brick logs contain the following log entries:

[2012-08-16 09:23:39.498998] W [socket.c:410:__socket_keepalive] 0-socket: failed to set keep idle on socket 8
[2012-08-16 09:23:39.499049] W [socket.c:1876:socket_server_event_handler] 0-socket.glusterfsd: Failed to set keep-alive: Operation not supported
[2012-08-16 09:23:42.673756] I [client-handshake.c:1636:select_server_supported_

Stepping through the code though, setting keep-alive did actually work,
it's the keep-idle that failed.

The actual problem is setting keep-idle on non-AF_INET sockets results
in the spurious error message in the log.

BUG: 848882
Change-Id: I3a54c96aea0642307f17a7945cca9f9438543243
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.com/3823
Reviewed-by: Amar Tumballi 
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy 
Reviewed-by: Anand Avati