glusterfs-afrv1.git/xlators/mgmt, branch master

glusterd: suppress spurious error message during startup

2014-03-27T06:40:44+00:00

From glusterd log:
----------
E [glusterd-store.c:1981:glusterd_store_retrieve_volume] 0-: Unknown key:
brick-0
----------

The message is emitted from glusterd_store_retrieve_volume() when it reads the
volinfo file because it doesn't do anything with the key-value pair. Suppress the
error. The key is needed by glusterd_store_retrieve_bricks() which anyway
re-reads it.

Also change the log level to WARNING since we do not error out if an unknown key
is got while parsing the volinfo file.

Change-Id: Icd7962d9e16e0f90e6a37ee053dcafe97d2cab94
BUG: 1079279
Reviewed-on: http://review.gluster.org/7314
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M 
Reviewed-by: Anand Avati

glusterd: op-version check for brickops.

2014-03-24T17:23:39+00:00

cluster op-version must be atleast 4 for add/remove brick to proceed.
This change is required for the new afr-changelog xattr changes that
will be done for glusterFS 3.6 (http://review.gluster.org/#/c/7155/).

In add-brick, the check is done only when replica count is increased
because only that will affect the AFR xattrs.

In remove-brick, the check is unconditional failing which there will be
inconsistencies in the client xlator names amongst the volfiles of
different peers.

Change-Id: If981da2f33899aed585ab70bb11c09a093c9d8e6
BUG: 1066778
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/7122
Reviewed-by: Kaushal M 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: persistent client xlator/ afr changelog names

2014-03-24T11:36:02+00:00

-Add a unique brick-id field to glusterd_brickinfo_t
-Persist the id to the brickinfo file
-Use the brick-id as the client xlator name during vol create, add-brick and
 replace-brick operations.
-For older volumes,generate the id in-memory during glusterd restore but defer
 writing it to the brickinfo file until the next volume set operation.
-send and receive the brick-ids during peer probe.

Feature page:
www.gluster.org/community/documentation/index.php/Features/persistent-AFR-changelog-xattributes

Related patch:
http://review.gluster.org/#/c/7122

Change-Id: Ib7f1570004e33f4144476410eec2b84df4e41448
BUG: 1066778
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/7155
Tested-by: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Kaushal M 
Reviewed-by: Vijay Bellur

Glusterd/Remove-brick: Reconfigure the nfs server volfile upon remove-brick start

2014-03-22T12:28:35+00:00

Problem : For remove-brick start operation  all client volfiles are reconfigured
except nfs server volfile. Hence, even after layout is fixed by the rebalance
process, the nfs clients dont see the change and go on creating directories and
files in the decommissioned brick which leads to data loss after remove-brick
commit.

Solution : Reconfigure the nfs server volfile for remove-brick start

credit: kaushal@redhat.com
        spalai@redhat.com

Change-Id: Ib8cd8b45a9e1f888d5e00dff65cdf77c1613a2af
BUG: 1070734
Signed-off-by: Susant Palai 
Reviewed-on: http://review.gluster.org/7162
Reviewed-by: Kaushal M 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Vijay Bellur

geo-rep/glusterd: Fix geo-rep status on introduction of volume lock

2014-03-21T09:37:56+00:00

        Getting op context in 'glusterd_op_gsync_set' is no longer
        valid as it is expected that 'rsp_dict' sent from caller is
        filled. It was fine till now as no one was setting the op
        context. The introduction of volume locks sets it,
        consequently breaking geo-rep status command. Hence the
        code that gets dict from op context if present is removed.

        Also corrected some indentation issues in 'glusterd_op_gsync_set'

Signed-off-by: Kotresh H R 

Change-Id: Ieacd6e6c9be3c92159f849caca2acf5aabca1e32
BUG: 1077697
Signed-off-by: Kotresh H R 
Reviewed-on: http://review.gluster.org/7289
Reviewed-by: Avra Sengupta 
Tested-by: Gluster Build System

glusterd: send/receive volinfo->caps during peer probe.

2014-03-09T07:24:08+00:00

Problem: volinfo->caps was not sent over to newly probed peers, resulting in a
'Peer Rejected' state due to volinfo checksum mismatch.

Fix: send/receive volinfo capability when peer probing.

Change-Id: I2508d3fc7a6e4aeac9c22dd7fb2d3b362f4c21ff
BUG: 1072720
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/7186
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M 
Reviewed-by: Vijay Bellur

glusterd: Fixed typo in console message during volume create

2014-03-09T07:22:48+00:00

While creating a volume, if the brick is created on the root
partition, then the error statement is thrown.

This error statements was containing two "is" in it.
Removed one of the "is"

Change-Id: I0d83f0feccda34989f7e2b97041d1f15ec9e2f00
BUG: 1065551
Signed-off-by: Satheesaran 
Reviewed-on: http://review.gluster.org/7198
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Reviewed-by: Vijay Bellur

rpc: transport may be destroyed while rpc isn't

2014-03-06T05:26:59+00:00

rpc_clnt object is destroyed after the corresponding transport object is
destroyed. But rpc_clnt_reconnect, a timer driven function, refers to
the transport object beyond its 'life'. Instead, using the embedded
connection object prevents use after free problem wrt transport object.

Also, access transport object under conn->lock.

Change-Id: Iae28e8a657d02689963c510114ad7cb7e6764e62
BUG: 962619
Signed-off-by: Krishnan Parthasarathi 
Reviewed-on: http://review.gluster.org/6751
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

feature/compress: Validate option and enable doc

2014-02-26T17:18:35+00:00

* Validate network.compression option
* Enable descriptions of xlator configurable options
* Improve indentation in code
* Make network.compression.mode not configurable by user.
  This is similar to "iam-self-heal-daemon" option in AFR xlator.

Fixes BUGs: 1065658, 1065640, 1065655

Change-Id: I99d82b574ee0e5c8c2baf5f5d52dbf8d015d330a
BUG: 1065640
Signed-off-by: Prashanth Pai 
Reviewed-on: http://review.gluster.org/7024
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: Check for ctx before dereferencing it.

2014-02-21T06:23:30+00:00

Fix for coverity CID: 1175010 & 1175011

Change-Id: Ib894fadf94c36704166ac0e2a3b6febf9b3fe446
BUG: 789278
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/7025
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur