glusterfs-afrv1.git/xlators/performance, branch master

build: do not create versioned .so files

2014-03-22T00:28:15+00:00

There has been a misspelled option in the Makefile.am files. The option
is called -avoid-version, and not -avoidversion.

It is not trivial to provide a test-case for this. One way would be to
check generated RPMs with a command like this (output should be empty):

  $ rpm -qlp *.rpm | grep -E '/xlator/.+.so.0'

Change-Id: I2a6cc557eada4d098b73af5a254f8c75707543da
BUG: 1078365
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/7299
Reviewed-by: Lalatendu Mohanty 
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System

write-behind: track filesize when doing extending writes

2014-02-28T05:56:48+00:00

A program that calls mmap() on a newly created sparse file, may receive
a SIGBUS signal. If SIGBUS is not handled, a segmentation fault will
occur and the program will exit.

A bug in the write-behind translator can cause the creation of a sparse
file created with open(), seek(), write() to be cached. The last write()
may not be sent to the server, until write-behind deems this necessary.

* open(.., O_TRUNC, ...)/creat() the file, it is 0 bytes big
* seek() into the file, use offset 31
* write() 1 byte to the file
* the range from byte 0-30 are unwritten so called 'sparse'

The following illustration tries to capture this:

    Legend:
    [ = start of file
    _ = unallocated/unwritten bytes
    # = allocated bytes in the file
    ] = end of file

    [_______________#]
     |              |
     '- byte 0      '- byte 31

Without this change, reading from byte 0-30 will return an error, and
reading the same area through an mmap()'d pointer will trigger a SIGBUS.
Reading from this range did not trigger the outstanding write() to be
flushed. The brick that receives the read() (translated over the network
from mmap()) does not know that the file has been extended, and returns
-EINVAL. This error gets transported back from the brick to the
glusterfs-fuse client, and translated by the Linux kernel/VFS into
SIGBUS triggered by mmap().

In order to solve this, a new attribute to the wb_inode structure is
introduced; the current size of the file. All FOPs that can modify the
size, are expected to update wb_inode->size. This makes it possible for
extending writes with an offset bigger than EOF to mark the unwritten
area as modified/pending.

Change-Id: If5ba6646732e6be26568541ea9b12852a5d0b988
BUG: 1058663
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/6835
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Anand Avati

performance/io-threads: Remove code duplication

2014-02-25T02:56:06+00:00

Change-Id: Ic905cc6074c796efce2972857b79ab53700a2de4
BUG: 1065657
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/7010
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

io-cache: Unlock and then goto out in failure case.

2014-02-17T16:09:55+00:00

Fix for coverity bug CID:1124625

Change-Id: I76df453a17f2af7c48a80b6fc0ccd411ab96e371
BUG: 789278
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/6949
Reviewed-by: Santosh Pradhan 
Tested-by: Gluster Build System

performance/io-cache: Fix dereferencing of freed pointer

2014-02-13T01:35:43+00:00

Change-Id: Ic4276c6d76c36f4eb77282dc06d2b8b212b58f08
BUG: 789278
Signed-off-by: Poornima 
Reviewed-on: http://review.gluster.org/6822
Reviewed-by: Raghavendra G 
Tested-by: Gluster Build System

protocol/server: do not do root-squashing for trusted clients

2014-02-11T07:32:05+00:00

* As of now clients mounting within the storage pool using that machine's
  ip/hostname are trusted clients (i.e clients local to the glusterd).

* Be careful when the request itself comes in as nfsnobody (ex: posix tests).
  So move the squashing part to protocol/server when it creates a new frame
  for the request, instead of auth part of rpc layer.

* For nfs servers do root-squashing without checking if it is trusted client,
  as all the nfs servers would be running within the storage pool, hence will
  be trusted clients for the bricks.

* Provide one more option for mounting which actually says root-squash
  should/should not happen. This value is given priority only for the trusted
  clients. For non trusted clients, the volume option takes the priority. But
  for trusted clients if root-squash should not happen, then they have to be
  mounted with root-squash=no option. (This is done because by default
  blocking root-squashing for the trusted clients will cause problems for smb
  and UFO clients for which the requests have to be squashed if the option is
  enabled).

* For geo-replication and defrag clients do not do root-squashing.

* Introduce a new option in open-behind for doing read after successful open.

Change-Id: I8a8359840313dffc34824f3ea80a9c48375067f0
BUG: 954057
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/4863
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

performance/io-cache: Fix for the bugs reported by coverity

2014-02-11T01:05:20+00:00

Change-Id: I24c10d874511a2f24dda2fb84d31f5074da1616f
BUG: 789278
Signed-off-by: Poornima 
Reviewed-on: http://review.gluster.org/6869
Reviewed-by: Raghavendra G 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

performance/quick-read: Allocated memory not freed when not used.

2014-02-08T19:30:01+00:00

If memory is successfully allocated in the call to qr_content_extract(),
but is not used, it is not being freed.  This patch frees the allocated
memory if it is not passed to qr_content_refresh().

BUG: 789278
CID: 1124735

Change-Id: I1c1f03a3b92fa26321ec6ee8822e6fa41da79875
Signed-off-by: Christopher R. Hertel 
Reviewed-on: http://review.gluster.org/6827
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

quick-read: Remove unref of a freed iobuf.

2014-02-08T02:52:41+00:00

Change-Id: Ie21414658db571c9a483730b6d5e8997f04255c1
BUG: 789278
Signed-off-by: Poornima 
Reviewed-on: http://review.gluster.org/6823
Reviewed-by: Raghavendra G 
Tested-by: Gluster Build System

Fix for 'use after free' errors reported by coverity.

2014-02-06T06:09:13+00:00

Change-Id: I941fc89b2d696c7f227330321ed4bba3ed1deac4
BUG: 789278
Signed-off-by: Poornima 
Reviewed-on: http://review.gluster.org/6868
Reviewed-by: Raghavendra G 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur