diff options
| author | Lalatendu Mohanty <lmohanty@redhat.com> | 2014-01-14 23:50:51 +0530 |
|---|---|---|
| committer | Vijay Bellur <vbellur@redhat.com> | 2014-01-18 08:47:17 -0800 |
| commit | 1ffc3ac9639e25c91ac26488b648d5523becb08e (patch) | |
| tree | 4152fc4ee17f3c535ec3b8fcc8b384538c333d38 | |
| parent | 63638748d744377d899e9ee0b5e7831d7c1c2496 (diff) | |
core: Coverity issue "Use of uninitialized scalar variable"
Issue:
1. In "unlink (export_path)" "export_path" might contain an arbitrary value left from earlier
computations.
2. In "(msg[0] != '\0')" msg might contain an arbitrary value
Change-Id: Icca8f557fd6b5e046dff1d5a84a72061975868d0
BUG: 789278
Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
Reviewed-on: http://review.gluster.org/6701
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Vijay Bellur <vbellur@redhat.com>
| -rw-r--r-- | glusterfsd/src/glusterfsd-mgmt.c | 4 | ||||
| -rw-r--r-- | xlators/mgmt/glusterd/src/glusterd-volume-ops.c | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/glusterfsd/src/glusterfsd-mgmt.c b/glusterfsd/src/glusterfsd-mgmt.c index 0484779ce..de2829ddd 100644 --- a/glusterfsd/src/glusterfsd-mgmt.c +++ b/glusterfsd/src/glusterfsd-mgmt.c @@ -365,7 +365,7 @@ glusterfs_volume_top_write_perf (uint32_t blk_size, uint32_t blk_count, { int32_t fd = -1; int32_t input_fd = -1; - char export_path[PATH_MAX]; + char export_path[PATH_MAX] = {0,}; char *buf = NULL; int32_t iter = 0; int32_t ret = -1; @@ -448,7 +448,7 @@ glusterfs_volume_top_read_perf (uint32_t blk_size, uint32_t blk_count, int32_t fd = -1; int32_t input_fd = -1; int32_t output_fd = -1; - char export_path[PATH_MAX]; + char export_path[PATH_MAX] = {0,}; char *buf = NULL; int32_t iter = 0; int32_t ret = -1; diff --git a/xlators/mgmt/glusterd/src/glusterd-volume-ops.c b/xlators/mgmt/glusterd/src/glusterd-volume-ops.c index db9f39c7c..85a537306 100644 --- a/xlators/mgmt/glusterd/src/glusterd-volume-ops.c +++ b/xlators/mgmt/glusterd/src/glusterd-volume-ops.c @@ -923,7 +923,7 @@ glusterd_op_stage_start_volume (dict_t *dict, char **op_errstr) gf_boolean_t exists = _gf_false; glusterd_volinfo_t *volinfo = NULL; glusterd_brickinfo_t *brickinfo = NULL; - char msg[2048]; + char msg[2048] = {0,}; glusterd_conf_t *priv = NULL; xlator_t *this = NULL; uuid_t volume_id = {0,}; |