diff options
| author | Jeff Darcy <jdarcy@redhat.com> | 2012-04-19 16:53:19 -0400 |
|---|---|---|
| committer | Anand Avati <avati@redhat.com> | 2012-04-23 14:46:46 -0700 |
| commit | 6fbf369d59cf87b903403699666d99232a372fef (patch) | |
| tree | 26f1b27f8c41bbdce944afcf3f0a0be16af69964 | |
| parent | 7d0397c2144810c8a396e00187a6617873c94002 (diff) | |
Make option code quieter to make logs more readable.
A lot of this stuff is extremely uninformative, such as messages about
default values that can be read from the code. Having them in the logs
makes more important messages harder to find, so they're down to
GF_DEBUG_TRACE now.
Change-Id: I18921b3deac7a01ad94c50670b90342d1130837b
Signed-off-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.com/3198
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Kaleb KEITHLEY <kkeithle@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
| -rw-r--r-- | libglusterfs/src/options.c | 10 | ||||
| -rw-r--r-- | libglusterfs/src/options.h | 2 | ||||
| -rw-r--r-- | libglusterfs/src/xlator.c | 10 |
3 files changed, 11 insertions, 11 deletions
diff --git a/libglusterfs/src/options.c b/libglusterfs/src/options.c index 6da68fd99..762f15f99 100644 --- a/libglusterfs/src/options.c +++ b/libglusterfs/src/options.c @@ -81,7 +81,7 @@ xlator_option_validate_int (xlator_t *xl, const char *key, const char *value, } if ((opt->min == 0) && (opt->max == 0)) { - gf_log (xl->name, GF_LOG_DEBUG, + gf_log (xl->name, GF_LOG_TRACE, "no range check required for 'option %s %s'", key, value); ret = 0; @@ -123,7 +123,7 @@ xlator_option_validate_sizet (xlator_t *xl, const char *key, const char *value, } if ((opt->min == 0) && (opt->max == 0)) { - gf_log (xl->name, GF_LOG_DEBUG, + gf_log (xl->name, GF_LOG_TRACE, "no range check required for 'option %s %s'", key, value); ret = 0; @@ -336,7 +336,7 @@ xlator_option_validate_percent_or_sizet (xlator_t *xl, const char *key, } /* Check the range */ if ((opt->min == 0) && (opt->max == 0)) { - gf_log (xl->name, GF_LOG_DEBUG, + gf_log (xl->name, GF_LOG_TRACE, "no range check required for " "'option %s %s'", key, value); @@ -390,7 +390,7 @@ xlator_option_validate_time (xlator_t *xl, const char *key, const char *value, } if ((opt->min == 0) && (opt->max == 0)) { - gf_log (xl->name, GF_LOG_DEBUG, + gf_log (xl->name, GF_LOG_TRACE, "no range check required for " "'option %s %s'", key, value); @@ -442,7 +442,7 @@ xlator_option_validate_double (xlator_t *xl, const char *key, const char *value, } if ((opt->min == 0) && (opt->max == 0)) { - gf_log (xl->name, GF_LOG_DEBUG, + gf_log (xl->name, GF_LOG_TRACE, "no range check required for 'option %s %s'", key, value); ret = 0; diff --git a/libglusterfs/src/options.h b/libglusterfs/src/options.h index 722cc3b7a..943c30365 100644 --- a/libglusterfs/src/options.h +++ b/libglusterfs/src/options.h @@ -143,7 +143,7 @@ xlator_option_init_##type (xlator_t *this, dict_t *options, char *key, \ return 0; \ } \ if (value == def_value) { \ - gf_log (this->name, GF_LOG_DEBUG, \ + gf_log (this->name, GF_LOG_TRACE, \ "option %s using default value %s", \ key, value); \ } else { \ diff --git a/libglusterfs/src/xlator.c b/libglusterfs/src/xlator.c index 1bff11fec..1641a1909 100644 --- a/libglusterfs/src/xlator.c +++ b/libglusterfs/src/xlator.c @@ -238,23 +238,23 @@ xlator_dynload (xlator_t *xl) } if (!(xl->notify = dlsym (handle, "notify"))) { - gf_log ("xlator", GF_LOG_DEBUG, + gf_log ("xlator", GF_LOG_TRACE, "dlsym(notify) on %s -- neglecting", dlerror ()); } if (!(xl->dumpops = dlsym (handle, "dumpops"))) { - gf_log ("xlator", GF_LOG_DEBUG, + gf_log ("xlator", GF_LOG_TRACE, "dlsym(dumpops) on %s -- neglecting", dlerror ()); } if (!(xl->mem_acct_init = dlsym (handle, "mem_acct_init"))) { - gf_log (xl->name, GF_LOG_DEBUG, + gf_log (xl->name, GF_LOG_TRACE, "dlsym(mem_acct_init) on %s -- neglecting", dlerror ()); } if (!(xl->reconfigure = dlsym (handle, "reconfigure"))) { - gf_log ("xlator", GF_LOG_DEBUG, + gf_log ("xlator", GF_LOG_TRACE, "dlsym(reconfigure) on %s -- neglecting", dlerror()); } @@ -268,7 +268,7 @@ xlator_dynload (xlator_t *xl) if (!(vol_opt->given_opt = dlsym (handle, "options"))) { dlerror (); - gf_log (xl->name, GF_LOG_DEBUG, + gf_log (xl->name, GF_LOG_TRACE, "Strict option validation not enforced -- neglecting"); } list_add_tail (&vol_opt->list, &xl->volume_options); |