diff options
| author | Vijay Bellur <vbellur@redhat.com> | 2013-03-20 11:06:19 +0530 |
|---|---|---|
| committer | Anand Avati <avati@redhat.com> | 2013-05-29 17:04:11 -0700 |
| commit | 96c530295eaf8b8ba6e231e6c77fa1cb9302498d (patch) | |
| tree | 0f7a2b3c6ae29a599f0d461bef854c7c73ab0fb4 | |
| parent | 06036dd18d67bf55111a46915f702078fdf8e65b (diff) | |
performance/write-behind: Enable write-behind when strict_O_DIRECT is not set.
When open() with O_DIRECT happens, write-behind was being disabled for the
fd irrespective of strict_O_DIRECT option. This commit disables write-behind
only when strict_O_DIRECT is enabled.
Change-Id: Ieef180e52910c3bf64d46b26b0e5dc3b8542f6d2
BUG: 923556
Signed-off-by: Vijay Bellur <vbellur@redhat.com>
Reviewed-on: http://review.gluster.org/4697
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Jeff Darcy <jdarcy@redhat.com>
Reviewed-on: http://review.gluster.org/5108
Reviewed-by: Anand Avati <avati@redhat.com>
| -rw-r--r-- | xlators/performance/write-behind/src/write-behind.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/xlators/performance/write-behind/src/write-behind.c b/xlators/performance/write-behind/src/write-behind.c index b6757aebd..31cb74ed8 100644 --- a/xlators/performance/write-behind/src/write-behind.c +++ b/xlators/performance/write-behind/src/write-behind.c @@ -1249,8 +1249,7 @@ wb_writev (call_frame_t *frame, xlator_t *this, fd_t *fd, struct iovec *vector, if (fd->flags & (O_SYNC|O_DSYNC|o_direct)) wb_disabled = 1; - if (flags & (O_SYNC|O_DSYNC|O_DIRECT)) - /* O_DIRECT flag in params of writev must _always_ be honored */ + if (flags & (O_SYNC|O_DSYNC|o_direct)) wb_disabled = 1; if (wb_disabled) |