diff options
author | Sachidananda <sac@gluster.com> | 2010-05-18 00:20:24 +0000 |
---|---|---|
committer | Anand V. Avati <avati@dev.gluster.com> | 2010-05-21 00:32:00 -0700 |
commit | 3b88b2dfbc1a33a6967cfedf63a615ee1e81e49d (patch) | |
tree | 298fc1628b5eb9afe93ea6593927418862bb9072 | |
parent | 67ade7b062a13d896187d1bc784baded59f73fcf (diff) |
Log proper error message when hostname or ip does not conform to standards.
Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 923 (Hostnames with underscores fail)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=923
-rw-r--r-- | libglusterfs/src/xlator.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/libglusterfs/src/xlator.c b/libglusterfs/src/xlator.c index 2168beb91..4a0de3001 100644 --- a/libglusterfs/src/xlator.c +++ b/libglusterfs/src/xlator.c @@ -597,7 +597,12 @@ _volume_option_value_validate (xlator_t *xl, { if (valid_internet_address (pair->value->data)) { ret = 0; - } + } else { + gf_log (xl->name, GF_LOG_ERROR, "internet address '%s'" + " does not conform to standards.", + pair->value->data); + goto out; + } } break; case GF_OPTION_TYPE_ANY: |