diff options
| author | Junaid <junaid@gluster.com> | 2011-06-19 23:41:25 +0000 |
|---|---|---|
| committer | Anand Avati <avati@gluster.com> | 2011-06-20 00:20:58 -0700 |
| commit | 96ae0db506f43ceed0d3346d0351b1bb73b0b19c (patch) | |
| tree | 278692d0ea2302ff8c04c3e2b6b63db78ea729b1 | |
| parent | 1748b0c7925fa2165cbf11c4aab90e07bff7d4cb (diff) | |
features/quota: Print a log when reconfigure fails.
Signed-off-by: Junaid <junaid@gluster.com>
Signed-off-by: Anand Avati <avati@gluster.com>
BUG: 2775 (crash in reconfigure)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2775
| -rw-r--r-- | xlators/features/quota/src/quota.c | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/xlators/features/quota/src/quota.c b/xlators/features/quota/src/quota.c index dc3ed30a7..8f63c7aea 100644 --- a/xlators/features/quota/src/quota.c +++ b/xlators/features/quota/src/quota.c @@ -2746,11 +2746,14 @@ reconfigure (xlator_t *this, dict_t *options) } ret = quota_parse_options (priv, this, options); - - if (ret == -1) - GF_ASSERT (0); - - return ret; + if (ret == -1) { + gf_log ("quota", GF_LOG_WARNING, + "quota reconfigure failed, " + "new changes will not take effect"); + goto out; + } +out: + return 0; } |