diff options
| author | Pavan Sondur <pavan@gluster.com> | 2010-09-27 16:20:19 +0000 |
|---|---|---|
| committer | Vijay Bellur <vijay@dev.gluster.com> | 2010-09-27 22:07:29 -0700 |
| commit | efd1f08b57a3175cab9bb543833bc3c9192b527d (patch) | |
| tree | f7d763af8ac5c6eab2a62729e1fbf4daa7522671 /cli | |
| parent | 4a9c36ea9df9dada0d16c5fdb9fe149b360d9150 (diff) | |
replace brick fixes
Reviewed ok.
Just like commit, maybe we can move 'pause' also to the commit op of replace brick since it can be performed only when replace brick has been started. I'll send in a patch for that soon.
----- Original Message -----
From: "Vijay Bellur" <vijay@gluster.com>
To: glusterfs@dev.gluster.com
Sent: Monday, September 27, 2010 7:59:25 PM
Subject: [PATCH BUG:1235] replace brick fixes
Signed-off-by: Vijay Bellur <vijay@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 1235 (Bug for all pump/migrate commits)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1235
Diffstat (limited to 'cli')
| -rw-r--r-- | cli/src/cli3_1-cops.c | 30 |
1 files changed, 0 insertions, 30 deletions
diff --git a/cli/src/cli3_1-cops.c b/cli/src/cli3_1-cops.c index b2a1a78b3..d92da2913 100644 --- a/cli/src/cli3_1-cops.c +++ b/cli/src/cli3_1-cops.c @@ -822,7 +822,6 @@ gf_cli3_1_replace_brick_cbk (struct rpc_req *req, struct iovec *iov, char *status_reply = NULL; gf1_cli_replace_op replace_op = 0; char *rb_operation_str = NULL; - char cmd_str[8192] = {0,}; if (-1 == req->rpc_status) { goto out; @@ -894,35 +893,6 @@ gf_cli3_1_replace_brick_cbk (struct rpc_req *req, struct iovec *iov, goto out; } - snprintf (cmd_str, 4096, "gluster volume replace-brick %s %s %s abort >/dev/null", - local->u.replace_brick.volname, src_brick, dst_brick); - - ret = system (cmd_str); - if (ret) { - gf_log ("", GF_LOG_DEBUG, - "add brick failed"); - goto out; - } - - snprintf (cmd_str, 4096, "gluster volume add-brick %s %s >/dev/null", - local->u.replace_brick.volname, dst_brick); - - ret = system (cmd_str); - if (ret) { - gf_log ("", GF_LOG_DEBUG, - "add brick failed"); - goto out; - } - - snprintf (cmd_str, 4096, "gluster --mode=script volume remove-brick %s %s >/dev/null", - local->u.replace_brick.volname, src_brick); - - ret = system (cmd_str); - if (ret) { - gf_log ("", GF_LOG_DEBUG, - "remove brick failed"); - goto out; - } if (rsp.op_ret || ret) rb_operation_str = "replace-brick commit failed"; |