diff options
| author | Amar Tumballi <amar@gluster.com> | 2011-10-18 10:30:42 +0530 |
|---|---|---|
| committer | Anand Avati <avati@gluster.com> | 2011-10-20 04:13:50 -0700 |
| commit | 84ebee8c20ce667a5ec5fddc0aa47f8b5bef39f8 (patch) | |
| tree | f38e977ced3c0b2d6e8c47d3aeeea4bdc3fce208 /xlators/features | |
| parent | 26a51e5e6ec1639a7601c0fc373fd9f6493b014a (diff) | |
build: warning suppression (round n)
with this patch, there are no more warnings with gcc (GCC) 4.6.1 20110908
Change-Id: Ice0d52d304b9846395f8a4a191c98eb53125f792
BUG: 2550
Reviewed-on: http://review.gluster.com/607
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Anand Avati <avati@gluster.com>
Diffstat (limited to 'xlators/features')
| -rw-r--r-- | xlators/features/marker/src/marker.c | 8 | ||||
| -rw-r--r-- | xlators/features/quota/src/quota.c | 5 |
2 files changed, 11 insertions, 2 deletions
diff --git a/xlators/features/marker/src/marker.c b/xlators/features/marker/src/marker.c index 7ddc7968f..0faa8be58 100644 --- a/xlators/features/marker/src/marker.c +++ b/xlators/features/marker/src/marker.c @@ -236,6 +236,9 @@ marker_getxattr_stampfile_cbk (call_frame_t *frame, xlator_t *this, ret = dict_set_bin (dict, (char *)name, vol_mark, sizeof (struct volume_mark)); + if (ret) + gf_log (this->name, GF_LOG_WARNING, "failed to set key %s", + name); STACK_UNWIND_STRICT (getxattr, frame, 0, 0, dict); @@ -390,8 +393,9 @@ marker_start_setxattr (call_frame_t *frame, xlator_t *this) ret = dict_set_static_bin (dict, priv->marker_xattr, (void *)local->timebuf, 8); - - gf_log (this->name, GF_LOG_DEBUG, "path = %s", local->loc.path); + if (ret) + gf_log (this->name, GF_LOG_WARNING, + "failed to set marker xattr (%s)", local->loc.path); STACK_WIND (frame, marker_specific_setxattr_cbk, FIRST_CHILD(this), FIRST_CHILD(this)->fops->setxattr, &local->loc, dict, 0); diff --git a/xlators/features/quota/src/quota.c b/xlators/features/quota/src/quota.c index c15d59f54..3ec480a94 100644 --- a/xlators/features/quota/src/quota.c +++ b/xlators/features/quota/src/quota.c @@ -812,6 +812,11 @@ quota_writev_cbk (call_frame_t *frame, void *cookie, xlator_t *this, } ret = inode_ctx_get (local->loc.inode, this, &ctx_int); + if (ret) { + gf_log (this->name, GF_LOG_WARNING, + "%s: failed to get the context", local->loc.path); + goto out; + } ctx = (quota_inode_ctx_t *)(unsigned long) ctx_int; |