diff options
| author | Raghavendra G <raghavendra@gluster.com> | 2009-10-15 08:40:53 +0000 |
|---|---|---|
| committer | Anand V. Avati <avati@dev.gluster.com> | 2009-10-15 09:19:28 -0700 |
| commit | d9d268b7983d06cfb6d2b6bea5aca0f4bd60dee7 (patch) | |
| tree | f0a5a5595f942931157cd4789804dee262e3c433 /xlators/performance | |
| parent | db3155c3c8a96bb964408f22d833d3997a64570b (diff) | |
performance/quick-read: frame->local need not be set in qr_open_cbk.
- local is used only by certain operations and hence it need not be set by
all the operations invoking open.
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 323 (fd leak with quick-read loaded in translator tree)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=323
Diffstat (limited to 'xlators/performance')
| -rw-r--r-- | xlators/performance/quick-read/src/quick-read.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/xlators/performance/quick-read/src/quick-read.c b/xlators/performance/quick-read/src/quick-read.c index e025f0d0a..03c917da3 100644 --- a/xlators/performance/quick-read/src/quick-read.c +++ b/xlators/performance/quick-read/src/quick-read.c @@ -344,10 +344,7 @@ qr_open_cbk (call_frame_t *frame, void *cookie, xlator_t *this, int32_t op_ret, char is_open = 0; local = frame->local; - if (local == NULL) { - op_ret = -1; - op_errno = EINVAL; - } else { + if (local != NULL) { local->op_ret = op_ret; local->op_errno = op_errno; is_open = local->is_open; |