path: root/xlators/protocol/client/src/client.h
diff options
authorPranith Kumar K <>2014-01-08 17:01:44 +0530
committerVijay Bellur <>2014-02-17 08:09:38 -0800
commit4a14159e82d7b736dec686a170b06e961d7aff53 (patch)
tree04fbf9da6eedd266798dcdf65e825615d0743f2e /xlators/protocol/client/src/client.h
parent7b3207168ef5496702ab10d48be4e4d7cf1f413b (diff)
protocol/client: conn-id should be unique when lk-heal is off
Problem: It was observed that in some cases client disconnects and re-connects before server xlator could detect that a disconnect happened. So it still uses previous fdtable and ltable. But it can so happen that in between disconnect and re-connect an 'unlock' fop may fail because the fds are marked 'bad' in client xlator upon disconnect. Due to this stale locks remain on the brick which lead to hangs/self-heals not happening etc. For the exact bug RCA please look at Fix: When lk-heal is not enabled make sure connection-id is different for every setvolume. This will make sure that a previous connection's resources are not re-used in server xlator. Change-Id: Id844aaa76dfcf2740db72533bca53c23b2fe5549 BUG: 1049932 Signed-off-by: Pranith Kumar K <> Reviewed-on: Tested-by: Gluster Build System <> Reviewed-by: Krishnan Parthasarathi <> Reviewed-by: Vijay Bellur <>
Diffstat (limited to 'xlators/protocol/client/src/client.h')
1 files changed, 5 insertions, 0 deletions
diff --git a/xlators/protocol/client/src/client.h b/xlators/protocol/client/src/client.h
index afab2d74f..bc0f5d0e9 100644
--- a/xlators/protocol/client/src/client.h
+++ b/xlators/protocol/client/src/client.h
@@ -120,6 +120,11 @@ typedef struct clnt_conf {
gf_boolean_t filter_o_direct; /* if set, filter O_DIRECT from
the flags list of open() */
+ /* set volume is the op which results in creating/re-using
+ * the conn-id and is called once per connection, this remembers
+ * how manytimes set_volume is called
+ */
+ uint64_t setvol_count;
} clnt_conf_t;
typedef struct _client_fd_ctx {