diff options
| author | Amar Tumballi <amar@gluster.com> | 2010-06-23 02:55:21 +0000 |
|---|---|---|
| committer | Anand V. Avati <avati@dev.gluster.com> | 2010-06-24 10:32:11 -0700 |
| commit | e82ca8fc5164f4ba2ff396da86b4a490d9a47370 (patch) | |
| tree | 1c92b4d4c0a4ad42b2213f17c92ededc45ae89a2 /xlators/protocol/server/src/server.c | |
| parent | 487e9f1d59bbf7b37a30ceef5dbfd8ca77b94988 (diff) | |
minor improvements in protocol
* rpc_clnt_submit() now takes 'cbkfn' as an argument.
* readdir xdr now uses dirent structure directly instead of
using 'opaque' buffer through which it was serializing /
unserializing the dirent structure.
* 'gfs_id' field (currently used for debugging) is properly updated
Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>
BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
Diffstat (limited to 'xlators/protocol/server/src/server.c')
| -rw-r--r-- | xlators/protocol/server/src/server.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/xlators/protocol/server/src/server.c b/xlators/protocol/server/src/server.c index 18be607a9..190da28e3 100644 --- a/xlators/protocol/server/src/server.c +++ b/xlators/protocol/server/src/server.c @@ -60,8 +60,12 @@ gfs_serialize_reply (rpcsvc_request_t *req, void *arg, gfs_serialize_t sfunc, */ retlen = sfunc (*outmsg, arg); if (retlen == -1) { + /* Failed to Encode 'GlusterFS' msg in RPC is not exactly + failure of RPC return values.. client should get + notified about this, so there are no missing frames */ gf_log ("", GF_LOG_ERROR, "Failed to encode message"); - goto ret; + req->rpc_err = GARBAGE_ARGS; + retlen = 0; } outmsg->iov_len = retlen; |