renamed xlator/protocol to xlator/protocol/legacy

Signed-off-by: Amar Tumballi <amar@gluster.com>
Signed-off-by: Raghavendra G <raghavendra@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875

44 files changed, 58 insertions, 27 deletions

diff --git a/xlators/protocol/Makefile.am b/xlators/protocol/Makefile.am
index bef0c6624..0e1eca0c8 100644
--- a/xlators/protocol/Makefile.am
+++ b/xlators/protocol/Makefile.am
@@ -1,3 +1,3 @@
-SUBDIRS = lib transport client server auth
+SUBDIRS = lib auth legacy
 
 CLEANFILES = 
diff --git a/xlators/protocol/auth/addr/src/Makefile.am b/xlators/protocol/auth/addr/src/Makefile.am
index 9b053a846..2c94c94e4 100644
--- a/xlators/protocol/auth/addr/src/Makefile.am
+++ b/xlators/protocol/auth/addr/src/Makefile.am
@@ -5,7 +5,7 @@ addr_la_LDFLAGS = -module -avoidversion
 
 addr_la_SOURCES = addr.c
 addr_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la \
-	$(top_builddir)/xlators/protocol/lib/src/libgfproto.la
+	$(top_builddir)/xlators/protocol/lib/src/libgfproto1.la
 
 AM_CFLAGS = -fPIC -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -Wall -D$(GF_HOST_OS)\
 	-I$(top_srcdir)/libglusterfs/src -shared -nostartfiles $(GF_CFLAGS) \
diff --git a/xlators/protocol/auth/addr/src/addr.c b/xlators/protocol/auth/addr/src/addr.c
index a8803a39f..729233fa1 100644
--- a/xlators/protocol/auth/addr/src/addr.c
+++ b/xlators/protocol/auth/addr/src/addr.c
@@ -36,6 +36,13 @@
 #define AF_INET_SDP 27
 #endif
 
+/* TODO: duplicate declaration */
+typedef struct peer_info {
+        struct sockaddr_storage sockaddr;
+        socklen_t sockaddr_len;
+        char identifier[UNIX_PATH_MAX];
+}peer_info_t;
+
 auth_result_t 
 gf_auth (dict_t *input_params, dict_t *config_params)
 {
diff --git a/xlators/protocol/auth/login/src/Makefile.am b/xlators/protocol/auth/login/src/Makefile.am
index 4a50e07d3..ef99a965b 100644
--- a/xlators/protocol/auth/login/src/Makefile.am
+++ b/xlators/protocol/auth/login/src/Makefile.am
@@ -5,7 +5,7 @@ login_la_LDFLAGS = -module -avoidversion
 
 login_la_SOURCES = login.c
 login_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la \
-	$(top_builddir)/xlators/protocol/lib/src/libgfproto.la
+	$(top_builddir)/xlators/protocol/lib/src/libgfproto1.la
 
 
 AM_CFLAGS = -fPIC -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -Wall -D$(GF_HOST_OS)\
diff --git a/xlators/protocol/legacy/Makefile.am b/xlators/protocol/legacy/Makefile.am
new file mode 100644
index 000000000..991486302
--- /dev/null
+++ b/xlators/protocol/legacy/Makefile.am
@@ -0,0 +1,3 @@
+SUBDIRS = lib transport client server
+
+CLEANFILES =
diff --git a/xlators/protocol/client/Makefile.am b/xlators/protocol/legacy/client/Makefile.am
index d471a3f92..d471a3f92 100644
--- a/xlators/protocol/client/Makefile.am
+++ b/xlators/protocol/legacy/client/Makefile.am
diff --git a/xlators/protocol/client/src/Makefile.am b/xlators/protocol/legacy/client/src/Makefile.am
index e3c6385c0..da00a5182 100644
--- a/xlators/protocol/client/src/Makefile.am
+++ b/xlators/protocol/legacy/client/src/Makefile.am
@@ -6,13 +6,13 @@ client_la_LDFLAGS = -module -avoidversion
 
 client_la_SOURCES = client-protocol.c saved-frames.c
 client_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la \
-	$(top_builddir)/xlators/protocol/lib/src/libgfproto.la
+	$(top_builddir)/xlators/protocol/legacy/lib/src/libgfproto.la
 
 noinst_HEADERS = client-protocol.h saved-frames.h client-mem-types.h
 
 AM_CFLAGS = -fPIC -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -Wall -D$(GF_HOST_OS) \
 	-I$(top_srcdir)/libglusterfs/src -shared -nostartfiles $(GF_CFLAGS)  \
-	-I$(top_srcdir)/xlators/protocol/lib/src
+	-I$(top_srcdir)/xlators/protocol/legacy/lib/src
 
 CLEANFILES = 
 
diff --git a/xlators/protocol/client/src/client-mem-types.h b/xlators/protocol/legacy/client/src/client-mem-types.h
index 1eee8d931..1eee8d931 100644
--- a/xlators/protocol/client/src/client-mem-types.h
+++ b/xlators/protocol/legacy/client/src/client-mem-types.h
diff --git a/xlators/protocol/client/src/client-protocol.c b/xlators/protocol/legacy/client/src/client-protocol.c
index 50030f8cf..50030f8cf 100644
--- a/xlators/protocol/client/src/client-protocol.c
+++ b/xlators/protocol/legacy/client/src/client-protocol.c
diff --git a/xlators/protocol/client/src/client-protocol.h b/xlators/protocol/legacy/client/src/client-protocol.h
index ae65fb5fe..ae65fb5fe 100644
--- a/xlators/protocol/client/src/client-protocol.h
+++ b/xlators/protocol/legacy/client/src/client-protocol.h
diff --git a/xlators/protocol/client/src/saved-frames.c b/xlators/protocol/legacy/client/src/saved-frames.c
index 770de19ad..770de19ad 100644
--- a/xlators/protocol/client/src/saved-frames.c
+++ b/xlators/protocol/legacy/client/src/saved-frames.c
diff --git a/xlators/protocol/client/src/saved-frames.h b/xlators/protocol/legacy/client/src/saved-frames.h
index 5c18abbcc..5c18abbcc 100644
--- a/xlators/protocol/client/src/saved-frames.h
+++ b/xlators/protocol/legacy/client/src/saved-frames.h
diff --git a/xlators/protocol/server/Makefile.am b/xlators/protocol/legacy/lib/Makefile.am
index d471a3f92..d471a3f92 100644
--- a/xlators/protocol/server/Makefile.am
+++ b/xlators/protocol/legacy/lib/Makefile.am
diff --git a/xlators/protocol/legacy/lib/src/Makefile.am b/xlators/protocol/legacy/lib/src/Makefile.am
new file mode 100644
index 000000000..1f0e93e30
--- /dev/null
+++ b/xlators/protocol/legacy/lib/src/Makefile.am
@@ -0,0 +1,14 @@
+lib_LTLIBRARIES = libgfproto.la
+
+libgfproto_la_CFLAGS = -fPIC  -Wall -g -shared -nostartfiles $(GF_CFLAGS) $(GF_DARWIN_LIBGLUSTERFS_CFLAGS)
+
+libgfproto_la_CPPFLAGS = -D_FILE_OFFSET_BITS=64 -D__USE_FILE_OFFSET64 -D_GNU_SOURCE  \
+	-D$(GF_HOST_OS) -DLIBDIR=\"$(libdir)/glusterfs/$(PACKAGE_VERSION)/auth\"     \
+	-DTRANSPORTDIR=\"$(libdir)/glusterfs/$(PACKAGE_VERSION)/transport\"          \
+	-I$(CONTRIBDIR)/rbtree -I$(top_srcdir)/libglusterfs/src/
+
+libgfproto_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la
+
+libgfproto_la_SOURCES = transport.c protocol.c
+
+noinst_HEADERS = transport.h protocol.h
diff --git a/xlators/protocol/lib/src/protocol.c b/xlators/protocol/legacy/lib/src/protocol.c
index 63950f43d..63950f43d 100644
--- a/xlators/protocol/lib/src/protocol.c
+++ b/xlators/protocol/legacy/lib/src/protocol.c
diff --git a/xlators/protocol/lib/src/protocol.h b/xlators/protocol/legacy/lib/src/protocol.h
index 254e36e66..254e36e66 100644
--- a/xlators/protocol/lib/src/protocol.h
+++ b/xlators/protocol/legacy/lib/src/protocol.h
diff --git a/xlators/protocol/lib/src/transport.c b/xlators/protocol/legacy/lib/src/transport.c
index d460d0209..d460d0209 100644
--- a/xlators/protocol/lib/src/transport.c
+++ b/xlators/protocol/legacy/lib/src/transport.c
diff --git a/xlators/protocol/lib/src/transport.h b/xlators/protocol/legacy/lib/src/transport.h
index f0623d5b4..f0623d5b4 100644
--- a/xlators/protocol/lib/src/transport.h
+++ b/xlators/protocol/legacy/lib/src/transport.h
diff --git a/xlators/protocol/legacy/server/Makefile.am b/xlators/protocol/legacy/server/Makefile.am
new file mode 100644
index 000000000..d471a3f92
--- /dev/null
+++ b/xlators/protocol/legacy/server/Makefile.am
@@ -0,0 +1,3 @@
+SUBDIRS = src
+
+CLEANFILES = 
diff --git a/xlators/protocol/server/src/Makefile.am b/xlators/protocol/legacy/server/src/Makefile.am
index ebe06eacf..87d3042c5 100644
--- a/xlators/protocol/server/src/Makefile.am
+++ b/xlators/protocol/legacy/server/src/Makefile.am
@@ -5,8 +5,9 @@ xlatordir = $(libdir)/glusterfs/$(PACKAGE_VERSION)/xlator/protocol
 server_la_LDFLAGS = -module -avoidversion
 
 server_la_SOURCES = server-protocol.c server-resolve.c server-helpers.c
-server_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la \
-	$(top_builddir)/xlators/protocol/lib/src/libgfproto.la
+server_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la   \
+	$(top_builddir)/xlators/protocol/legacy/lib/src/libgfproto.la \
+	$(top_builddir)/xlators/protocol/lib/src/libgfproto1.la
 
 noinst_HEADERS = server-protocol.h server-helpers.h server-mem-types.h
 
@@ -14,7 +15,8 @@ AM_CFLAGS = -fPIC -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -Wall -D$(GF_HOST_OS) \
 	-I$(top_srcdir)/libglusterfs/src -shared -nostartfiles \
 	-I$(top_srcdir)/contrib/md5/ \
 	-DDATADIR=\"$(localstatedir)\" -DCONFDIR=\"$(sysconfdir)/glusterfs\"  \
-	$(GF_CFLAGS) -I$(top_srcdir)/xlators/protocol/lib/src
+	$(GF_CFLAGS) -I$(top_srcdir)/xlators/protocol/legacy/lib/src \
+	-I$(top_srcdir)/xlators/protocol/lib/src
 
 CLEANFILES =
 
diff --git a/xlators/protocol/server/src/server-helpers.c b/xlators/protocol/legacy/server/src/server-helpers.c
index d07e841f2..d07e841f2 100644
--- a/xlators/protocol/server/src/server-helpers.c
+++ b/xlators/protocol/legacy/server/src/server-helpers.c
diff --git a/xlators/protocol/server/src/server-helpers.h b/xlators/protocol/legacy/server/src/server-helpers.h
index cbf57ae44..cbf57ae44 100644
--- a/xlators/protocol/server/src/server-helpers.h
+++ b/xlators/protocol/legacy/server/src/server-helpers.h
diff --git a/xlators/protocol/server/src/server-mem-types.h b/xlators/protocol/legacy/server/src/server-mem-types.h
index 86877d79d..86877d79d 100644
--- a/xlators/protocol/server/src/server-mem-types.h
+++ b/xlators/protocol/legacy/server/src/server-mem-types.h
diff --git a/xlators/protocol/server/src/server-protocol.c b/xlators/protocol/legacy/server/src/server-protocol.c
index 31f3e7aca..de7d2ac0b 100644
--- a/xlators/protocol/server/src/server-protocol.c
+++ b/xlators/protocol/legacy/server/src/server-protocol.c
@@ -5479,6 +5479,10 @@ mop_setvolume (call_frame_t *frame, xlator_t *bound_xl,
         if (ret < 0)
                 gf_log (trans->xl->name, GF_LOG_DEBUG,
                         "failed to set peer-info");
+        ret = dict_set_str (params, "peer-info-name", peerinfo->identifier);
+        if (ret < 0)
+                gf_log (trans->xl->name, GF_LOG_DEBUG,
+                        "failed to set peer-info-name");
 
         if (conf->auth_modules == NULL) {
                 gf_log (trans->xl->name, GF_LOG_ERROR,
diff --git a/xlators/protocol/server/src/server-protocol.h b/xlators/protocol/legacy/server/src/server-protocol.h
index 3d432614c..0c2100059 100644
--- a/xlators/protocol/server/src/server-protocol.h
+++ b/xlators/protocol/legacy/server/src/server-protocol.h
@@ -31,10 +31,11 @@
 #include "xlator.h"
 #include "logging.h"
 #include "call-stub.h"
-#include "authenticate.h"
 #include "fd.h"
 #include "byte-order.h"
 #include "server-mem-types.h"
+#include "authenticate.h"
+#include "transport.h"
 
 #define DEFAULT_BLOCK_SIZE         4194304   /* 4MB */
 #define DEFAULT_VOLUME_FILE_PATH   CONFDIR "/glusterfs.vol"
diff --git a/xlators/protocol/server/src/server-resolve.c b/xlators/protocol/legacy/server/src/server-resolve.c
index f0da94384..f0da94384 100644
--- a/xlators/protocol/server/src/server-resolve.c
+++ b/xlators/protocol/legacy/server/src/server-resolve.c
diff --git a/xlators/protocol/transport/Makefile.am b/xlators/protocol/legacy/transport/Makefile.am
index e2f97437c..e2f97437c 100644
--- a/xlators/protocol/transport/Makefile.am
+++ b/xlators/protocol/legacy/transport/Makefile.am
diff --git a/xlators/protocol/transport/ib-verbs/Makefile.am b/xlators/protocol/legacy/transport/ib-verbs/Makefile.am
index f963effea..f963effea 100644
--- a/xlators/protocol/transport/ib-verbs/Makefile.am
+++ b/xlators/protocol/legacy/transport/ib-verbs/Makefile.am
diff --git a/xlators/protocol/transport/ib-verbs/src/Makefile.am b/xlators/protocol/legacy/transport/ib-verbs/src/Makefile.am
index 63f7fabb8..3db7aff98 100644
--- a/xlators/protocol/transport/ib-verbs/src/Makefile.am
+++ b/xlators/protocol/legacy/transport/ib-verbs/src/Makefile.am
@@ -7,13 +7,13 @@ ib_verbs_la_LDFLAGS = -module -avoidversion
 
 ib_verbs_la_SOURCES = ib-verbs.c name.c
 ib_verbs_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la     \
-	-libverbs $(top_builddir)/xlators/protocol/lib/src/libgfproto.la
+	-libverbs $(top_builddir)/xlators/protocol/legacy/lib/src/libgfproto.la
 
 noinst_HEADERS = ib-verbs.h name.h ib-verbs-mem-types.h
 
 AM_CFLAGS = -fPIC -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -Wall -D$(GF_HOST_OS)  \
 	-I$(top_srcdir)/libglusterfs/src -shared -nostartfiles $(GF_CFLAGS)   \
-	-I$(top_srcdir)/xlators/protocol/transport/ib-verbs                    \
-	-I$(top_srcdir)/xlators/protocol/lib/src
+	-I$(top_srcdir)/xlators/protocol/legacy/transport/ib-verbs                    \
+	-I$(top_srcdir)/xlators/protocol/legacy/lib/src
 
 CLEANFILES = *~
diff --git a/xlators/protocol/transport/ib-verbs/src/ib-verbs-mem-types.h b/xlators/protocol/legacy/transport/ib-verbs/src/ib-verbs-mem-types.h
index bac559646..bac559646 100644
--- a/xlators/protocol/transport/ib-verbs/src/ib-verbs-mem-types.h
+++ b/xlators/protocol/legacy/transport/ib-verbs/src/ib-verbs-mem-types.h
diff --git a/xlators/protocol/transport/ib-verbs/src/ib-verbs.c b/xlators/protocol/legacy/transport/ib-verbs/src/ib-verbs.c
index c14be17e6..c14be17e6 100644
--- a/xlators/protocol/transport/ib-verbs/src/ib-verbs.c
+++ b/xlators/protocol/legacy/transport/ib-verbs/src/ib-verbs.c
diff --git a/xlators/protocol/transport/ib-verbs/src/ib-verbs.h b/xlators/protocol/legacy/transport/ib-verbs/src/ib-verbs.h
index c385b62e5..c385b62e5 100644
--- a/xlators/protocol/transport/ib-verbs/src/ib-verbs.h
+++ b/xlators/protocol/legacy/transport/ib-verbs/src/ib-verbs.h
diff --git a/xlators/protocol/transport/ib-verbs/src/name.c b/xlators/protocol/legacy/transport/ib-verbs/src/name.c
index a3e184814..a3e184814 100644
--- a/xlators/protocol/transport/ib-verbs/src/name.c
+++ b/xlators/protocol/legacy/transport/ib-verbs/src/name.c
diff --git a/xlators/protocol/transport/ib-verbs/src/name.h b/xlators/protocol/legacy/transport/ib-verbs/src/name.h
index 4f0f47711..4f0f47711 100644
--- a/xlators/protocol/transport/ib-verbs/src/name.h
+++ b/xlators/protocol/legacy/transport/ib-verbs/src/name.h
diff --git a/xlators/protocol/transport/socket/Makefile.am b/xlators/protocol/legacy/transport/socket/Makefile.am
index f963effea..f963effea 100644
--- a/xlators/protocol/transport/socket/Makefile.am
+++ b/xlators/protocol/legacy/transport/socket/Makefile.am
diff --git a/xlators/protocol/transport/socket/src/Makefile.am b/xlators/protocol/legacy/transport/socket/src/Makefile.am
index 9788c7a2c..5952e18e9 100644
--- a/xlators/protocol/transport/socket/src/Makefile.am
+++ b/xlators/protocol/legacy/transport/socket/src/Makefile.am
@@ -7,13 +7,13 @@ socket_la_LDFLAGS = -module -avoidversion
 
 socket_la_SOURCES = socket.c name.c
 socket_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la \
-	$(top_builddir)/xlators/protocol/lib/src/libgfproto.la
+	$(top_builddir)/xlators/protocol/legacy/lib/src/libgfproto.la
 
 noinst_HEADERS = socket.h name.h socket-mem-types.h
 
 AM_CFLAGS = -fPIC -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -Wall -D$(GF_HOST_OS)\
 	-I$(top_srcdir)/libglusterfs/src -shared -nostartfiles $(GF_CFLAGS) \
-	-I$(top_srcdir)/xlators/protocol/transport/socket/src   \
-	-I$(top_srcdir)/xlators/protocol/lib/src
+	-I$(top_srcdir)/xlators/protocol/legacy/transport/socket/src   \
+	-I$(top_srcdir)/xlators/protocol/legacy/lib/src
 
 CLEANFILES = *~
diff --git a/xlators/protocol/transport/socket/src/name.c b/xlators/protocol/legacy/transport/socket/src/name.c
index 74abe4480..74abe4480 100644
--- a/xlators/protocol/transport/socket/src/name.c
+++ b/xlators/protocol/legacy/transport/socket/src/name.c
diff --git a/xlators/protocol/transport/socket/src/name.h b/xlators/protocol/legacy/transport/socket/src/name.h
index f50a7b7f4..f50a7b7f4 100644
--- a/xlators/protocol/transport/socket/src/name.h
+++ b/xlators/protocol/legacy/transport/socket/src/name.h
diff --git a/xlators/protocol/transport/socket/src/socket-mem-types.h b/xlators/protocol/legacy/transport/socket/src/socket-mem-types.h
index f50f4a75d..f50f4a75d 100644
--- a/xlators/protocol/transport/socket/src/socket-mem-types.h
+++ b/xlators/protocol/legacy/transport/socket/src/socket-mem-types.h
diff --git a/xlators/protocol/transport/socket/src/socket.c b/xlators/protocol/legacy/transport/socket/src/socket.c
index fd3815d83..fd3815d83 100644
--- a/xlators/protocol/transport/socket/src/socket.c
+++ b/xlators/protocol/legacy/transport/socket/src/socket.c
diff --git a/xlators/protocol/transport/socket/src/socket.h b/xlators/protocol/legacy/transport/socket/src/socket.h
index e02801a5b..e02801a5b 100644
--- a/xlators/protocol/transport/socket/src/socket.h
+++ b/xlators/protocol/legacy/transport/socket/src/socket.h
diff --git a/xlators/protocol/lib/src/Makefile.am b/xlators/protocol/lib/src/Makefile.am
index 53131f6d0..6e0b5c4e0 100644
--- a/xlators/protocol/lib/src/Makefile.am
+++ b/xlators/protocol/lib/src/Makefile.am
@@ -1,15 +1,14 @@
-libgfproto_la_CFLAGS = -fPIC  -Wall -g -shared -nostartfiles $(GF_CFLAGS) $(GF_DARWIN_LIBGLUSTERFS_CFLAGS)
+lib_LTLIBRARIES = libgfproto1.la
 
-libgfproto_la_CPPFLAGS = -D_FILE_OFFSET_BITS=64 -D__USE_FILE_OFFSET64 -D_GNU_SOURCE  \
+libgfproto1_la_CFLAGS = -fPIC  -Wall -g -shared -nostartfiles $(GF_CFLAGS) $(GF_DARWIN_LIBGLUSTERFS_CFLAGS)
+
+libgfproto1_la_CPPFLAGS = -D_FILE_OFFSET_BITS=64 -D__USE_FILE_OFFSET64 -D_GNU_SOURCE  \
 	-D$(GF_HOST_OS) -DLIBDIR=\"$(libdir)/glusterfs/$(PACKAGE_VERSION)/auth\"     \
 	-DTRANSPORTDIR=\"$(libdir)/glusterfs/$(PACKAGE_VERSION)/transport\"          \
 	-I$(CONTRIBDIR)/rbtree -I$(top_srcdir)/libglusterfs/src/
 
-libgfproto_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la
-
-lib_LTLIBRARIES = libgfproto.la
-
+libgfproto1_la_LIBADD = $(top_builddir)/libglusterfs/src/libglusterfs.la
 
-libgfproto_la_SOURCES = transport.c authenticate.c protocol.c
+libgfproto1_la_SOURCES = authenticate.c
 
-noinst_HEADERS =  transport.h  protocol.h authenticate.h
+noinst_HEADERS = authenticate.h
diff --git a/xlators/protocol/lib/src/authenticate.c b/xlators/protocol/lib/src/authenticate.c
index eb0e2464c..ff2b58162 100644
--- a/xlators/protocol/lib/src/authenticate.c
+++ b/xlators/protocol/lib/src/authenticate.c
@@ -223,12 +223,11 @@ gf_authenticate (dict_t *input_params,
 
 	dict_foreach (results, reduce, &result);
 	if (AUTH_DONT_CARE == result) {
-		data_t *peerinfo_data = dict_get (input_params, "peer-info");
+		data_t *peerinfo_data = dict_get (input_params, "peer-info-name");
 		char *name = NULL;
 
 		if (peerinfo_data) {
-			peer_info_t *peerinfo = data_to_ptr (peerinfo_data);
-			name = peerinfo->identifier;
+			name = peerinfo_data->data;
 		}
 
 		gf_log ("auth", GF_LOG_ERROR,
diff --git a/xlators/protocol/lib/src/authenticate.h b/xlators/protocol/lib/src/authenticate.h
index 8931f62e6..e77714652 100644
--- a/xlators/protocol/lib/src/authenticate.h
+++ b/xlators/protocol/lib/src/authenticate.h
@@ -34,7 +34,6 @@
 #include "dict.h"
 #include "compat.h"
 #include "list.h"
-#include "transport.h"
 #include "xlator.h"
 
 typedef enum {