From 45a9d1e70e0d3e0ab504643a3cd1bf3f0a3a43fd Mon Sep 17 00:00:00 2001 From: Kaushal M Date: Fri, 26 Apr 2013 11:39:15 +0530 Subject: distribute: Fix fds being leaked during rebalance This patch is a backport of 2 patches from master branch which fixes the leak of fds during a rebalance process. The patches are, * libglusterfs/syncop: do not hold ref on the fd in cbk (e979c0de9dde14fe18d0ad7298c6da9cc878bbab) * cluster/distribute: Remove suprious fd_unref call (5d29e598665456b2b7250fdca14de7409098877a) Change-Id: Icea1d0b32cb3670f7decc24261996bca3fe816dc BUG: 928631 Signed-off-by: Kaushal M Reviewed-on: http://review.gluster.org/4888 Reviewed-by: Vijay Bellur Tested-by: Gluster Build System --- libglusterfs/src/syncop.c | 6 ------ 1 file changed, 6 deletions(-) (limited to 'libglusterfs/src') diff --git a/libglusterfs/src/syncop.c b/libglusterfs/src/syncop.c index 4be002198..0c4620643 100644 --- a/libglusterfs/src/syncop.c +++ b/libglusterfs/src/syncop.c @@ -931,9 +931,6 @@ syncop_open_cbk (call_frame_t *frame, void *cookie, xlator_t *this, args->op_ret = op_ret; args->op_errno = op_errno; - if (op_ret != -1) - fd_ref (fd); - __wake (args); return 0; @@ -1079,9 +1076,6 @@ syncop_create_cbk (call_frame_t *frame, void *cookie, xlator_t *this, args->op_ret = op_ret; args->op_errno = op_errno; - if (op_ret != -1) - fd_ref (fd); - __wake (args); return 0; -- cgit