From dcebed550ebfc878b0b3bd02ab7fe15db6764f81 Mon Sep 17 00:00:00 2001 From: Krishnan Parthasarathi Date: Mon, 15 Apr 2013 22:07:21 +0530 Subject: glusterd: Avoided deadlock in single node cluster, glusterd restart In a single node cluster, it is possible to deadlock on the "big lock", while restarting bricks. In glusterd_restart_bricks, we perform a glusterd_brick_connect, where we release the big lock in anticipation that glusterd_brick_rpc_notify could run in the same C stack (and deadlocking). So, in the restart code path, we could unlock before we have performed a lock on the big lock. To fix this, we need to take the big lock in the glusterd_launch_synctask 'thread' as well. Change-Id: I1abea1ca82b55c784b8a810a8194f254b32b1dcc BUG: 948686 Signed-off-by: Krishnan Parthasarathi Reviewed-on: http://review.gluster.org/4837 Tested-by: Gluster Build System Reviewed-by: Jeff Darcy --- tests/bugs/bug-948686.t | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'tests/bugs/bug-948686.t') diff --git a/tests/bugs/bug-948686.t b/tests/bugs/bug-948686.t index 63c099a79..db9c198a9 100644 --- a/tests/bugs/bug-948686.t +++ b/tests/bugs/bug-948686.t @@ -34,3 +34,13 @@ TEST $CLI_2 volume stop $V0; TEST $CLI_2 volume delete $V0; cleanup; + +TEST glusterd; +TEST $CLI volume create $V0 $H0:$B0/$V0 +TEST $CLI volume start $V0 +pkill glusterd; +pkill glusterfsd; +TEST glusterd +TEST $CLI volume status $V0 + +cleanup; -- cgit