From 66d5d91465deba55afa9e1ab3a2160fc9d1b9275 Mon Sep 17 00:00:00 2001 From: Pranith Kumar K Date: Wed, 20 Mar 2013 08:36:14 +0530 Subject: performance/io-threads: Fix range-check for least-rate-limit The issue could be fixed with .validate=GF_OPT_VALIDATE_MIN. But adding max value is more robust. Change-Id: Ia69c6f86855dbd34a26e20391e77bfa0f796a200 BUG: 923573 Signed-off-by: Pranith Kumar K Reviewed-on: http://review.gluster.org/4698 Reviewed-by: Brian Foster Reviewed-by: Jeff Darcy Tested-by: Gluster Build System --- tests/bugs/bug-853680.t | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to 'tests') diff --git a/tests/bugs/bug-853680.t b/tests/bugs/bug-853680.t index a4853c07f..72d53ae6c 100755 --- a/tests/bugs/bug-853680.t +++ b/tests/bugs/bug-853680.t @@ -15,6 +15,21 @@ TEST glusterd TEST $CLI volume create $V0 $H0:$B0/${V0}1 TEST $CLI volume start $V0 +#Accept min val +TEST $CLI volume set $V0 performance.least-rate-limit 0 +#Accept some value in between +TEST $CLI volume set $V0 performance.least-rate-limit 1035 +#Accept max val INT_MAX +TEST $CLI volume set $V0 performance.least-rate-limit 2147483647 + +#Reject other values +TEST ! $CLI volume set $V0 performance.least-rate-limit 2147483648 +TEST ! $CLI volume set $V0 performace.least-rate-limit -8 +TEST ! $CLI volume set $V0 performance.least-rate-limit abc +TEST ! $CLI volume set $V0 performance.least-rate-limit 0.0 +TEST ! $CLI volume set $V0 performance.least-rate-limit -10.0 +TEST ! $CLI volume set $V0 performance.least-rate-limit 1% + # set rate limit to 1 operation/sec TEST $CLI volume set $V0 performance.least-rate-limit 1 -- cgit