From 522b2bdb540bef4911e0874030d1f9b3003ba104 Mon Sep 17 00:00:00 2001 From: "Anand V. Avati" Date: Thu, 2 Apr 2009 15:51:34 +0530 Subject: socket_connect() - if socket is already created, do not fail transport_connect() -- causes spurious CHILD_DOWN events to be sent up when reconnect() thread misinterprets the failure of transport_connect() to be an actual teardown of the transport the spurious CHILD_DOWN events cause self-heal in replicate to not heal files in that subvolume, writev to not modify that subvolume etc, accounting for a lot of discrepencies in replicate which are being in the mailing lists recently. Signed-off-by: Anand V. Avati --- transport/socket/src/socket.c | 1 + 1 file changed, 1 insertion(+) (limited to 'transport') diff --git a/transport/socket/src/socket.c b/transport/socket/src/socket.c index fe18808a0..14f151cb0 100644 --- a/transport/socket/src/socket.c +++ b/transport/socket/src/socket.c @@ -949,6 +949,7 @@ socket_connect (transport_t *this) if (sock != -1) { gf_log (this->xl->name, GF_LOG_DEBUG, "connect () called on transport already connected"); + ret = 0; goto err; } -- cgit