From 5499205a08c0b69156628684b5dc235f1355b026 Mon Sep 17 00:00:00 2001
From: Krishnan Parthasarathi <kparthas@redhat.com>
Date: Sat, 8 Sep 2012 12:12:48 +0530
Subject: glusterd: Expect setmntent(3) to return NULL

- Closed the mtab FILE * using endmntent(3)

Change-Id: I5e1ebb7f092abda638cfbb5524da693dcac6c872
BUG: 851109
Signed-off-by: Krishnan Parthasarathi <kparthas@redhat.com>
Reviewed-on: http://review.gluster.org/3920
Tested-by: Gluster Build System <jenkins@build.gluster.com>
Reviewed-by: Amar Tumballi <amarts@redhat.com>
Reviewed-by: Anand Avati <avati@redhat.com>
---
 xlators/mgmt/glusterd/src/glusterd-utils.c | 8 ++++++++
 1 file changed, 8 insertions(+)

(limited to 'xlators/mgmt')

diff --git a/xlators/mgmt/glusterd/src/glusterd-utils.c b/xlators/mgmt/glusterd/src/glusterd-utils.c
index 3a48a41d7..b5596b925 100644
--- a/xlators/mgmt/glusterd/src/glusterd-utils.c
+++ b/xlators/mgmt/glusterd/src/glusterd-utils.c
@@ -3814,6 +3814,11 @@ glusterd_add_brick_mount_details (glusterd_brickinfo_t *brickinfo,
                 goto out;
 
         mtab = setmntent (_PATH_MOUNTED, "r");
+        if (!mtab) {
+                ret = -1;
+                goto out;
+        }
+
         entry = getmntent (mtab);
 
         while (1) {
@@ -3854,6 +3859,9 @@ glusterd_add_brick_mount_details (glusterd_brickinfo_t *brickinfo,
 
  out:
         GF_FREE (mnt_pt);
+        if (mtab)
+                endmntent (mtab);
+
         return ret;
 }
 #endif
-- 
cgit