From 81c04158559f9f61ff0581544541cc18778cb1de Mon Sep 17 00:00:00 2001 From: Amar Tumballi Date: Thu, 21 Apr 2011 07:08:28 +0000 Subject: prevent few excessive logs Signed-off-by: Amar Tumballi Signed-off-by: Anand Avati BUG: 2346 (Log message enhancements in GlusterFS - phase 1) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2346 --- xlators/protocol/client/src/client3_1-fops.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'xlators/protocol/client/src/client3_1-fops.c') diff --git a/xlators/protocol/client/src/client3_1-fops.c b/xlators/protocol/client/src/client3_1-fops.c index 492c469d8..f1f6bd0a4 100644 --- a/xlators/protocol/client/src/client3_1-fops.c +++ b/xlators/protocol/client/src/client3_1-fops.c @@ -887,7 +887,7 @@ client3_1_getxattr_cbk (struct rpc_req *req, struct iovec *iov, int count, out: if (rsp.op_ret == -1) { gf_log (this->name, GF_LOG_INFO, "remote operation failed: %s", - strerror (gf_error_to_errno (rsp.op_errno))); + strerror (op_errno)); } STACK_UNWIND_STRICT (getxattr, frame, op_ret, op_errno, dict); @@ -970,7 +970,7 @@ client3_1_fgetxattr_cbk (struct rpc_req *req, struct iovec *iov, int count, out: if (rsp.op_ret == -1) { gf_log (this->name, GF_LOG_INFO, "remote operation failed: %s", - strerror (gf_error_to_errno (rsp.op_errno))); + strerror (op_errno)); } STACK_UNWIND_STRICT (fgetxattr, frame, op_ret, op_errno, dict); if (rsp.dict.dict_val) { @@ -2212,7 +2212,7 @@ client3_1_lookup_cbk (struct rpc_req *req, struct iovec *iov, int count, gf_log (frame->this->name, GF_LOG_DEBUG, "gfid changed for %s", local->loc.path); rsp.op_ret = -1; - rsp.op_errno = ESTALE; + op_errno = ESTALE; goto out; } @@ -2222,11 +2222,10 @@ out: rsp.op_errno = op_errno; frame->local = NULL; if (rsp.op_ret == -1) { - /* any error other than ENOENT or for revalidate for ENOENT too */ - if ((gf_error_to_errno (rsp.op_errno) != ENOENT) || - !uuid_is_null (local->loc.inode->gfid)) + /* any error other than ENOENT */ + if (rsp.op_errno != ENOENT) gf_log (this->name, GF_LOG_INFO, "remote operation failed: %s", - strerror (gf_error_to_errno (rsp.op_errno))); + strerror (rsp.op_errno)); else gf_log (this->name, GF_LOG_TRACE, "not found on remote node"); -- cgit