From 233af471f0ab027bdd9df1844111dd560f334d75 Mon Sep 17 00:00:00 2001 From: Valerii Ponomarov Date: Wed, 13 Mar 2019 17:02:13 +0530 Subject: Make 'enable_pvc_resize' func raise error only on non-zero return code As of now, it raises exception when our command doesn't fail, but has empty output. It is bug. So, fix it by checking only return code being non-zero. Change-Id: I6c029e17220d6ae7eb184348d84c189ba03274c8 --- cns-libs/cnslibs/common/cns_libs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'cns-libs') diff --git a/cns-libs/cnslibs/common/cns_libs.py b/cns-libs/cnslibs/common/cns_libs.py index 3c7bdc91..f7fc92f9 100644 --- a/cns-libs/cnslibs/common/cns_libs.py +++ b/cns-libs/cnslibs/common/cns_libs.py @@ -126,7 +126,7 @@ def enable_pvc_resize(master_node): cmd = ("/usr/local/bin/master-restart api && " "/usr/local/bin/master-restart controllers") ret, out, err = g.run(master_node, cmd, "root") - if ret != 0 or out == "": + if ret != 0: err_msg = "Failed to execute cmd %s on %s\nout: %s\nerr: %s" % ( cmd, master_node, out, err) g.log.error(err_msg) -- cgit