From 85b1c8a2cb07071bcfd1ed1405ba9e7d5d66e483 Mon Sep 17 00:00:00 2001 From: kshithijiyer Date: Sat, 18 Jan 2020 20:17:11 +0530 Subject: [TestFix] Optimize repeated dictionary access using loop Change-Id: I332a66659b5abefb5d5052232ec9b61124860575 Signed-off-by: kshithijiyer --- tests/functional/heketi/test_heketi_device_operations.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'tests/functional/heketi') diff --git a/tests/functional/heketi/test_heketi_device_operations.py b/tests/functional/heketi/test_heketi_device_operations.py index fb9be309..b4987ba6 100644 --- a/tests/functional/heketi/test_heketi_device_operations.py +++ b/tests/functional/heketi/test_heketi_device_operations.py @@ -505,9 +505,8 @@ class TestHeketiDeviceOperations(BaseClass): for key in ('id', 'name', 'state', 'storage', 'bricks'): self.assertIn(key, list(device_from_t_info.keys())) self.assertIn(key, list(device_info.keys())) - self.assertEqual(device_info['id'], device_from_t_info['id']) - self.assertEqual(device_info['name'], device_from_t_info['name']) - self.assertEqual(device_info['state'], device_from_t_info['state']) + for key in ('id', 'name', 'state'): + self.assertEqual(device_info[key], device_from_t_info[key]) device_info_storage = device_info['storage'] device_from_t_info_storage = device_from_t_info['storage'] device_info_storage_keys = list(device_info_storage.keys()) -- cgit