From d98c3e19342be3b8b3e2c7e3d7e544de34143bdf Mon Sep 17 00:00:00 2001 From: Amar Tumballi Date: Mon, 19 Mar 2012 18:10:34 +0530 Subject: rpc-clnt: separate out connection_cleanup() from destroy() noticed that there are possibilities where one would like to do a connection_cleanup() before destroying a RPC connection itself, also current code is such that, rpc_clnt_connection_cleanup() does rpc_clnt_ref() and unref(), creating a race window/double unref possibilities in the code. by separating out the functions, this race window/double fault can be prevented. Change-Id: I7ebd3392efa891232857b6db9108b0b19e40fc12 Signed-off-by: Amar Tumballi BUG: 802403 Reviewed-on: http://review.gluster.com/2979 Tested-by: Gluster Build System Reviewed-by: Vijay Bellur --- rpc/rpc-lib/src/rpc-clnt.c | 1 - 1 file changed, 1 deletion(-) (limited to 'rpc/rpc-lib/src/rpc-clnt.c') diff --git a/rpc/rpc-lib/src/rpc-clnt.c b/rpc/rpc-lib/src/rpc-clnt.c index 5867c322b..428a82b76 100644 --- a/rpc/rpc-lib/src/rpc-clnt.c +++ b/rpc/rpc-lib/src/rpc-clnt.c @@ -1573,7 +1573,6 @@ rpc_clnt_destroy (struct rpc_clnt *rpc) rpc_transport_unref (rpc->conn.trans); } - rpc_clnt_connection_cleanup (&rpc->conn); rpc_clnt_reconnect_cleanup (&rpc->conn); saved_frames_destroy (rpc->conn.saved_frames); pthread_mutex_destroy (&rpc->lock); -- cgit