From 4b892368108b9c41449fb1185319cf3acf3c2ea8 Mon Sep 17 00:00:00 2001 From: Shehjar Tikoo Date: Tue, 31 Aug 2010 06:50:32 +0000 Subject: nfs: Free fop local only after inode checks Fixes a crash that occurs because the nfs-fops code accesses a fop local after it has been returned to the mem pool. Generally seen when nfs load is so high that the mem-pool runs out of memory and starts CALLOCing. Signed-off-by: Shehjar Tikoo Signed-off-by: Vijay Bellur BUG: 1449 (NFS crash in nfs_fop_fsync_cbk) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1449 --- xlators/nfs/server/src/nfs-fops.h | 1 - 1 file changed, 1 deletion(-) (limited to 'xlators/nfs/server/src/nfs-fops.h') diff --git a/xlators/nfs/server/src/nfs-fops.h b/xlators/nfs/server/src/nfs-fops.h index 24fa0b99b..be445a641 100644 --- a/xlators/nfs/server/src/nfs-fops.h +++ b/xlators/nfs/server/src/nfs-fops.h @@ -129,7 +129,6 @@ nfs_fop_local_wipe (xlator_t *xl, struct nfs_fop_local *l); nflocal = fram->local; \ fram->local = nflocal->proglocal; \ pcbk = nflocal->progcbk; \ - nfs_fop_local_wipe (nflocal->nfsx, nflocal); \ } while (0) \ #define nfs_fop_handle_local_init(fram,nfx, nfloc, cbck,prgloc,retval,lab) \ -- cgit