summaryrefslogtreecommitdiffstats
path: root/rpc/rpc-transport
Commit message (Collapse)AuthorAgeFilesLines
...
* setsockopt should be called with solaris specific arguments for solaris servershishir gowda2010-12-141-0/+5
| | | | | | | | | | | | | | | ----- Original Message ----- From: "Raghavendra Bhat" <raghavendrabhat@gluster.com> To: glusterfs@dev.gluster.com Sent: Tuesday, December 14, 2010 11:56:43 AM Subject: [PATCH BUG:2205 v4] setsockopt should be called with solaris specific arguments for solaris server Looks fine to me. Signed-off-by: Raghavendra Bhat <raghavendrabhat@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2205 ([glusterfs-3.1.2qa1]: error while setting the keepalive time interval) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2205
* rpc-transport/rdma: QP configuration changes.Raghavendra G2010-12-121-29/+46
| | | | | | | | | | | | - set send and recv count to 4K. - set max_send_sge of QP to 2 since for msgs of type RDMA_NOMSG, there can be two vectors - rpc header and message from program. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2197 (applications running on large number of clients simultaneously result in ibv_post_send errors on server.) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2197
* rpc-transport/rdma: add informative debug messages when posting of send ↵Raghavendra G2010-12-121-13/+33
| | | | | | | | | | requests fail. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2197 (applications running on large number of clients simultaneously result in ibv_post_send errors on server.) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2197
* rpc-transport: don't merge payload iobuf and iobuf which holds program ↵Raghavendra G2010-11-253-34/+29
| | | | | | | | | | | | | header into single iobref. - io-cache holds a reference on iobref passed from transport layer. Hence, two iobufs are accounted instead of one in calculated used cache size. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2135 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2135
* rpc-transport/rdma: set the default quota of recv buffers to 128.Raghavendra G2010-11-091-2/+2
| | | | | | | | | | - since quota is returned once the reply is recieved, 32 is too less value. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2060 (Infiniteband errors on large file find) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2060
* rpc-transport/rdma: create request_context only if message contains read ↵Raghavendra G2010-11-071-18/+28
| | | | | | | | | | chunks or write chunks. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1992 (glusterd crashed while submitting a callback.) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1992
* rpc-transport/rdma: Fix 2KB as threshold size for msgs that can be ↵Raghavendra G2010-11-072-13/+23
| | | | | | | | | | | | | transferred inline. - Any fop/mop that can result a reply whose size is greater than this threshold allocates and submits a buffer along with the request to receive reply. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 513 (Introduce 0 copy rdma) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
* rpc-transport/rdma: increment post->ctx.count in a loop doint rdma_read.Raghavendra G2010-11-071-5/+5
| | | | | | | | | | | - incrementing by the number of read chunks even before doing rdma read will cause issues since post->ctx.count is used while posting rdma read. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1877 (data corruption while running arequal.) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1877
* socket: avoid check on lowlat for enabling nodelayVijay Bellur2010-11-021-6/+1
| | | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 2040 (Using 'du' and 'ls' command, it got slow performance) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2040
* rpc-transport: fix race-condition between rdma-read completion and updating ↵Raghavendra G2010-10-291-1/+1
| | | | | | | | | | | | | | the count of number of vectors to be passed to rpc. - If rdma read completes before incrementing the vector count, the count value sent to rpc will be improper. For fops like write, this may result in missing out a vector to be written, thereby causing data corruption. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1877 (data corruption while running arequal.) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1877
* Revert "rpc-transport/rdma: create request_context only if message contains ↵Anand V. Avati2010-10-291-26/+18
| | | | | | read chunks or write chunks." This reverts commit b66f4598f4dafb6479232b20c5c521ab0da4e84a.
* socket: Reduce keepalive idle and interval timeVijay Bellur2010-10-271-1/+2
| | | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1956 (NFS client hangs after failover) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1956
* rpc-transport/rdma: create request_context only if message contains read ↵Raghavendra G2010-10-261-18/+26
| | | | | | | | | | chunks or write chunks. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1992 (glusterd crashed while submitting a callback.) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1992
* rpc-transport/rdma: associate mem-pools with device instead of transport.Raghavendra G2010-10-252-69/+102
| | | | | | | | | | - this will help to reduce memory usage of glusterfs process. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 513 (Introduce 0 copy rdma) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
* rpc-transport/socket: initialize fragcurrent pointer in correct state while ↵Raghavendra G2010-10-121-3/+3
| | | | | | | | | | | | | | | reading vectored replies. - If fragcurrent is initialized in the same state which reads payload data, there is a possibility of it getting reset during partial reads from socket. Hence it should be initialized just before entering the state which reads payload data. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1929 (different value is logged for read header size for multiple reads) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1929
* Change assert to GF_ASSERTVijay Bellur2010-10-122-3/+3
| | | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 971 (dynamic volume management) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
* rpc-transport/rdma: by default use infiniband port 1Raghavendra G2010-10-121-1/+1
| | | | | | | | Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 513 (Introduce 0 copy rdma) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
* Copyright changesVijay Bellur2010-10-114-4/+4
| | | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 971 (dynamic volume management) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
* rpc-transport/rdma: fix the bug which was causing an ioq-entry being mem_put ↵Raghavendra G2010-10-091-1/+3
| | | | | | | | | | | | | | | | | | | twice. - in case of failure to send message, ioq-entry would be freed, but it used to get added to the ioq-list. Failure in sending a message (for reasons other than insufficient quota), would result in transport being disconnected. In the process of handling pollerr, when ioq-list is flushed, the same ioq-entry which would've already been freed, would be freed for second time. - this patch also fixes spurious disconnects happening when quota was not available while sending a request. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1854 (GlusterFS 3.1 beta crashes over Infiniband with rdma issue) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1854
* migrate from port 69* to 24007Amar Tumballi2010-10-082-3/+4
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1870 (Change the port from 69* to some other ports.) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1870
* support for configuring keepalive idle timeVijay Bellur2010-10-082-5/+17
| | | | | | | | Signed-off-by: Vijay Bellur <vijay@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1802 (Gluster volume creation failed) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1802
* mgmt/Glusterd: Volume set enhancementsKaushik BV2010-10-071-0/+61
| | | | | | | | | | | - performance.flush-behind, transport.keepalive added - volume info to display the options reconfigured Signed-off-by: Kaushik BV <kaushikbv@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1159 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1159
* protocol/rpc/transport: bring in one more event for 'TRANSPORT-DESTROY'Amar Tumballi2010-10-071-1/+1
| | | | | | | | | | | | needed because, a RPC disconnect doesn't mean that a RPC transport/listener is dead. With this, the race in server protocol cleaning up the lock table / fd table when some frames are in transit will be handled properly. Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1843 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1843
* Change GNU GPL to GNU AGPLPranith K2010-10-044-12/+12
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1388 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1388
* rpc-transport/rdma: send disconnect event only if the transport is already ↵Raghavendra G2010-10-021-3/+7
| | | | | | | | | | | | | | connected. - A disconnect event can be sent before a connect event to rpc, if some error happens during rdma handshake. - Also call rdma_quota_put only if peer is not NULL. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 513 (Introduce 0 copy rdma) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
* remove 'gfs_id' field from all protocol xdr structuresAmar Tumballi2010-10-011-1/+1
| | | | | | | | | | | | | It was kept as a debugging requirement/placeholder. Because RPC is mostly bug free with regard to basic xdr structures, it doesn't make sense to carry this forward in release. Saves 8bytes in each request. Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
* rpc/rpc-transport: fix frame-loss during rdma-reads.Raghavendra G2010-09-242-3/+18
| | | | | | | | | | | | | | | | | | - total no of rdma reads in progress was tracked using refcount of post (refcount = total rdma reads + 1). However doing rdma_post_unref _after_ rdma_do_reads, can result in race condition between execution of rdma_post_unref and procedure handling rdma read completion. This makes it impossible to find out whether the current rdma read was the last rdma-read being done in procedure handling rdma read-completion. The fix to this should either do rdma_post_unref before posting an rdma read or use another variable to track the number of rdma-reads. This patch implements second method. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1700 (write fops are bailing out on a distribute setup) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1700
* rpc-transport/socket: set keepalive socket option.Raghavendra G2010-09-202-0/+91
| | | | | | | | Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
* rdma: do event_unregister() in fini() too.Amar Tumballi2010-09-171-12/+19
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1611 (crash in gf_free) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1611
* cli, mgmt/glusterd: disallow probe to a clusterPranith Kumar K2010-09-151-1/+1
| | | | | | | | Signed-off-by: Pranith Kumar K <pranithk@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1594 (make probe oneway) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1594
* socket.c: suppress spurious 'dict_get' logs in glusterd debug modeAmar Tumballi2010-09-151-2/+8
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1606 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1606
* rpc-transport.c: handle a double freeAmar Tumballi2010-09-151-3/+0
| | | | | | | | | | * 'this->name' was getting freed in '(transport)->fini()'. Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1605 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1605
* socket: add xfer data countsAmar Tumballi2010-09-141-0/+2
| | | | | | | | | | | | * keeping track of data transfered over wire helps to identify the protocol overhead, and also can help us in debugging more on server loads Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 971 (dynamic volume management) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=971
* rpc-transport/rdma: while notifying a reply, pickup the correct iobref from ↵Raghavendra G2010-09-081-3/+3
| | | | | | | | | | request context. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1567 ([rdma] data corruption due to read-ahead) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1567
* rpc-transport/rdma: change the default listening port to 6968.Raghavendra G2010-09-081-1/+1
| | | | | | | | Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 513 (Introduce 0 copy rdma) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
* rpc-transport/rdma: honour port argument sent in rdma_connect.Raghavendra G2010-09-073-21/+26
| | | | | | | | Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1555 (rdma remote port defaults to 6997) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1555
* rpc-transport/rdma: fix memory corruptions caused by rdma.Raghavendra G2010-09-071-2/+4
| | | | | | | | | | | | | - disconnect notification should be sent before unrefing transport, since transport might be freed when unrefed. - set trans->listener. This member is used by rpcsvc to decide whether a listener or a new connection is dead. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1558 (glusterd hung) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1558
* socket.c: more detailed info about mismatched msg typeAmar Tumballi2010-09-071-2/+8
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
* rpc-transport/socket: fix memory leaks.Raghavendra G2010-09-041-18/+28
| | | | | | | | | | | | | - In the course of reading a single rpc-msg, socket_proto_state_machine may be executed multiple times (since sockets are non-blocking), hence wherever memory is allocated or referenced, checks should be added whether the memory is already allocated or referenced. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1438 (memory leaks) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1438
* rpc-transport/rdma: notify rpc when pollerr happens, so that client side can ↵Raghavendra G2010-09-031-2/+2
| | | | | | | | | | try to reconnect. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 513 (Introduce 0 copy rdma) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
* rpc-transport/rdma: when rdma msg of type RDMA_ERROR is recieved, disconnect ↵Raghavendra G2010-09-021-6/+13
| | | | | | | | | | transport. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1462 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1462
* rpc-transport/rdma: set whether pollin data is for request/reply.Raghavendra G2010-09-011-0/+2
| | | | | | | | | | | - with implementation of call backs client and server can both recieve request/reply. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 1488 (rdma client fails to connect to the servers) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1488
* rpc-transport/socket: use xdr_sizeof instead of sizeof when trying to read ↵Raghavendra G2010-08-311-2/+21
| | | | | | | | | | vectored request/reply Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875
* rpc-transport/rdma: By default, enable building of rdma only if libibverbs ↵Raghavendra G2010-08-311-1/+1
| | | | | | | | | | is installed. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 513 (Introduce 0 copy rdma) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
* rpc-transport/rdma: free ioq entry even when churning of message fails.Raghavendra G2010-08-311-1/+1
| | | | | | | | | | | - An ioq entry is added to ioq-list only when it is not processed due to lack of quota. For all other cases, it should be freed to avoid memory leak. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 513 (Introduce 0 copy rdma) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
* Bring in new transport rdma.Raghavendra G2010-08-307-1/+5972
| | | | | | | | | | | | - rdma is new transport and improvement over current ib-verbs. It uses rdma-read and rdma-write for efficiently transferring large buffers. For more details please refer to rfc-5666 and rfc-5667. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com> BUG: 513 (Introduce 0 copy rdma) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=513
* rpc: server to client callback mechanismAmar Tumballi2010-08-271-0/+2
| | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
* transport/socket: free priv->incoming.request_info if not already freed ↵Raghavendra G2010-08-261-0/+9
| | | | | | | | | | after reading each message. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1438 (memory leaks) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1438
* rpc-transport/socket: proper cleanup and NULL deref checks.Amar Tumballi2010-08-181-76/+126
| | | | | | | | Signed-off-by: Amar Tumballi <amar@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 1326 () URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=1326
* rpc - cleanup and changes related to rdmaRaghavendra G2010-08-181-4/+5
| | | | | | | | | | | | - remove rpc_conn_state structure. - add a member to point struct rpc_req in rpc_transport_req structure. This is needed for rdma to store rdma specific per request data. Signed-off-by: Raghavendra G <raghavendra@gluster.com> Signed-off-by: Anand V. Avati <avati@dev.gluster.com> BUG: 875 (Implement a new protocol to provide proper backward/forward compatibility) URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=875