From d0b0e59952222c186120c91518ccf94862a86f64 Mon Sep 17 00:00:00 2001 From: Krutika Dhananjay Date: Tue, 27 Nov 2012 15:13:15 +0530 Subject: cli: cmd history echoes the last command string word twice with --mode=script PROBLEM: When a gluster command is executed with --mode=script option enabled, the last word in the command string is echoed twice in command history. Example: [2012-12-03 05:29:16.083176] : volume start dis dis : SUCCESS FIX: Terminate argv with NULL when the words are shifted after omitting "--mode=script" from it. Change-Id: I3a2623efe02e58c97c34554988938a9299425492 BUG: 823081 Signed-off-by: Krutika Dhananjay Reviewed-on: http://review.gluster.org/4255 Reviewed-by: Pranith Kumar Karampuri Tested-by: Gluster Build System Reviewed-by: Anand Avati --- cli/src/cli.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'cli') diff --git a/cli/src/cli.c b/cli/src/cli.c index 2b94df87..a2457c2b 100644 --- a/cli/src/cli.c +++ b/cli/src/cli.c @@ -382,6 +382,8 @@ parse_cmdline (int argc, char *argv[], struct cli_state *state) } } + state->argv[state->argc] = NULL; + return ret; } -- cgit