From 3b88b2dfbc1a33a6967cfedf63a615ee1e81e49d Mon Sep 17 00:00:00 2001
From: Sachidananda <sac@gluster.com>
Date: Tue, 18 May 2010 00:20:24 +0000
Subject: Log proper error message when hostname or ip does not conform to
 standards.

Signed-off-by: Sachidananda Urs <sac@gluster.com>
Signed-off-by: Anand V. Avati <avati@dev.gluster.com>

BUG: 923 (Hostnames with underscores fail)
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=923
---
 libglusterfs/src/xlator.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

(limited to 'libglusterfs')

diff --git a/libglusterfs/src/xlator.c b/libglusterfs/src/xlator.c
index 2168beb9..4a0de300 100644
--- a/libglusterfs/src/xlator.c
+++ b/libglusterfs/src/xlator.c
@@ -597,7 +597,12 @@ _volume_option_value_validate (xlator_t *xl,
         {
                 if (valid_internet_address (pair->value->data)) {
                         ret = 0;
-                }
+                } else {
+			gf_log (xl->name, GF_LOG_ERROR, "internet address '%s'"
+				" does not conform to standards.",
+				pair->value->data);
+			goto out;
+		}
 	}
         break;
 	case GF_OPTION_TYPE_ANY:
-- 
cgit