glusterfs-snapshot.git/rpc, branch development

glusterd/snapshot: Addressed upstream review comments

2014-04-07T07:51:03+00:00

Code cleanup and review comments fixed.

Change-Id: Ie51e3a2f995295632cb1db05bab8b38603ab9a0a
Signed-off-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/7399
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Avra Sengupta

snapshot/config : snapshot config changes.

2014-03-25T13:37:12+00:00

Syntax :
        gluster snapshot config [volname] [snap-max-hard-limit ]
                                          [snap-max-soft-limit ]

        1)If volume name is not specified, then the value is set system wide.
        2)If volume name is specified, then the value is set to that particular volume.

        *NOTE : snap-max-soft-limit cannot be specified to individual volumes.

case 1) When system limit is greater than volume limit.
Sample output :

        Snapshot System Configuration:
        snap-max-hard-limit : 200
        snap-max-soft-limit : 50%

        Snapshot Volume Configuration:

        Volume : vol2
        snap-max-hard-limit : 100
        Effective snap-max-hard-limit : 100
        Effective snap-max-soft-limit : 50 (50%)

        Volume : vol1
        snap-max-hard-limit : 150
        Effective snap-max-hard-limit : 150
        Effective snap-max-soft-limit : 75 (50%)

case 2) When system limit is lesser than volume limit.
Sample output :

        Snapshot System Configuration:
        snap-max-hard-limit : 50
        snap-max-soft-limit : 50%

        Snapshot Volume Configuration:

        Volume : vol2
        snap-max-hard-limit : 100
        Effective snap-max-hard-limit : 50
        Effective snap-max-soft-limit : 25 (50%)

        Volume : vol1
        snap-max-hard-limit : 150
        Effective snap-max-hard-limit : 50
        Effective snap-max-soft-limit : 25 (50%)

Change-Id: I97b5daefec7205bb9ab7b5b51d38f504cc5ee940
BUG: 1075034
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/7303
Reviewed-by: Rajesh Joseph 
Tested-by: Rajesh Joseph

mgmt/glusterd: do cleanup of snapshots in post-validate phase if half baked

2014-03-24T14:45:09+00:00

               objects are there

Change-Id: I372cac98ad054cdc1a6fbc7f6c77c25981063b2f
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/7237
Reviewed-by: Rajesh Joseph 
Tested-by: Rajesh Joseph

feature/snapshot : Snapshot status.

2014-03-13T09:54:13+00:00

Snapshot status command is used to display the status of
available snapshot.

The status command will display the Brick path, Volume Group,
Brick pid, Whether brick is online, Percentage of data filled,
Logical Volume size.

The syntax for using snapshot status is :

        gluster snapshot status [(snapname | volume )]

Change-Id: I621911c305e20ca83d958ff1f8762bef1f2f12f0
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/7134
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Rajesh Joseph 
Tested-by: Rajesh Joseph

glusterd/snapshot : Introduced a macro for snapshot info command.

2014-03-10T13:21:06+00:00

Also populated the error message in case of snapshot create, list, info and delete failure.

When snapshot list, info or delete is issued, if the entered snapname/volname does not exist then populate error string along with logging.

Change-Id: I632d25110bc63ff0e4ac98b27e2f410f7ccbb990
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/7203
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Rajesh Joseph 
Tested-by: Rajesh Joseph

glusterd/mgmt_v3 locks: Generalization of the volume wide locks.

2014-03-07T12:29:33+00:00

Renaming volume locks as mgmt_v3 locks

Change-Id: I2a324e2b8e1772d7b165fe96ce8ba5b902c2ed9a
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/7187
Reviewed-by: Rajesh Joseph 
Tested-by: Rajesh Joseph

CLI/snapshot : Snapshot info CLI changes

2014-03-05T09:54:43+00:00

snapshot info [(snapname | volume )].

Snapshot info will list all the basic information.

Syntax :
        ** gluster snapshot info  **

        This will list all the snap object along with that
        it also prints the snaps volume name, UUID and
        status.

        ** gluster snapshot info  **

        This will list only the mentioned snap object and
        also snap volume information along with that

        ** gluster snapshot info volume  **

        This will list all the snaps present in the
        mentioned volume.

Change-Id: I1e92774cb08eaebbfe141b9b47d1a887d76916a4
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/6996
Reviewed-by: Rajesh Joseph 
Tested-by: Rajesh Joseph

protocol/server: copy the response into the payload instead of using the pointer

2014-01-13T04:53:39+00:00

The response structure filled up in server_submit_reply is local to the
function (i.e stack allocated) whose address is stored in the barrier
payload to use later while sending the replies. But after the function
is exited (server_submit_reply) the pointer is not valid and contains
invalid data, which either leads in a segfault due to illegal memory
access or reply not being sent as the total length of the reply obtained
from that memory might not be valid.

So instead of saving the pointer inside the payload, save the complete
reply itself.

Change-Id: I7d0b7b181584865199357a67165b99bf35def5ab
Signed-off-by: Raghavendra Bhat

glusterd/snapshot: Introducing snap-max-hard-limit and snap-max-soft-limit

2014-01-06T10:29:43+00:00

Note: Manually adding this patch again as this patch got missed in
      git reset option done on remote development branch

Change-Id: I9e81c5ec003c1e1722d0fcb27dd87c365ee43ff4
Signed-off-by: Avra Sengupta 
Signed-off-by: Rajesh Joseph

snapshot: Merge conflict resolution

2013-11-15T09:23:44+00:00

Signed-off-by: shishir gowda