glusterfs-snapshot.git/xlators/mgmt/glusterd/src, branch development

glusterd/snapshot: Addressed upstream review comments

2014-04-07T07:51:03+00:00

Code cleanup and review comments fixed.

Change-Id: Ie51e3a2f995295632cb1db05bab8b38603ab9a0a
Signed-off-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/7399
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Avra Sengupta

glusterd/snapshot : Fix for snap creation beyond effective snap-max-hard-limit.

2014-04-04T11:26:01+00:00

Change-Id: I679a1b01bb9d8a41fe463acf4406d896caf939c8
BUG: 1083879
Signed-off-by: Sachin Pandit 
Reviewed-on: http://review.gluster.org/7396
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Rajesh Joseph 
Tested-by: Rajesh Joseph

glusterd/snapshot: code cleanup and fixes for review comments

2014-04-04T08:54:19+00:00

Change-Id: I358c30b42e71e5e1ddaeb5a3954bdd590671839b
Signed-off-by: Vijaikumar M 
Reviewed-on: http://review.gluster.org/7386
Reviewed-by: Avra Sengupta 
Reviewed-by: Rajesh Joseph 
Tested-by: Rajesh Joseph

glusterd/snapshot: Recording the snapshots missed in each brick.

2014-04-02T13:03:50+00:00

Persisting missing snapshot info on disk as well as in memory in
the following format:
-------------NODE-UUID--------------:---------SNAP-UUID--------------=BRICKNUM:-------BRICKPATH--------:OPERATION:STATUS
927cb5fe-63da-48f5-82f6-e6a09ddc81c4:a17b4fe42c5a45f7a916438643edaa13= 3 :/brick/brick-dirs/brick3: 1 : 1
927cb5fe-63da-48f5-82f6-e6a09ddc81c4:a17b4fe42c5a45f7a916438643edaa13= 3 :/brick/brick-dirs/brick3: 3 : 1
927cb5fe-63da-48f5-82f6-e6a09ddc81c4:83a3cc05453b46b2a7eda4c9a9208638= 3 :/brick/brick-dirs/brick3: 1 : 1

This data will be stored on disk at /var/lib/glusterd/snaps/missed_snaps_list

In memory we maintain the data as a list of glusterd_missed_snap_info
in conf, the key for this list are the first two fields,
i.e NODE-UUID:SNAP-UUID.

For every NODE-UUID:SNAP-UUID, there can be multiple operations missed
on multiple bricks. So we maintain a list of glusterd_snap_op_t
for evert node of glusterd_missed_snap_info

This list is maintained or updated during snapshot create, delete, and restore
operations which are the only operations that if missed, are recorded in this
list.

During snapshot create, if a node is down, or a brick is down, we don't
receive their mount point infos. snap_status of such bricks is marked as
-1, and their brick details are added to this list.

During snapshot delete, we check from originator node, if any other
nodes, holding bricks of the said snap are down. Those are also added to the list.
Also if the node is up, but the snapshot was pending for a snap
brick, and its snap_status is -1, we add that to the list too.
When a subsequent delete entry is processed for an already existing
create entry, we just mark the create entries status as done (2), and don't
add the delete entry to the list.

During snapshot restore, we check from originator node, if any other
nodes, holding bricks of the said snap are down. Those are also added to the list.
Also if the node is up, but the snapshot was pending for a snap
brick, and its snap_status is -1, we add that to the list too.

Change-Id: I22578d14f81a54e13f6832966b70cd4cfdfd5b44
Signed-off-by: Avra Sengupta
Reviewed-on: http://review.gluster.org/7208
Reviewed-by: Vijaikumar Mallikarjuna
Reviewed-by: Rajesh Joseph
Tested-by: Rajesh Joseph

glusterd/snapshot: Making snap operations crash consistent

2014-04-02T13:03:25+00:00

In the events of a volume's brick being down, or a node being
down, making snap ops like create, delete, restore, and
status crash consistent.

Marking snap status of snap bricks which were not snapshotted
because the volume brick was down as -1, and not starting those
snap bricks till the snapshot is taken.

During delete bypassing lvm snapshot remove for snap bricks
whose snap status is -1

During restore bypass replacing xattrs on the snapshot bricks
whose snap status is -1. Also bumping restored volume's version
so as to handle nodes being down. On handshake of a restored
volume, passing brick's snap_status as well.

During snapshot status of the non-snapshotted brick details
display "N/A". If a node is down, the entry itself will not
be displayed.

Change-Id: Id042efd7507829995270da0b2b2a6282a08a053d
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/7241
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Rajesh Joseph 
Tested-by: Rajesh Joseph

glusterd/snapshot: Storing dynamic strings in dict

2014-04-02T13:02:48+00:00

Taking a duplicate of a string and storing it as a
dynamic string in the dictionary, so that it is
independent of the source string.

Change-Id: Ib7d18ab8e7342fd71dad80d03259f76a5d2bd66d
BUG: 1077196
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/7381
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Rajesh Joseph 
Tested-by: Rajesh Joseph

glusterd/snapshot: Using original brickinfo for snap brick path

2014-04-02T13:01:00+00:00

Using /var/run/gluster/snaps//
/
as the snapshot brick path

Change-Id: Icdd838512e662ed687662188bd197ed1a889fbea
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/7231
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Rajesh Joseph 
Tested-by: Rajesh Joseph

glusterd/snapshot: fixed review comment for upstream restsore

2014-03-28T13:11:47+00:00

 code cleanup

Change-Id: I4965cc6fb9f8310cb1075047175f5e1139dd2aea
Signed-off-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/7366
Reviewed-by: Avra Sengupta

Crash Fixes introduced by review comments

2014-03-28T12:17:27+00:00

Change-Id: I22f9828e39494a8e1ad37c9a2ff78866d117e6af
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/7365
Reviewed-by: Sachin Pandit 
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Rajesh Joseph 
Tested-by: Rajesh Joseph

Review Comments

2014-03-27T16:25:56+00:00

Change-Id: Ifce90b0b617bc0b43a9af0bd692a7290820ac62c
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/7358
Reviewed-by: Rajesh Joseph 
Tested-by: Rajesh Joseph