glusterfs-snapshot.git/xlators, branch gluster-snap

changelog: Restrict length of unix socket files to UNIX_PATH_MAX.

2014-02-06T07:05:34+00:00

Bug fix for Coverity-CID 1124847.

Change-Id: I410ef8e06cbc491b1f72535298fae5e9bc77220d
BUG: 789278
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/6870
Reviewed-by: Venky Shankar 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Fix for 'use after free' errors reported by coverity.

2014-02-06T06:09:13+00:00

Change-Id: I941fc89b2d696c7f227330321ed4bba3ed1deac4
BUG: 789278
Signed-off-by: Poornima 
Reviewed-on: http://review.gluster.org/6868
Reviewed-by: Raghavendra G 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

mgmt/glusterd: Fix double free.

2014-02-06T05:46:07+00:00

Change-Id: I7a8b7772849715b019c86c6c768f33c1d9dcb27c
BUG: 789278
Signed-off-by: Poornima 
Reviewed-on: http://review.gluster.org/6881
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Problem : getfattr fails and mount point becomes inaccessible while

2014-02-06T05:44:26+00:00

fetching glusterfs.ancestry.path key value for a gfid from aux-gfid-mount 
based mount point.

Analysis : The caller of posix_make_ancestryfromgfid() function i.e. 
posix_get_ancestry_non_directory() is sending an incorrect type value as 
an argument leading to a crash in posix_make_ancestral_node() (head 
dirent pointer is NULL and an attempt to dereference causes seg fault). 
For a non directory operation this piece of code should not have been 
executed but due to incorrect type value this happened.

Solution : In posix_make_ancestryfromgfid() call type is passed as 
logical or of type and POSIX_ANCESTRY_PATH instead of logical or of 
POSIX_ANCESTRY_PATH and POSX_ANCESTRY_DENTRY.


Change-Id: Iaf844bea91396c5e2ee295d5a082998fda66f0a9
BUG: 1060104
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/6892
Reviewed-by: Raghavendra G 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

libxlator: fix memleak in cluster_markerxtime_cbk and cluster_markeruuid_cbk

2014-02-04T19:29:27+00:00

Change-Id: Ide3574bf9f661b077f707990d47821feda18b1a3
BUG: 841617
Reviewed-on: http://review.gluster.org/6850
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

cluster/dht: Set restrictive open flags for files under rebalance

2014-02-04T17:56:57+00:00

Files that are being rebalanced are created in the new volume
and access path needs to open these files to write changing
data in parallel to both the old and new locations. While opening
the file in the new location, we need to restrict the open flags
to not use truncate or create and fail if exist flags, to prevent
open failures or inadvertently truncate the file under rebalance.

Change-Id: I12130e0377adc393f1925c45585200ad991fd0d5
BUG: 1058569
Signed-off-by: ShyamsundarR 
Reviewed-on: http://review.gluster.org/6830
Reviewed-by: Raghavendra G 
Reviewed-by: Krutika Dhananjay 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Vijay Bellur

features/index: Loop exit without freeing in-use memory.

2014-02-04T17:52:39+00:00

If the while loop is exited via the goto, the call to closedir(3) is
skipped, leaving an open directory stream.  This patch ensure that the
directory is closed if the loop is exited via the goto.

BUG: 789278
CID: 1124763

Change-Id: Iec5da4b8d32c0a93c10d035ff38d0c063fd97cda
Signed-off-by: Christopher R. Hertel 
Reviewed-on: http://review.gluster.org/6828
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

glusterd: Reset opinfo.op ONLY if lock succeeded

2014-02-04T17:50:12+00:00

Change-Id: I0244a7f61a826b32f4c2dfe51e246f2593a38211
BUG: 1060434
Signed-off-by: Krutika Dhananjay 
Reviewed-on: http://review.gluster.org/6885
Reviewed-by: Kaushal M 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Gluster Build System

quota: Fixing a possibility of GF_FREE on an array pointer

2014-02-04T01:29:54+00:00

Issue: when the charecter pointer is not heap allocated by the program
we should not do GF_FREE on it.

Change-Id: Ibccc25491a9ab924fd5b82c14566f551a061ec2e
BUG: 789278
Signed-off-by: Lalatendu Mohanty 
Reviewed-on: http://review.gluster.org/6741
Reviewed-by: Raghavendra G 
Reviewed-by: Vijay Bellur 
Tested-by: Gluster Build System

cluster/dht: Fix layout sorting

2014-02-04T01:24:13+00:00

The layout was not being sorted in the ascending order leading
to the wrong detection of holes/overlaps.

From looking at the previous git commits it appears that the initial version itself had the err comparison code.
Deductions from the current dht_layout_sort():
1. The zero'ed out layouts should be in the from of list, if needed
2. The layout should be sorted in the ascending order of layout error value.
3. The layout should be sorted in the ascending order of the layout 'start'.
But In some cases, with the err comparison code its not sorted in the ascending order. Example: If the input is as below for dht_layout_sort(), the sorting doesn't happen in ascending order.
Input:
0-1 err:0    2-3 err:0   6-7 err:0    0-0 err:20   4-5 err:0
          
With the current sort, Output:
4-5 err:0    0-0 err:0    0-1 err:0    2-3 err:0    6-7 err:0
Expected: 0-0 err:20 0-1 err:0 2-3 err:0 4-5 err:0 6-7 err:0
Looking at dht_layout_anomalies() it appears that, it doesn't require the layout to be sorted based on error value.
The other solution was to replace line 468 with:
 if ((layout->list[i].err || layout->list[j].err) && (layout->list[i].start > layout->list[j].start))
Since dht_layout_anomalies() didn't expect the layout to be sorted based on the error, removed the err comparison.

Change-Id: I1215f6cd53efc7dba01c0958ba6cc7609dab6ff5
BUG: 1056406
Signed-off-by: Poornima G 
Reviewed-on: http://review.gluster.org/6757
Reviewed-by: Anand Avati 
Tested-by: Anand Avati