summaryrefslogtreecommitdiffstats
path: root/xlators/mgmt/glusterd/src/glusterd-mgmt.c
diff options
context:
space:
mode:
authorAvra Sengupta <asengupt@redhat.com>2013-11-19 04:48:37 +0000
committerAvra Sengupta <asengupt@redhat.com>2013-11-20 01:51:23 +0000
commitce5e67d497c036ffd0dd89a6ad2245a19ba47694 (patch)
treee55fc63bb7a135b437241db105826f83ca9dbe61 /xlators/mgmt/glusterd/src/glusterd-mgmt.c
parentde39983493ce747c6696f1523db59bb67865b22a (diff)
glusterd/snapshot: Added trace statements and handled snapshot create commit failure.
Also handles empty string(not NULL) in gd_syncop_mgmt_brick_op() and adds "Snapshot" in operation list used for printing op during logging. Change-Id: Icac9dce6bf1c087ab2aace9953e2af3a0fb81be6 Signed-off-by: Avra Sengupta <asengupt@redhat.com>
Diffstat (limited to 'xlators/mgmt/glusterd/src/glusterd-mgmt.c')
-rw-r--r--xlators/mgmt/glusterd/src/glusterd-mgmt.c24
1 files changed, 14 insertions, 10 deletions
diff --git a/xlators/mgmt/glusterd/src/glusterd-mgmt.c b/xlators/mgmt/glusterd/src/glusterd-mgmt.c
index 1faafc5d1..066b1de07 100644
--- a/xlators/mgmt/glusterd/src/glusterd-mgmt.c
+++ b/xlators/mgmt/glusterd/src/glusterd-mgmt.c
@@ -303,7 +303,7 @@ gd_mgmt_v3_vol_lock (glusterd_op_t op, dict_t *op_ctx,
(xdrproc_t) xdr_gd1_mgmt_v3_vol_lock_req);
synclock_lock (&conf->big_lock);
out:
- gf_log ("", GF_LOG_DEBUG, "Returning %d", ret);
+ gf_log ("", GF_LOG_TRACE, "Returning %d", ret);
return ret;
}
@@ -476,7 +476,7 @@ gd_mgmt_v3_pre_validate (glusterd_op_t op, dict_t *op_ctx,
(xdrproc_t) xdr_gd1_mgmt_v3_pre_val_req);
synclock_lock (&conf->big_lock);
out:
- gf_log ("", GF_LOG_DEBUG, "Returning %d", ret);
+ gf_log ("", GF_LOG_TRACE, "Returning %d", ret);
return ret;
}
@@ -516,7 +516,8 @@ glusterd_mgmt_v3_pre_validate (glusterd_conf_t *conf, glusterd_op_t op,
if (*op_errstr == NULL) {
ret = gf_asprintf (op_errstr,
"Pre-validation failed "
- "on localhost");
+ "on localhost. Please "
+ "check log file for details");
if (ret == -1)
*op_errstr = NULL;
@@ -676,7 +677,7 @@ gd_mgmt_v3_brick_op (glusterd_op_t op, dict_t *op_ctx,
(xdrproc_t) xdr_gd1_mgmt_v3_brick_op_req);
synclock_lock (&conf->big_lock);
out:
- gf_log ("", GF_LOG_DEBUG, "Returning %d", ret);
+ gf_log ("", GF_LOG_TRACE, "Returning %d", ret);
return ret;
}
@@ -716,7 +717,8 @@ glusterd_mgmt_v3_brick_op (glusterd_conf_t *conf, glusterd_op_t op,
if (*op_errstr == NULL) {
ret = gf_asprintf (op_errstr,
"Brick ops failed "
- "on localhost");
+ "on localhost. Please "
+ "check log file for details");
if (ret == -1)
*op_errstr = NULL;
@@ -869,7 +871,7 @@ gd_mgmt_v3_commit (glusterd_op_t op, dict_t *op_ctx,
(xdrproc_t) xdr_gd1_mgmt_v3_commit_req);
synclock_lock (&conf->big_lock);
out:
- gf_log ("", GF_LOG_DEBUG, "Returning %d", ret);
+ gf_log ("", GF_LOG_TRACE, "Returning %d", ret);
return ret;
}
@@ -910,7 +912,8 @@ glusterd_mgmt_v3_commit (glusterd_conf_t *conf, glusterd_op_t op,
if (*op_errstr == NULL) {
ret = gf_asprintf (op_errstr,
"Commit failed "
- "on localhost");
+ "on localhost. Please "
+ "check log file for details.");
if (ret == -1)
*op_errstr = NULL;
@@ -1046,7 +1049,7 @@ gd_mgmt_v3_post_validate (glusterd_op_t op, dict_t *op_ctx,
(xdrproc_t) xdr_gd1_mgmt_v3_post_val_req);
synclock_lock (&conf->big_lock);
out:
- gf_log ("", GF_LOG_DEBUG, "Returning %d", ret);
+ gf_log ("", GF_LOG_TRACE, "Returning %d", ret);
return ret;
}
@@ -1086,7 +1089,8 @@ glusterd_mgmt_v3_post_validate (glusterd_conf_t *conf, glusterd_op_t op,
if (*op_errstr == NULL) {
ret = gf_asprintf (op_errstr,
"Post-validation failed "
- "on localhost");
+ "on localhost. Please check "
+ "log file for details");
if (ret == -1)
*op_errstr = NULL;
@@ -1213,7 +1217,7 @@ gd_mgmt_v3_vol_unlock (glusterd_op_t op, dict_t *op_ctx,
(xdrproc_t) xdr_gd1_mgmt_v3_vol_unlock_req);
synclock_lock (&conf->big_lock);
out:
- gf_log ("", GF_LOG_DEBUG, "Returning %d", ret);
+ gf_log ("", GF_LOG_TRACE, "Returning %d", ret);
return ret;
}