diff options
| author | Vikas Gorur <vikas@gluster.com> | 2011-03-17 19:08:49 +0000 |
|---|---|---|
| committer | Vijay Bellur <vijay@dev.gluster.com> | 2011-03-25 04:11:34 -0700 |
| commit | f2a9ce7abacc8749589d0b931ca155d2c7578774 (patch) | |
| tree | 2695e5424cae30351595ec385fb35a6acfc8f475 /xlators | |
| parent | bd132d8e410dbc24cbef751925cd937939f35747 (diff) | |
nfs: Remove redundant and erroneous check for create mode EXCLUSIVE.
nfs3.c/nfs3_create_common:
The if condition checks for create mode being EXCLUSIVE. However, when
create mode is EXCLUSIVE, this function never gets called (nfs3_create_exclusive is
called). Also, instead of checking, it actually sets the value of createmode (= instead of ==).
Signed-off-by: Vikas Gorur <vikas@gluster.com>
Signed-off-by: Vijay Bellur <vijay@dev.gluster.com>
BUG: 2553 (NFS file create with Mac client and UNCHECKED mode returns "Operation not permitted")
URL: http://bugs.gluster.com/cgi-bin/bugzilla3/show_bug.cgi?id=2553
Diffstat (limited to 'xlators')
| -rw-r--r-- | xlators/nfs/server/src/nfs3.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/xlators/nfs/server/src/nfs3.c b/xlators/nfs/server/src/nfs3.c index e23d4ad75..f60a1e6c8 100644 --- a/xlators/nfs/server/src/nfs3.c +++ b/xlators/nfs/server/src/nfs3.c @@ -2361,7 +2361,7 @@ nfs3_create_common (nfs3_call_state_t *cs) if (!cs) return ret; - if ((cs->createmode == UNCHECKED) || (cs->createmode = EXCLUSIVE)) + if (cs->createmode == UNCHECKED) flags = O_RDWR; else if (cs->createmode == GUARDED) flags = (O_RDWR | O_EXCL); |