summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* snapshot restore: Fix error message while volume started.Joseph Fernandes2014-03-241-1/+3
| | | | | | | | | | | | | | Repharse of snap restore failure message when volume is started. Change-Id: Ie3e47856f60ff5d395fca1308cea9a5350a861f3 BUG: 1063775 Signed-off-by: Joseph Fernandes <josferna@redhat.com> Reviewed-on: http://review.gluster.org/7295 Reviewed-by: Sachin Pandit <spandit@redhat.com> Reviewed-by: Avra Sengupta <asengupt@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* cli/snapshot : Clear messages while creating SNAP with invalid scenarios.Sachin Pandit2014-03-241-3/+18
| | | | | | | | | | | | | | 1) Create with Description key and without actual description will display proper message. 2) Create with snapname containing special character will fail (volname convention is followed). 3) Create with Multiple Description will fail with proper message. Change-Id: I9173a0ffe2bf77c10a4e383268bd8d99906217a0 BUG: 1040978 Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/7324 Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/snapshot : Restore fix.Sachin Pandit2014-03-172-0/+10
| | | | | | | | | | | | Copy the snapshot present in origin volume to the restored volume. Change-Id: Icea9f712ae062b50b570d27b85cd231903446198 BUG: 1077142 Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/7282 Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* cli/snapshot : Fix for snapshot create fail.Sachin Pandit2014-03-142-2/+21
| | | | | | | | | Change-Id: Ib3c239eadbcfc787f4f7d0734839c8425e93020a BUG: 1076356 Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/7275 Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* snapshot : Fix for snapshot info ambiguous output.Sachin Pandit2014-03-132-30/+70
| | | | | | | | | Change-Id: I27e50921a2e030ae50b1fd28ee7ab0be65b313fd BUG: 1075454 Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/7228 Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* cli/snapshot : Fix for snapshot create with snapname l,r,i,d.Sachin Pandit2014-03-131-14/+28
| | | | | | | | | | Change-Id: Ib7fd1ca766997bce86062e5c10c5acf7e5edae60 BUG: 1075512 Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/7236 Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/snapshot: Validate snapshot name length while creationVijaikumar M2014-03-134-2/+18
| | | | | | | | Change-Id: Iaee04f5209e278d83c086e32c4cafd6c571370cd Signed-off-by: Vijaikumar M <vmallika@redhat.com> Reviewed-on: http://review.gluster.org/7242 Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/snapshot: Fix brick statusVijaikumar M2014-03-133-2/+46
| | | | | | | | | | Change-Id: I04ff2ddf5c644dde2051b8a692d287e87ba59942 Signed-off-by: Vijaikumar M <vmallika@redhat.com> Reviewed-on: http://review.gluster.org/7240 Reviewed-by: Sachin Pandit <spandit@redhat.com> Tested-by: Sachin Pandit <spandit@redhat.com> Reviewed-by: Avra Sengupta <asengupt@redhat.com> Tested-by: Avra Sengupta <asengupt@redhat.com>
* snapshot : Output correction in snapshot info and create.Sachin Pandit2014-03-132-2/+2
| | | | | | | | | | Change-Id: Ic468e2e64bdfc0f7d79453524a1b2ebc9b445906 BUG: 1075446 Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/7225 Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/snapshot: Validate path provided for snapshot mountVijaikumar M2014-03-131-0/+13
| | | | | | | | | | | Change-Id: Ia534b02051ada58586318b109f40c5ff77148527 BUG: 1075527 Signed-off-by: Vijaikumar M <vmallika@redhat.com> Reviewed-on: http://review.gluster.org/7239 Reviewed-by: Sachin Pandit <spandit@redhat.com> Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* feature/snapshot : Snapshot status.Sachin Pandit2014-03-136-14/+1302
| | | | | | | | | | | | | | | | | | | | Snapshot status command is used to display the status of available snapshot. The status command will display the Brick path, Volume Group, Brick pid, Whether brick is online, Percentage of data filled, Logical Volume size. The syntax for using snapshot status is : gluster snapshot status [(snapname | volume <volname>)] Change-Id: I621911c305e20ca83d958ff1f8762bef1f2f12f0 Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/7134 Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* snapshot/restore: Restore failed in multiple node testRajesh Joseph2014-03-131-15/+18
| | | | | | | | | | | | | | Failed to set extended attribute on bricks on some nodes. Extended attribute should only be set for local node. Change-Id: Ib5b47b15d2f6f93e146d3d75e9061fccc9570a80 Signed-off-by: Rajesh Joseph <rjoseph@redhat.com> Reviewed-on: http://review.gluster.org/7213 Reviewed-by: Sachin Pandit <spandit@redhat.com> Tested-by: Sachin Pandit <spandit@redhat.com> Reviewed-by: Avra Sengupta <asengupt@redhat.com> Tested-by: Avra Sengupta <asengupt@redhat.com>
* glusterd/snapshot : Show volume status in snap info.Sachin Pandit2014-03-102-0/+18
| | | | | | | | | Change-Id: Ifa090b158ca23402fb6afa4f3b65fad1446f350d Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/7212 Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/snapshot : Introduced a macro for snapshot info command.Sachin Pandit2014-03-104-47/+107
| | | | | | | | | | | | | Also populated the error message in case of snapshot create, list, info and delete failure. When snapshot list, info or delete is issued, if the entered snapname/volname does not exist then populate error string along with logging. Change-Id: I632d25110bc63ff0e4ac98b27e2f410f7ccbb990 Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/7203 Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* snapshot/restore : Snapshot restore changes.Sachin Pandit2014-03-104-400/+138
| | | | | | | | | | | | | | | | This Patch includes cli change and few backend changes. Syntax : gluster snapshot restore <snap-name> ** Also removed unwanted snapshot remove parsing code. Change-Id: Ie32590ccd4080da9409fd16c543866c14fae28f5 Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/7191 Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/snapshot: Modified restore backendRajesh Joseph2014-03-106-477/+282
| | | | | | | | | | | | | | Now instead of creating volume store files first we constructing the in-memory volinfo first and then generate the backend store files. This gives lot of flexibility in restore operation. This patch also fixes the read-only issue with restored snaps. Change-Id: I51032228a5212fc3b90dc6e93f3539af3eb36074 BUG: 1064688 Signed-off-by: Rajesh Joseph <rjoseph@redhat.com> Reviewed-on: http://review.gluster.org/7209 Reviewed-by: Sachin Pandit <spandit@redhat.com> Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com>
* glusterd/mgmt_v3 locks. Testcase for mgmt_v3 locks.Avra Sengupta2014-03-074-6/+129
| | | | | | | | | | Ported upstream volume-locks.t as mgmt-v3-locks.t Change-Id: Id4824716cde4ac54efbf1c1dd9a5f530b0324e39 Signed-off-by: Avra Sengupta <asengupt@redhat.com> Reviewed-on: http://review.gluster.org/7190 Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/mgmt_v3 locks: Using snaps as an entity for mgmt_v3 locks.Avra Sengupta2014-03-076-207/+429
| | | | | | | | | | | | Created framework to process single volume lock, single snap lock, multiple volume locks, multiple snap locks, and multiple snap and volume locks requests. Change-Id: I3f87bdec0bf142d6a1fd3f9d9f5012cc44eaf4bd Signed-off-by: Avra Sengupta <asengupt@redhat.com> Reviewed-on: http://review.gluster.org/7189 Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/mgmt_v3 locks: Handling different entities with mgmt_v3_locks.Avra Sengupta2014-03-077-43/+111
| | | | | | | | | | | | | | | | | Within the same namespace allowing mgmt_v3 lock engine to handle entities of valid types. Postfixing the element's name with the entity type allows us to perform locking operations on different elements of different entitites at the same time. For example: A volume named test, will acquire a lock on the name test_vol, while a snap named test will acquire lock on the name test_snap, and thus be allowed to co-exist in the same namespace. Change-Id: I611d1a59b707e497d35a37bdca5a66e29a1b6f06 Signed-off-by: Avra Sengupta <asengupt@redhat.com> Reviewed-on: http://review.gluster.org/7188 Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/mgmt_v3 locks: Generalization of the volume wide locks.Avra Sengupta2014-03-0716-325/+331
| | | | | | | | | | Renaming volume locks as mgmt_v3 locks Change-Id: I2a324e2b8e1772d7b165fe96ce8ba5b902c2ed9a Signed-off-by: Avra Sengupta <asengupt@redhat.com> Reviewed-on: http://review.gluster.org/7187 Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* gluster/snapshot: Create missing backend snapshot folderRajesh Joseph2014-03-073-47/+79
| | | | | | | | | | | | | | | | Snapshot volume bricks are mounted under /var/run/gluster/snaps folder. In the latest machines /var/run is a symbolic link to /run folder. In such cases if we use /var/run then there would be mismatch between mtab entry for the mount and the folder where we actually mount. Therefore this patch will get the correct folder and also create it if the folder is missing. Change-Id: I267aa7f3e171b486c5b3bb2a9f88cbd4be0e47ea BUG: 1072253 Signed-off-by: Rajesh Joseph <rjoseph@redhat.com> Reviewed-on: http://review.gluster.org/7140
* glusterd/snapshot: snapshot list and info changesVijaikumar M2014-03-061-776/+423
| | | | | | | | | | | | This changes includes snap-driven based list and info changes: Change-Id: Ie82a2a3c785baa36892ca0cd97a958a2ae819d4c Signed-off-by: Vijaikumar M <vmallika@redhat.com> Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/7139 Reviewed-by: Avra Sengupta <asengupt@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/snapshot: Snapshot create and delete changesVijaikumar M2014-03-0612-1177/+686
| | | | | | | | | | | | | | | | | | | With the snap driven approach, While creating the snapshot, We have to mention the snap-name first and then the volumes to be associated with that. Corresponding changes has been made in glusterd. While deleting the snapshot, we have to mention only the snapname. Corresponding changes has been made in glusterd. CLI changes for the same can be found here: http://review.gluster.org/#/c/6947/ Change-Id: I8bd8f471da5b728165da5f331faad3dde3486823 Signed-off-by: Vijaikumar M <vmallika@redhat.com> Reviewed-on: http://review.gluster.org/7123 Reviewed-by: Avra Sengupta <asengupt@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* cli/snapshot : snapshot delete CLI changes.Sachin Pandit2014-03-057-32/+70
| | | | | | | | | | | Syntax: gluster snapshot delete <snapname> Change-Id: I5de7b9a79eeba12e4f0b8abfbe96a2db738f25c0 Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/7144 Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* cli/snapshot : snapshot list CLISachin Pandit2014-03-053-4/+104
| | | | | | | | | | | | | syntax: gluster snapshot list [volname] This will list all the snapshots (or) snapshots of a particular volume. Change-Id: If879e06fe13caf2236f48df345857f833ae83c5b Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/7143 Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* CLI/snapshot : Snapshot info CLI changesSachin Pandit2014-03-054-545/+362
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | snapshot info [(snapname | volume <volname>)]. Snapshot info will list all the basic information. Syntax : ** gluster snapshot info ** This will list all the snap object along with that it also prints the snaps volume name, UUID and status. ** gluster snapshot info <snap-name> ** This will list only the mentioned snap object and also snap volume information along with that ** gluster snapshot info volume <volname> ** This will list all the snaps present in the mentioned volume. Change-Id: I1e92774cb08eaebbfe141b9b47d1a887d76916a4 Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/6996 Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* CLI/snapshot : Snapshot create CLI changes.Sachin Pandit2014-03-042-186/+133
| | | | | | | | | | | | | | | | | | | | | | Syntax: gluster snapshot create <snap-name> <vol-names> [description <description>] [force]. New change: With the snap driven approach, While creating the snapshot, We have to mention the snap-name first and then the volumes to be associated with that. Corresponding changes has been made in CLI,and all the hyphenated options are replaced by keywords. Previous Syntax : snapshot create <volnames> [-n <snap-name/cg-name>] [-d <description>] Change-Id: I9b4caf9629fdc3195b682190d999db2ecd9ce3e1 Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/6947 Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/snapshot: store location for snap driven changesVijaikumar M2014-03-0315-1816/+951
| | | | | | | | | | | | | | | | Currently snapshot volfiles are stored at: <workdir>/vols/<volname>/snaps/<snapvol> With snap driven approach we need to store the volfiles at: <workdir>/snaps/<snapname>/<snapvol> Change-Id: I8efdd5db29833b2b06b64a900cbb4c9b9a5d36b6 Signed-off-by: Vijaikumar M <vmallika@redhat.com> Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/7006 Reviewed-by: Avra Sengupta <asengupt@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/Volume Lock: Corrupted Txn Id FixAvra Sengupta2014-03-035-5/+53
| | | | | | | | | | Change-Id: Ic988ffeb26a49b4c6ac0d4a8ca33124f2192744c BUG: 1064768 Signed-off-by: Avra Sengupta <asengupt@redhat.com> Reviewed-on: http://review.gluster.org/6997 Reviewed-by: Krishnan Parthasarathi <kparthas@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* Snapshot: Admin guide for snapshot managementRajesh Joseph2014-02-181-0/+66
| | | | | | | | | Admin guide for snapshot management. Provide details of snapshot cli. Change-Id: I83cf082a8e2c1546d8fcac2e9b234e236024220a Signed-off-by: Rajesh Joseph <rjoseph@redhat.com> Reviewed-on: http://review.gluster.org/7027 Reviewed-by: Sachin Pandit <spandit@redhat.com>
* Snapshot: snap-max-limit implementedJoseph Fernandes2014-02-183-59/+206
| | | | | | | | | | | | | Added the check on snap-max-limit in snapshot_create_prevalidate. Now snapshot creation will fail if snap count reaches max limit. Change-Id: I5b1cf8441f02c32085d2f6f5fd8902cb61031af5 BUG: 1049834 Author: Joseph Fernandes <josferna@redhat.com> Signed-off-by: Joseph Fernandes <josferna@redhat.com> Signed-off-by: Rajesh Joseph <rjoseph@redhat.com> Reviewed-on: http://review.gluster.org/6981 Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com>
* mgmt/glusterd: handle compilation errorRaghavendra Bhat2014-02-141-0/+3
| | | | | | | | | Change-Id: I886a003c1bd9959105eab64a098b66a7303d4bba Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com> Reviewed-on: http://review.gluster.org/7001 Reviewed-by: Sachin Pandit <spandit@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* CLI/snapshot : Support to delete a snap forcefully using "force" optionSachin Pandit2014-02-132-9/+12
| | | | | | | | | | Change-Id: I6315d5b96ac72f6520037d4e96e29e5862aec346 Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/6867 Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com> Reviewed-by: Avra Sengupta <asengupt@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* mgmt/glusterd: check the status of the snap volume while stopping snap bricksRaghavendra Bhat2014-02-131-1/+1
| | | | | | | | Change-Id: I60b635f275498b285aa34702ce6ca41bfb7e01a0 Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com> Reviewed-on: http://review.gluster.org/6995 Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/snapshot: Use snap uuid to create lvm snapshotVijaikumar M2014-02-138-101/+253
| | | | | | | | | | | | Using snap uuid to create lvm snapshot will solve the problem of having '-' in the snap name or snap name is too long. Change-Id: If204f02a8f5de599fb409d06c7893ef3542a6300 BUG: 1045333 Signed-off-by: Vijaikumar M <vmallika@redhat.com> Reviewed-on: http://review.gluster.org/6709 Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/snapshot: Running lvcreate --help to check if setactivationskip is ↵Avra Sengupta2014-02-051-17/+50
| | | | | | | | | | | | | | supported To check if setactivationskip is supported or not, we run lvcreate --help and look for the setactivationskip flag, and accordingly issue lvcreate with or without the said flag. Change-Id: Ief349674ea3f7ceff6b7051b1a5104257e547ce2 Signed-off-by: Avra Sengupta <asengupt@redhat.com> Reviewed-on: http://review.gluster.org/6776 Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/snapshot : Making the snap mount read-only.Sachin Pandit2014-02-052-1/+39
| | | | | | | | | | | | Basically loading the read-only translator on the server side, during the snapshot create. Change-Id: I88dcce85b5f3f00e438f08165a8177b064f004fe BUG: 1040934 Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/6694 Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* snapshot: Framework for testing snapshotVijaikumar M2014-02-045-1/+309
| | | | | | | | | | | | This framework can be used to write functional testcase for snapshot operations Change-Id: I850d0e5021ac6c053d89c58567648e1bff273b19 Signed-off-by: Vijaikumar M <vmallika@redhat.com> Reviewed-on: http://review.gluster.org/6798 Reviewed-by: Avra Sengupta <asengupt@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd: Handling eof during gf_store_read_and_tokenizeAvra Sengupta2014-02-041-4/+4
| | | | | | | | | | | Change-Id: I88eeffd64c521db78b9e7539ae57ed046854cb63 BUG: 1049278 Signed-off-by: Avra Sengupta <asengupt@redhat.com> Reviewed-on: http://review.gluster.org/6903 Reviewed-by: Raghavendra Bhat <raghavendra@redhat.com> Reviewed-by: Sachin Pandit <spandit@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/snapshot : snapshot delete - check if process is killed before ↵Sachin Pandit2014-02-042-3/+23
| | | | | | | | | | | | | unmounting. Change-Id: Idf0cf63429212142795e1aeb4fd4962b51620426 BUG: 1049353 Signed-off-by: Sachin Pandit <spandit@redhat.com> Reviewed-on: http://review.gluster.org/6772 Reviewed-by: Vijaikumar Mallikarjuna <vmallika@redhat.com> Reviewed-by: Avra Sengupta <asengupt@redhat.com> Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* mgmt/glusterd: perform store on only newly created snapshotRaghavendra Bhat2014-02-023-13/+103
| | | | | | | | | | | | | | | * Instead performing store on all the snaps of the volume when a new snap is created, store only the new snap's info. Otherwise with more and more snapshots in the volume, time creation for new snapshot becomes very large as glusterd has to store all the snapshots related info everytime (that too by doing fsyncs) Change-Id: I0e005d1d4c044b07a8abde8e6ba55e66a1bbd590 BUG: 1059146 Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com> Reviewed-on: http://review.gluster.org/6841 Reviewed-by: Rajesh Joseph <rjoseph@redhat.com> Tested-by: Rajesh Joseph <rjoseph@redhat.com>
* glusterd/vol-locks: Dict_ref while adding req_ctx->dict to txn_opinfosAvra Sengupta2014-01-217-83/+71
| | | | | | | | | | | Introducing a wrapper function glusterd_txn_opinfo_init(), to initialize the opinfo to be set in the txn_id engine. Removed glusterd_op_fini_ctx() as the txn opinfo should only be cleared by glusterd_clear_txn_opinfo(). Change-Id: I17e85a162d6a3bca79941f8603d0c2b579f0d194 Signed-off-by: Avra Sengupta <asengupt@redhat.com>
* Merge "glusterd/vol-locks: Releasing vol-locks on receiving peer disconnect" ↵Rajesh Joseph2014-01-211-0/+14
|\ | | | | | | into development
| * glusterd/vol-locks: Releasing vol-locks on receiving peer disconnectAvra Sengupta2014-01-211-0/+14
| | | | | | | | | | | | | | | | On receiving peer disconnect, release volume locks held by the disconnected peer Change-Id: I0e36ba2fba4761225092ce2fb7b9b3c2d2dca0ad Signed-off-by: Avra Sengupta <asengupt@redhat.com>
* | glusterd/snapshot: Move out code from prevalidate functionVijaikumar M2014-01-211-156/+225
|/ | | | | | | | Move the code part that need to executed at the origin glusterd to a seperate function. Change-Id: Ieb53fbd4fb12e3e4d5087db306be37616657ee04 Signed-off-by: Vijaikumar M <vmallika@redhat.com>
* Merge "protocol/server: get the client object from frame->root even in ↵Rajesh Joseph2014-01-202-3/+1
|\ | | | | | | barrier" into development
| * protocol/server: get the client object from frame->root even in barrierRaghavendra Bhat2014-01-152-3/+1
| | | | | | | | | | | | | | * Remove the reference to client object from server_state_t structure Change-Id: Ic2dbf9dd487f1177bd889fe481e63bc063fd6183 Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>
* | glusterd/snapshot : Making snap time persistent.Sachin Pandit2014-01-161-11/+61
|/ | | | | Change-Id: I2d07717ee01751e481571ce420b0f84711ea9597 Signed-off-by: Sachin Pandit <spandit@redhat.com>
* Merge "protocol/server: copy the response into the payload instead of using ↵Rajesh Joseph2014-01-153-3/+7
|\ | | | | | | the pointer" into development
| * protocol/server: copy the response into the payload instead of using the pointerRaghavendra Bhat2014-01-133-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The response structure filled up in server_submit_reply is local to the function (i.e stack allocated) whose address is stored in the barrier payload to use later while sending the replies. But after the function is exited (server_submit_reply) the pointer is not valid and contains invalid data, which either leads in a segfault due to illegal memory access or reply not being sent as the total length of the reply obtained from that memory might not be valid. So instead of saving the pointer inside the payload, save the complete reply itself. Change-Id: I7d0b7b181584865199357a67165b99bf35def5ab Signed-off-by: Raghavendra Bhat <raghavendra@redhat.com>