glusterfs.git, branch v3.3.2qa1

dict: Put "goto out" in dict_unserialize to avoid process crash

2013-04-12T07:21:09+00:00

Problem:
In the dictionary serialization function, if the
[(buf + vallen) > (orig_buf + size)], then memdup is getting failed.

Fix:
Put "goto out" whenever this condition is met.

Change-Id: Ia10ddc7e1cf551eed0e2c3d0f0364c6961e13025
BUG: 947824
Signed-off-by: Venkatesh Somyajulu 
Reviewed-on: http://review.gluster.org/4770
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

cluster/afr: Try for all locks before failing in rename

2013-04-10T08:26:09+00:00

Change-Id: If0e917e5d4914f6807b4a96f81668a467b15d0df
BUG: 922809
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/4689
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cluster/afr: Preserve mtime in self-heal

2013-04-10T07:41:19+00:00

Problem:
Data self-heal may choose sink iatt to set mtimes.
This happens because after syncing of data is done
self-heal does one more xattrops/fstat to determine
sources sinks to set the inode-ctx. Since this is done
after data syncing and erase of xattrs, old source and
old sink are now sources, but the mtimes of them differ.
Old code just takes the first source from the list and
update mtimes, which could be sink before the self-heal
started.

Fix:
Set mtime from 'sources before syncing'.

Change-Id: Id769e1b99aa4f041eaee775f64cbf2c57b799723
BUG: 918437
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/4658
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System 
Reviewed-on: http://review.gluster.org/4664
Reviewed-by: Vijay Bellur

Fix spelling error

2013-03-13T03:06:42+00:00

"temporary" was misspelled
s/tempaory/temporary/

BUG: 818884

Change-Id: If033acd4d8d778bde7588d8b4b512d6508e36f22
Signed-off-by: Joe Julian 
Reviewed-on: http://review.gluster.org/4661
Reviewed-by: Jeff Darcy 
Tested-by: Anand Avati

rpm: package /var/run/gluster so that statedumps can be created

2013-03-07T06:14:06+00:00

Creating statedumps fail when /var/run/gluster does not exist. This
directory should be part of the 'glusterfs' package that is installed on
storage servers and native clients.

BUG: 917554
Change-Id: I2f6d8dc46f338b33042478d19ed9f00c2c03658c
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/4615
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Shishir Gowda 
Reviewed-by: Anand Avati

libglusterfs: Fix memory leaks in fd_lk_insert_and_merge

2013-02-18T04:49:42+00:00

Change-Id: Id322717b79c5252172811fea259f2073f710a463
BUG: 834465
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/4530
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

localtime and ctime are not MT-SAFE

2013-02-08T20:04:42+00:00

There are a number of nit-level issues throughout the source with
the use of localtime and ctime. While they apparently aren't causing
too many problems, apart from the one in bz 828058, they ought to be
fixed. Among the "real" problems that are fixed in this patch:
1) general localtime and ctime not MT-SAFE. There's a non-zero chance
   that another thread calling localtime (or ctime) will over-write
   the static data about to be used in another thread
2) localtime(& <64-bit-type>) or ctime(& <64-bit-type>) generally
   not a problem on 64-bit or little-endian 32-bit. But even though
   we probably have zero users on big-ending 32-bit platforms, it's
   still incorrect.
3) multiple nested calls passed as params. Last one wins, i.e. over-
   writes result of prior calls.
4) Inconsistent error handling. Most of these calls are for logging,
   tracing, or dumping. I submit that if an error somehow occurs in
   the call to localtime or ctime, the log/trace/dump still should
   still occur.
5) Appliances should all have their clocks set to UTC, and all log
   entries, traces, and dumps should use GMT.
6) fix strtok(), change to strtok_r()

Other things this patch fixes/changes (that aren't bugs per se):
1) Change "%Y-%m-%d %H:%M:%S" and similar to their equivalent shorthand,
   e.g. "%F %T"
2) change sizeof(timestr) to sizeof timestr. sizeof is an operator,
   not a function. You don't use i +(32), why use sizeof().
   (And yes, you do use parens with sizeof().)
3) change 'char timestr[256]' to 'char timestr[32]' where appropriate.
   Per-thread stack is limited. Time strings are never longer than ~20
   characters, so why waste 220+ bytes on the stack?

Things this patch doesn't fix:
1) hodgepodge of %Y-%m-%d %H:%M:%S versus %Y/%m/%d-%H%M%S and other
   variations. It's not clear to me whether this ever matters, not to
   mention 3rd party log filtering tools may already rely on a
   particular format. Still it would be nice to have a single manifest
   constant and have every call to localtime/strftime consistently use
   the same format.

BUG: 832173

Change-Id: Iee9719db4576eacc6c75694d9107954d0912cba8
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/3613
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

performance/quick-read: fix race condition in unlink

2013-02-07T22:41:32+00:00

use same lock (inode->lock), while incrementing/decrementing local->open_count.

Change-Id: I08cbab5b5dec09b6057f43324fe3152f1564ce46
BUG: 902174
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/4396
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

dual license

2013-02-07T21:39:01+00:00

rebase

BUG: 820551
Change-Id: Iec1073ee3ed2d9cab25c0882544a18e8ba23c9aa
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/3857
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

doc: Add the "enable-ino32" native-client mount-option

2013-02-07T21:38:34+00:00

Change-Id: I9568a39c3e3497f94c098cdac0331d0a25122e35
BUG: 850352
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/3887
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati