glusterfs.git, branch v3.5.1beta2

features/gfid-access: Fix memory leaks.

2014-06-10T09:37:49+00:00

Change-Id: I90f6cdb1c8c4face1bb72a9cc77818d308389e45
BUG: 1104919
Signed-off-by: Raghavendra G 
Reviewed-on: http://review.gluster.org/7983
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

gNFS: Make NFS DRC off by default

2014-06-10T09:37:13+00:00

DRC in NFS causes memory bloat and there are known memory corruptions.
It would be good to disable drc by default till the feature is stable.

Cherry picked from 4215d071cec4fc8a62ca4fd6212d83f931838829:
> Change-Id: I93db6ef5298672c56fb117370bb582a5e5550b17
> BUG: 1105524
> Original-patch-by: Santosh Kumar Pradhan 
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/8004
> Tested-by: Gluster Build System 
> Reviewed-by: Krishnan Parthasarathi 
> Reviewed-by: Santosh Pradhan 
> Reviewed-by: Vijay Bellur 

Change-Id: I93db6ef5298672c56fb117370bb582a5e5550b17
BUG: 1105524
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/8013
Reviewed-by: Santosh Pradhan 
Tested-by: Gluster Build System

glusterd: Better op-version values and ranges

2014-06-10T07:47:12+00:00

Till now, the op-version was an incrementing integer that was
incremented by 1 for every Y release (when using the X.Y.Z release
numbering). This is not flexible enough to handle backports of features
into Z releases.

Going forward, from the upcoming 3.6.0 and 3.5.1 releases, the
op-versions will be multi-digit integer values composed of the version
numbers, instead of a simple incrementing integer. An X.Y.Z release will
have XYZ as its op-version. Y and Z will always be 2 digits wide and
will be padded with 0 if required. This way of bumping op-versions
allows for gaps in between the subsequent Y releases. These gaps will
allow backporting features from new Y releases into old Z releases.

Change-Id: Ib6a09989f03521146e299ec0588fe36273191e47
Depends-on: http://review.gluster.org/7963
BUG: 1096425
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/8010
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee

features/gfid-access: calloc gfid and set in xdata

2014-06-08T14:58:10+00:00

Backport of http://review.gluster.org/#/c/7978/

Problem: the gfid passed to ga_fill_tmp_loc() was a stack variable which
the function set in the xdata dictionary. Accessing it in a later point
in time gave unexpected values.

This was easy to hit when AFR was involved like so:
ga_mknod()--->xxx-->afr_mknod():
In afr_mknod transaction, once the stack-winds for the lock-phase are sent,
the gfid in xdata becomes out of scope. When we send the actual op i.e.
afr_mknod_wind(), the gfid in xdata is stale, causing posix to set junk
gfids on the files.

Fix:
calloc the gfid and set it in the dict.

Thanks to Pranith for the RCA!

Change-Id: Ief2080836dc2923dec4be44dda4f6211430e535e
BUG: 1104959
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/7985
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

glusterd: On gaining quorum spawn_daemons in new thread

2014-06-08T14:50:18+00:00

  Backport of http://review.gluster.org/7703 from master

During startup, if a glusterd has peers, it waits till quorum is
obtained to spawn bricks and other services. If peers are not present,
the daemons are started during glusterd' startup itself.

The spawning of daemons as a quorum action was done without using a
seperate thread, unlike the spawn on startup. Since, quotad was launched
using the blocking runner_run api, this leads to the thread being
blocked. The calling thread is almost always the epoll thread and this
leads to a deadlock. The runner_run call blocks the epoll thread waiting
for quotad to start, as a result glusterd cannot serve any requests. But
the startup of quotad is blocked as it cannot fetch the volfile from
glusterd.

The fix for this is to launch the spawn daemons task in a seperate
thread. This will free up the epoll thread and prevents the above
deadlock from happening.

BUG: 1105188
Change-Id: Idad1e96fbe1411dfd4b1a542fb5fa115673636c0
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/7995
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

NetBSD build fixes for release-3.5

2014-06-08T09:18:13+00:00

1) Make sure __THROW is definedThis is a backport of I6e7cb1eb59b84988e155e9a8b696e842b7ff8f7f

2) include  before  so that XDR is defined
This was fixed in master within I20193d3f8904388e47344e523b3787dbeab044acbut weonly pull up

3) NetBSD's gettext is in libintl, hence search it at configure time
This is a backport of I651a74fe49c3f087fe135dab3453fd5b18b4268a

4) include  to have WEXITSTATUS defined
This problem does not exist in master as WEXITSTATUS is not used

5) Do not define popcountl() on NetBSD as it is in 
This is a backport of I4428a88b1e0d7c5f6740022861ffe230dbbd84bd

BUG: 764655
Change-Id: Ieea5a2a627e2b7930525d6c525f1602073574a97
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/7925
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System

logging: use duplicate stderr, instead of re-opening

2014-06-08T07:28:29+00:00

The special filename "-" is supposed to log to stderr. Instead of
trying to explictly open "/dev/stderr" again (which may not be possible
as permissions might have changed by then), dup the stderr and use
the copy.

It is not a good idea to use @stderr global variable directly, as
ctx->log.logfile is fclose()d in glfs_fini() (was fixed in
http://review.gluster.org/6452)

Cherry picked from commit 15ea78fffd63756fecf2f15887d3cad6a13d2a34:
> BUG: 1088589
> Signed-off-by: Anand Avati 
> Reviewed-on: http://review.gluster.org/7607
> Tested-by: Gluster Build System 
> Reviewed-by: Vijay Bellur 

Change-Id: Ia6c538fe363905588dcf4fc4783804073956a586
BUG: 1103413
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/7938
Tested-by: Gluster Build System 
Reviewed-by: Harshavardhana

heal: Don't depend on errno for reporting heal info status

2014-06-07T15:01:17+00:00

Change the interfaces to return errno in 'return value'
to prevent errno being over-written in glfsh_print_brick_from_xl.

Change-Id: I425c85e496a885ed3cd0aeef86d4616aa21bb1b5
BUG: 1104592
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/7965
Reviewed-by: Ravishankar N 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

doc: Document libgfapi and its apis,usage,bindings..etc

2014-06-05T11:38:49+00:00

Change-Id: I3435f9a88acafa905e879c68bb7aa8b16023cf02
BUG: 1086766
> Signed-off-by: Humble Chirammal 
> Signed-off-by: Soumya k 
> Reviewed-on: http://review.gluster.org/7865
> Reviewed-by: Lalatendu Mohanty 
> Reviewed-by: Niels de Vos 
> Tested-by: Niels de Vos 
Signed-off-by: Humble Chirammal 
Reviewed-on: http://review.gluster.org/7991
Reviewed-by: Niels de Vos 
Tested-by: Niels de Vos

doc: Add 'expose volume capabilities' details of bd-xlator

2014-06-03T07:06:57+00:00

Change-Id: If7a89a36c2eca653e4fa7f59597ac8b03e4bc747
BUG: 1086749
> Signed-off-by: Humble Chirammal 
> Signed-off-by: Bharata B Rao 
> Reviewed-on: http://review.gluster.org/7844
> Reviewed-by: Vijay Bellur 
>Tested-by: Vijay Bellur 
Signed-off-by: Humble Chirammal 
Reviewed-on: http://review.gluster.org/7960
Reviewed-by: Niels de Vos 
Tested-by: Niels de Vos