glusterfs.git, branch v3.5.8

doc: release notes for GlusterFS 3.5.8

2016-02-15T19:56:22+00:00

BUG: 1290976
Change-Id: I5153a6fe6390247013609a249922bb8464bc7886
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/13437
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

quota : fix could not start auxiliary mount issue

2016-02-12T08:28:39+00:00

In versions older than 3.7, when trying to enable
quota, the following message appears :"quota: Could
not start quota auxiliary mount". It was because,
/var/run/gluster was not getting created in cli side.
In 3.7, the code has been moved to glusterd and we are 
making use of sys_mkdir.

3.6 fix -> http://review.gluster.org/#/c/13308/


Change-Id: Id4360409f76b57c0f676fe2b859f3647c4340575
BUG: 1117888
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/13215
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Vijaikumar Mallikarjuna

quota : avoid "contribution node is empty" error logs

2016-02-12T08:28:36+00:00

In versions older than 3.7, "contribution node list is empty which is
an error" gets logged numerous number of times. It is completely fixed
in 3.7. Since the entire marker and quota code has almost been
refactored, it is hard to backport the complete fix and also it could
not be fixed with the older approach. As a temporary fix, to avoid
numerous logs, the patch just supresses the log level.

3.6 Patch -> http://review.gluster.org/#/c/13304/

Change-Id: Ie666ba99c7bb16b9ce249b581e09857734589f51
BUG: 1288195
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/12990
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Vijaikumar Mallikarjuna

build: update link for .git/hooks/commit-msg

2016-01-15T12:35:41+00:00

Add -L option to curl cmd to follow a redirect

Signed-off-by: Kaleb S KEITHLEY

doc: release notes for GlusterFS 3.5.7

2015-12-12T16:05:27+00:00

BUG: 1263307
Change-Id: I5570ddf98ddb130a72cb25443d0c13dccf6f1766
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12957
Tested-by: Gluster Build System

glusterd.service: Ensure rpcbind is started before glusterd

2015-12-12T10:01:53+00:00

Having the rpcbind.service under the `After` option only ensures that
glusterd.service is started after rpcbind.service if both are
enabled/started at the same time. It doesn't ensure that starting
glusterd.service will start rpcbind.service.

The systemd.unit(5) man page suggests to use both the `Requires` and
`After` options to ensure that rpcbind is started before glusterd,
whenever glusterd is started.

Cherry picked from commit 23440a73bc348bbc3bb43ec397f0639ee45865fc:
> BUG: 1282915
> Change-Id: Iee69965486be08711299aba235f7b00c3e2fe7e9
> Signed-off-by: Kaushal M 
> Reviewed-on: http://review.gluster.org/12605
> Reviewed-by: Atin Mukherjee 
> Reviewed-by: Anand Nekkunti 
> Tested-by: Gluster Build System 
> Tested-by: NetBSD Build System 

Change-Id: Iee69965486be08711299aba235f7b00c3e2fe7e9
BUG: 1283542
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12659
Reviewed-by: Atin Mukherjee 
Tested-by: Gluster Build System

protocol/client: prevent use-after-free of frame->root

2015-12-12T10:01:34+00:00

A regression failure generated a coredump on the glusterfs-client side:

  (gdb) f 0
  #0  0x00007fba6cd76432 in client_submit_request (this=0x7fba68006fc0,
                  req=0x7fba6579aa70, frame=0x7fba5c0058cc,
                  prog=0x7fba6cfb53c0 , procnum=41,
                  cbkfn=0x7fba6cd9206d ,
                  iobref=0x0, rsphdr=0x0, rsphdr_count=0,
                  rsp_payload=0x0, rsp_payload_count=0, rsp_iobref=0x0,
                  xdrproc=0x7fba79801075 ) at
  /home/jenkins/root/workspace/rackspace-regression-2GB-triggered/xlators/protocol/client/src/client.c:324
  324                   frame->root->ngrps = ngroups;
  (gdb) l
  319                   gf_msg_debug (this->name, 0, "rpc_clnt_submit failed");
  320           }
  321
  322           if (!conf->send_gids) {
  323                   /* restore previous values */
  324                   frame->root->ngrps = ngroups;
  325                   if (ngroups <= SMALL_GROUP_COUNT)
  326                           frame->root->groups_small[0] = gid;
  327           }
  328
  (gdb) p *frame->root
  Cannot access memory at address 0x64185df000000000

After looking at this in more detail, the flow is like this:

  client_submit_request()
    |
    '- rpc_clnt_submit() // on line 314
         |
         '- cbkfn() // = client3_3_release_cbk
              |
              :- STACK_DESTROY (frame->root);
         .----'
    .----'
    |
    :- frame->root->ngrps = ngroups; // on line 324
    '

So, there is a use-after-free, and it is not needed to restore the
previous groups in frame->root.

Cherry picked from commit dc3aa7524e4974f9d02465e2e5dd6ed9b6d319e1:
> Change-Id: I9e7d712183692ed92cfc2f75cd3c2781a9db20e2
> BUG: 1281285 (was incorrect in original patch)
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/12575
> Reviewed-by: Dan Lambright 
> Tested-by: NetBSD Build System 
> Reviewed-by: Jeff Darcy 

Change-Id: I9e7d712183692ed92cfc2f75cd3c2781a9db20e2
BUG: 1283691
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12666
Tested-by: Gluster Build System

doc: release notes for GlusterFS 3.5.6

2015-09-15T14:11:19+00:00

BUG: 1240783
Change-Id: I259f4d24ab5e7826ea304be9759f54b461853621
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12183

build: drop incorrect usage of 'inline'

2015-07-23T14:33:03+00:00

Newer versions of gcc complain loudly about the incorrect usage of
'inline'.

These changes have been part of commit a3cb38e3 in other branches. There
is no need to backport everything from that commit, but silencing the
warnings would be good.

Change-Id: I2319d9682b47e8533e9c179056a5152f75aeddc3
BUG: 1244147
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11711
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

nfs: a unix-domain-socket should not be created as fifo

2015-07-23T12:59:20+00:00

Cherry picked from commit 381afd4f480533f212e1f62a0ccfd9dcf7248e17:
> Change-Id: Ic6a23165df1703b330636a059967c3c674dbde57
> BUG: 1235231
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/11355
> Tested-by: NetBSD Build System 
> Reviewed-by: Kaleb KEITHLEY 
> Tested-by: Gluster Build System 

Change-Id: Ic6a23165df1703b330636a059967c3c674dbde57
BUG: 1244118
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/11710
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY