glusterfs.git, branch v3.7.2

doc: add 1233044, 1232179 in 3.7.2 release-notes

2015-06-19T08:45:42+00:00

Change-Id: Ifad58ce716cc365f74bf24a37cd73d5284ea6b06
BUG: 1227206
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/11325
Reviewed-by: Humble Devassy Chirammal 
Tested-by: Humble Devassy Chirammal

features/bitrot: fix fd leak in truncate (stub)

2015-06-19T08:37:54+00:00

    Backport of http://review.gluster.org/#/c/11077

The need to perform object versioning in the truncate() code path
required an fd to reuse existing versioning infrastructure that's
used by fd based operations (such as writev(), ftruncate(), etc..).

This tempted the use of anonymous fd which was never ever unref()'d
after use resulting in fd and/or memory leak depending on the code
path taken. Versioning resulted in a dangling file descriptor left
open in the filesystem effecting the signing process of a given
object (no release() would be trigerred, hence no signing would be
performed). On the other hand, cases where the object need not be
versioned, the anonymous fd in still ref()'d resulting in memory
leak (NOTE: there's no "dangling" file descriptor in this case).

Change-Id: I29c3d2af9bbc5cd4b8ddf38954080e3c7a44ba61
BUG: 1232179
Signed-off-by: Venky Shankar 
Reviewed-on: http://review.gluster.org/11300
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Raghavendra Bhat

doc: add release notes for 3.7.2

2015-06-19T07:20:16+00:00

Change-Id: Ie0823ef219d7bf0f554e384fae698510137fb80d
BUG: 1227206
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/11320
Reviewed-by: Niels de Vos 
Tested-by: Niels de Vos 
Reviewed-by: Humble Devassy Chirammal 
Tested-by: Humble Devassy Chirammal

libgfchangelog: Fix crash in gf_changelog_process

2015-06-19T07:12:29+00:00

Problem:
    Crash observed in gf_changelog_process and
    gf_changelog_callback_invoker.

Cause:
    Assignments to arguments passed to thread is done
    post thread creation. If the thread created gets
    scheduled before the assignment and access these
    variables, it would crash with segmentation fault.

Solution:
    Assignments to arguments are done prior to the thread
    creation.

BUG: 1233044
Change-Id: I520599ab43026d25f4064ce71bd5a8b8e0d4b90a
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/11273
Reviewed-on: http://review.gluster.org/11308
Tested-by: Gluster Build System 
Reviewed-by: Venky Shankar

glusterd: Fix snapshot of a volume with geo-rep

2015-06-19T06:37:31+00:00

Problem:
    Snapshot fails for a volume configured with geo-rep
    if geo-rep is created with root user with the following
    syntax.
    gluster vol geo-rep  root@::

    It works fine if created with following syntax.
    gluster vol geo-rep  ::

Cause:
    Geo-rep maintains persistent dictionary of slave associated
    with master volume. The dictionary saves the slave info
    along with 'root@' as sent from cli.
    Snapshot while constructing the working dir path to copy
    configuration files, constructs using this dictionary.
    But the actual working dir is created with out considering
    'root@'. Hence the issue.

Fix:
    Fix is done at two layers.
    1. Parse and negelect 'root@' in cli itself.
    2. For existing geo-rep sessions and upgrade scenarios,
       parse and neglect 'root@' in snapshot code as well.

BUG: 1233056
Change-Id: Ic666e43a1c4ac2f3f0fb957caa77770e1eee4129
Signed-off-by: Kotresh HR 
Reviewed-on: http://review.gluster.org/11233
Reviewed-on: http://review.gluster.org/11310
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi

cluster/ec: Avoid parallel executions of the same state machine

2015-06-19T06:35:15+00:00

        Backport of http://review.gluster.org/11317

In very rare circumstances it was possible that a subfop started
by another fop could finish fast enough to cause that two or more
instances of the same state machine be executing at the same time.

Change-Id: I319924a18bd3f88115e751a66f8f4560435e0e0e
BUG: 1233484
Signed-off-by: Xavier Hernandez 
Reviewed-on: http://review.gluster.org/11319
Tested-by: Gluster Build System 
Tested-by: Pranith Kumar Karampuri 
Reviewed-by: Pranith Kumar Karampuri

quota: fix double accounting with rename operation

2015-06-19T05:33:30+00:00

This is a backport of http://review.gluster.org/#/c/11264/

> When a rename operation is performed, we are renaming
> the file first and performing remove-xattr when reducing
> the contri size from parents.
> This remove-xattr fails as the file is alreday renamed,
> this failure causes reduce-parent-size to abort resulting
> in double quota accounting
>
> This patch fixes the problem. We don't need to perform remove-xattr
> operation on a file when performing reduce-parent-size txn as this
> will be alreday done before starting reduce-parent-size txn
>
> Change-Id: If86e3dbb0233f6deaaa90bee72cb0ec1689c7325
> BUG: 1232572
> Signed-off-by: vmallika 

Change-Id: I7b12962d731ce9acf3ac78a99b2c23491722b78a
BUG: 1233117
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/11312
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Atin Mukherjee

cluster/dht: Prevent use after free bug

2015-06-19T05:16:25+00:00

        Backport of http://review.gluster.org/11209

BUG: 1233042
Change-Id: If3685c9ed84a6720d8696d11773005e9786b503f
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/11305
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System 
Reviewed-by: Atin Mukherjee

cluster/ec: Wind unlock fops at all cost

2015-06-19T02:49:35+00:00

        Backport of http://review.gluster.org/11152

Problem:
While files are being created if more than redundancy number of bricks
go down, then unlock for these fops do not go to the bricks. This will
lead to stale locks leading to hangs.

Fix:
Wind unlock fops at all costs.

BUG: 1230350
Change-Id: I3312b0fe1694ad02af5307bcbaf233ac63058846
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/11166
Tested-by: Gluster Build System

glusterd: Buffer overflow causing crash for glusterd

2015-06-19T01:30:28+00:00

Backport of http://review.gluster.org/11090

Problem: In GLUSTERD_GET_DEFRAG_PROCESS we are using PATH_MAX (4096)
as the max size of the input for target path, but we have allocated
NAME_MAX (255) size of buffer for the target.

Now this crash is not seen with source, but seen with RPMS.
The reason is _foritfy_fail. This check happens when _FORTIFY_SOURCE
is enabled. This option tries to figure out possible
overflow scenarios like the bug here and does crash the process.

BUG: 1227677
Change-Id: I50cf83cb60c640e46cc7a1a8d3a8321b9147fba9
Signed-off-by: Susant Palai 
Reviewed-on: http://review.gluster.org/11091
Reviewed-by: Atin Mukherjee 
Tested-by: Gluster Build System 
Tested-by: NetBSD Build System