glusterfs.git, branch v3.8.12

doc: release-notes for GlusterFS-3.8.12

2017-05-11T11:41:21+00:00

BUG: 1440754
Change-Id: I6602046ddc12834384e11c41a6e8e0cb7a8d5d71
Signed-off-by: Niels de Vos 
Reviewed-on: https://review.gluster.org/17252
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: jiffin tony Thottan 
CentOS-regression: Gluster Build System

performance/read-ahead: prevent stale data being returned to application.

2017-05-11T09:49:52+00:00

Assume that fd is shared by two application threads/processes.

T0 read is triggered from app-thread t1 and read call passes through
   write-behind.
T1 app-thread t2 issues a write. The page on which read from t1 is
   waiting is marked stale
T2 write-behind caches write and indicates to application as write
   complete.
T3 app-thread t2 issues read to same region. Since, there is already a
   page for that region (created as part of read at T0), this read
   request waits on that page to be filled (though it is stale, which
   is a bug).
T4 read (triggered at T0) completes from brick (with write still
   pending). Now both read requests from t1 and t2 are served this data
   (though data is stale from app-thread t2's perspective - which is a
   bug)
T5 write is flushed to brick by write-behind.

Fix is to not to serve data from a stale page, but instead initiate a
fresh read to back-end.

>Change-Id: Id6af733464fa41bb4e81fd29c7451c73d06453fb
>BUG: 1414242
>Signed-off-by: Raghavendra G 
>Reviewed-on: https://review.gluster.org/7447
>Smoke: Gluster Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Csaba Henk 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Zhou Zhengping 
>Reviewed-by: Amar Tumballi 

(cherry picked from commit 2ff39c5cbea6fbda0d7a442f55e6dc2a72efb171)
Change-Id: Id6af733464fa41bb4e81fd29c7451c73d06453fb
BUG: 1449314
Signed-off-by: Raghavendra G 
Reviewed-on: https://review.gluster.org/17223
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
Smoke: Gluster Build System

cluster/ec: fix incorrect answer check in seek fop

2017-05-11T08:36:04+00:00

A bad check in the answer of a seek request caused a segmentation
fault when seek reported an error.

> Change-Id: Ifb25ae8bf7cc4019d46171c431f7b09b376960e8
> BUG: 1439068
> Signed-off-by: Xavier Hernandez 
> Reviewed-on: https://review.gluster.org/16998
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Amar Tumballi 
> Reviewed-by: Pranith Kumar Karampuri 

Change-Id: Ifb25ae8bf7cc4019d46171c431f7b09b376960e8
BUG: 1442933
Signed-off-by: Xavier Hernandez 
Reviewed-on: https://review.gluster.org/17231
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Niels de Vos

cluster/dht: Pass the correct xdata in fremovexattr fop

2017-05-03T20:42:59+00:00

        Backport of: https://review.gluster.org/17126

Change-Id: Id84bc87e48f435573eba3b24d3fb3c411fd2445d
BUG: 1440635
Signed-off-by: Krutika Dhananjay 
Reviewed-on: https://review.gluster.org/17148
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Niels de Vos

geo-rep: filter out xtime attribute during getxattr

2017-05-03T08:19:47+00:00

georep gsyncd's xtime needs to filtered irrespective
of any process access.

This way, we can avoid (unnecessarily)syncing xtime attribute
to slave, which may raise permission denied errors.

test case modified to check for xtime xattr only in backend.
Back port of>
>Change-Id: I2390b703048d5cc747d91fa2ae884dc55de58669
>BUG: 1353952
>Signed-off-by: Saravanakumar Arumugam 
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: https://review.gluster.org/14880
>Smoke: Gluster Build System 
>Reviewed-by: Kotresh HR 
>Tested-by: Kotresh HR 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>Reviewed-by: Pranith Kumar Karampuri 

Change-Id: Ibdee6f3093648a7e0fb1e2b6be8172e604ab657f
BUG: 1441574
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: https://review.gluster.org/17045
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kotresh HR 
Reviewed-by: Niels de Vos

cluster/dht: Pass the req dict instead of NULL in dht_attr2()

2017-04-29T11:27:28+00:00

        Backport of: https://review.gluster.org/17085

This bug was causing VMs to pause during rebalance. When qemu winds
down a STAT, shard fills the trusted.glusterfs.shard.file-size attribute
in the req dict which DHT doesn't wind its STAT fop with upon detecting
the file has undergone migration. As a result shard doesn't find the
value to this key in the unwind path, causing it to fail the STAT
with EINVAL.

Also, the same bug exists in other fops too, which is also fixed in
this patch.

Change-Id: I56273b1a65347dabd38bc6bdd12d618f68287a00
BUG: 1440635
Signed-off-by: Krutika Dhananjay 
Reviewed-on: https://review.gluster.org/17121
Smoke: Gluster Build System 
Reviewed-by: Raghavendra G 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

afr: don't do a post-op on a brick if op failed

2017-04-29T11:26:24+00:00

Problem:
In afr-v2, self-blaming xattrs are not there by design. But if the FOP
failed on a brick due to an error other than ENOTCONN (or even due to
ENOTCONN, but we regained connection before postop was wound), we wind
the post-op also on the failed brick, leading to setting self-blaming
xattrs on that brick. This can lead to undesired results like healing of
files in split-brain etc.

Fix:
If a fop failed on a brick on which pre-op was successful, do not
perform post-op on it. This also produces the desired effect of not
resetting the dirty xattr on the brick, which is how it should be
because if the fop failed on a brick, there is no reason to clear the
dirty bit which actually serves as an indication of the failure.

> Reviewed-on: https://review.gluster.org/16976
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Pranith Kumar Karampuri 

Change-Id: I5f1caf4d1b39f36cf8093ccef940118638caa9c4
BUG: 1443319
Signed-off-by: Ravishankar N 
Reviewed-on: https://review.gluster.org/17082
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Pranith Kumar Karampuri

scripts: Update rfc.sh to check existance of Change-Id in backports

2017-04-29T11:25:24+00:00

Addition to this script is a no-op on master.

This would need to be backported to active release branches to be
effective.

This check is not smart proof, in that someone could proceed knowing
that the Change-Id differs from master, but this is not expected to
catch that, instead it is to serve more as a reminder that we need
the same Change-Id across branches.

Contributors not using rfc.sh would not see this, but they are few
and possibly far in between. Also contributors using gerrit to
cherry-pick changes will not see this. For both cases a server side
solution to catch any changes are needed.

There is a possiblilty that we will follow this up with a check
on the gerrit end and add a comment to the reviews, to aid reviewers
to quickly check the sanity of the Change-Id when it differs.

> BUG: 1428047
> Signed-off-by: Shyam 
> Reviewed-on: https://review.gluster.org/17004
> Smoke: Gluster Build System 
> Reviewed-by: Niels de Vos 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Kaleb KEITHLEY 
> Reviewed-by: Amar Tumballi 

Change-Id: I11e371489a4a3cf2ff96d9892256986cd535998b
BUG: 1440810
Signed-off-by: Shyam 
Reviewed-on: https://review.gluster.org/17031
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Niels de Vos

nfs: make subdir mounting work for Solaris 10 clients

2017-04-29T11:20:30+00:00

This fixes the segfault caused by solaris client in Gluster/NFS.
Volname was not being parsed properly, Instead of volume
name complete path was being used in nfs_mntpath_to_xlator().
Fixed it by striping volume name from complete path  in nfs_mntpath_to_xlator().

Modified function name nfs3_funge_solaris_zerolen_fh() to
nfs3_funge_webnfs_zerolen_fh() as zero-filled filehandle is specific to WebNFS.
RFC : https://tools.ietf.org/html/rfc2055
Solaris uses WebNFS, the zero-filled FH is defined in the WebNFS spec.

Logic was even added in fuction nfs3_funge_webnfs_zerolen_fh() to send
subdir path in function glfs_resolve_at() instead of complete path for
subdir mount.

> Change-Id: I19aae3547b8910e7ed4974ee5385424cab3e834a
> BUG: 1426667
> Signed-off-by: Bipin Kunal 
> Reviewed-on: https://review.gluster.org/16770
> Reviewed-by: Niels de Vos 
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> (cherry picked from commit 40e571339b3c19ab2a5b6a93bc46eadf2252d006)

Change-Id: I21ebb1d104b6eb914af5f26a6906f161c132179c
BUG: 1440228
Signed-off-by: Bipin Kunal 
Reviewed-on: https://review.gluster.org/17017
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos 
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System

glusterd/geo-rep: Fix snapshot create in geo-rep setup

2017-04-28T09:39:20+00:00

glusterd persists geo-rep sessions in glusterd
info file which is represented by dictionary
'volinfo->gsync_slaves' in memory. Glusterd also
maintains in memory active geo-rep sessions in
dictionary 'volinfo->gsync_active_slaves' whose key
is "::".

When glusterd is restarted while the geo-rep sessions
are active, it builds the 'volinfo->gsync_active_slaves'
from persisted glusterd info file. Since slave volume
uuid is added to "voinfo->gsync_slaves" with the commit
"http://review.gluster.org/13111", it builds it with key
":::" which is
wrong. So during snapshot pre-validation which checks
whether geo-rep is active or not, it always says it is
ACTIVE, as geo-rep stop would not deleted this key.
Fixed the same in this patch.


> BUG: 1443977
> Signed-off-by: Kotresh HR 
> Reviewed-on: https://review.gluster.org/17093
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Atin Mukherjee 
(cherry picked from commit f071d2a285ea4802fe8f328f9f275180983fbbba)

Change-Id: I185178910b4b8a62e66aba406d88d12fabc5c122
BUG: 1445213
Signed-off-by: Kotresh HR 
Reviewed-on: https://review.gluster.org/17109
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Aravinda VK