glusterfs.git, branch v4.1.0rc0 protocol/client: Don't send fops till SETVOLUME is complete 2018-05-31T20:29:45+00:00 Raghavendra G rgowdapp@redhat.com 2018-05-30T04:04:44+00:00 4f591e873c0a38b662910f8e8a5768fd3e9bbeaa An earlier commit set conf->connected just after rpc layer sends RPC_CLNT_CONNECT event. However, success of socket level connection connection doesn't indicate brick stack is ready to receive fops, as an handshake has to be done b/w client and server after RPC_CLNT_CONNECT event. Any fop sent to brick in the window between, * protocol/client receiving RPC_CLNT_CONNECT event * protocol/client receiving a successful setvolume response can end up accessing an uninitialized brick stack. So, set conf->connected only after a successful SETVOLUME. Change-Id: I139a03d2da6b0d95a0d68391fcf54b00e749decf fixes: bz#1584633 Signed-off-by: Raghavendra G <rgowdapp@redhat.com> (cherry picked from commit 430e4872db43447c8a15b638760d23c188257139) 
An earlier commit set conf->connected just after rpc layer sends
RPC_CLNT_CONNECT event. However, success of socket level connection
connection doesn't indicate brick stack is ready to receive fops, as
an handshake has to be done b/w client and server after
RPC_CLNT_CONNECT event. Any fop sent to brick in the window between,
* protocol/client receiving RPC_CLNT_CONNECT event
* protocol/client receiving a successful setvolume response

can end up accessing an uninitialized brick stack. So, set
conf->connected only after a successful SETVOLUME.

Change-Id: I139a03d2da6b0d95a0d68391fcf54b00e749decf
fixes: bz#1584633
Signed-off-by: Raghavendra G <rgowdapp@redhat.com>
(cherry picked from commit 430e4872db43447c8a15b638760d23c188257139)
doc: GD2 release notes for 4.1.0 2018-05-31T16:10:13+00:00 Kaushal M kaushal@redhat.com 2018-05-31T16:09:11+00:00 9ded7a6ff6a1a878771f37962d0107bed56b7e9c Change-Id: Iaa32b252b84ccd95e78360130da3e8f6cbc2e7fb updates: bz#1575386 Signed-off-by: Kaushal M <kaushal@redhat.com> 
Change-Id: Iaa32b252b84ccd95e78360130da3e8f6cbc2e7fb
updates: bz#1575386
Signed-off-by: Kaushal M <kaushal@redhat.com>
cluster/dht: Fix rebalance log msg 2018-05-31T13:13:39+00:00 N Balachandran nbalacha@redhat.com 2018-05-21T05:34:45+00:00 67086dbd9e8fbe8ff21ba3cccdf21530ba3f80ff Corrected the name of the xattr and fixed the code to log an error only if op_errno is not ENODATA or ENOATTR. Change-Id: I42c5b1d838eec586ac7bed2471eb1d27ff09a9ea fixes: bz#1583769 Signed-off-by: N Balachandran <nbalacha@redhat.com> 
Corrected the name of the xattr and fixed
the code to log an error only if op_errno
is not ENODATA or ENOATTR.

Change-Id: I42c5b1d838eec586ac7bed2471eb1d27ff09a9ea
fixes: bz#1583769
Signed-off-by: N Balachandran <nbalacha@redhat.com>
rpc: conditionally cleanup event slot 2018-05-29T14:56:05+00:00 Milind Changire mchangir@redhat.com 2018-05-26T07:06:04+00:00 37773839e4eee8a753598fb01dbd06220b98dc72 Problem: socket_server_event_handler() may call rpc_transport_unref() for a socket which may fail registration with the event sub-system. This causes an assert to fail in event_unregister_epoll_common() Solution: Conditionally cleanup event slot only if slot index >= 0 Change-Id: I6ca7c133712e894adc335c7763879691b7e4b213 fixes: bz#1583734 Signed-off-by: Milind Changire <mchangir@redhat.com> (cherry picked from commit 3780f6c2515c34f8705eb0fe25291bb97e73f354) 
Problem:
socket_server_event_handler() may call rpc_transport_unref() for a
socket which may fail registration with the event sub-system.
This causes an assert to fail in event_unregister_epoll_common()

Solution:
Conditionally cleanup event slot only if slot index >= 0

Change-Id: I6ca7c133712e894adc335c7763879691b7e4b213
fixes: bz#1583734
Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 3780f6c2515c34f8705eb0fe25291bb97e73f354)
api: missing __THROW on pub function decls 2018-05-29T14:38:51+00:00 Kaleb S. KEITHLEY kkeithle@redhat.com 2018-05-23T15:25:26+00:00 040619ef9946fb6cd151a07239613b6d88417935 missing __THROW on pub function decls needed for C++ Change-Id: Ia0ff09d311741e4cdc8ef171e07bbd56c24b9260 fixes: bz#1582549 Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com> 
missing __THROW on pub function decls needed for C++

Change-Id: Ia0ff09d311741e4cdc8ef171e07bbd56c24b9260
fixes: bz#1582549
Signed-off-by: Kaleb S. KEITHLEY <kkeithle@redhat.com>
doc: Updated 4.1.0 release notes for smb.conf changes 2018-05-29T14:38:34+00:00 ShyamsundarR srangana@redhat.com 2018-05-25T14:11:11+00:00 202694a6c4597d54fd410d8cc6bf59abf3de6573 Updates: bz#1575386 Change-Id: I7a60b06bb57efdecbb5209ab4f98e858c8c39c77 Signed-off-by: ShyamsundarR <srangana@redhat.com> 
Updates: bz#1575386
Change-Id: I7a60b06bb57efdecbb5209ab4f98e858c8c39c77
Signed-off-by: ShyamsundarR <srangana@redhat.com>
libgfapi: Fix lookup on root 2018-05-29T14:38:25+00:00 Kotresh HR khiremat@redhat.com 2018-05-25T12:55:11+00:00 49095af5b431b8fdd90c7a578cdeba329bda4a3e Lookup on root was sending "/" as the path. This will break the basename calculation in loc_copy and hence lookup on root was failing if the loc_copy was involved in the stack. With ctime, a first lookup on root initiates a metadata self heal because of ctime xattr not being same on all afr subvolumes. This results in loc_copy and hence the failure of lookup. Fix would be to send path with "." for the root. Backport of: > Patch: https://review.gluster.org/#/c/20086/ > BUG: 1582516 > Change-Id: Iafe4b99f249a4f5034ad34c1d30590de0e35aa0d (cherry picked from commit 3d38e4e47f129bdb36c3fbbd481dabe4ba4413d6) fixes: bz#1583016 Change-Id: Iafe4b99f249a4f5034ad34c1d30590de0e35aa0d Signed-off-by: Kotresh HR <khiremat@redhat.com> 
Lookup on root was sending "/" as the path.
This will break the basename calculation in
loc_copy and hence lookup on root was failing
if the loc_copy was involved in the stack.

With ctime, a first lookup on root initiates
a metadata self heal because of ctime xattr
not being same on all afr subvolumes. This
results in loc_copy and hence the failure
of lookup.

Fix would be to send path with "." for the root.

Backport of:
  > Patch: https://review.gluster.org/#/c/20086/
  > BUG: 1582516
  > Change-Id: Iafe4b99f249a4f5034ad34c1d30590de0e35aa0d
(cherry picked from commit 3d38e4e47f129bdb36c3fbbd481dabe4ba4413d6)


fixes: bz#1583016
Change-Id: Iafe4b99f249a4f5034ad34c1d30590de0e35aa0d
Signed-off-by: Kotresh HR <khiremat@redhat.com>
posix/ctime: Fix updating mtime to older time 2018-05-25T13:52:47+00:00 Kotresh HR khiremat@redhat.com 2018-05-22T04:34:48+00:00 e36d5c6b8c1c3800ef89a0251854bd2b7e2af924 With ctime feature enabled, the mtime is not updated when it's set to time older than the existing one. Fixed the same. But the ctime is not allowed to change to older dates. Backport of: > Patch: https://review.gluster.org/#/c/20055/ > BUG: 1581035 > Change-Id: If520922df42d6ce084c8df3046c138f8367164e5 (cherry picked from commit e9e3699456e738635685c9f42d1c4206c6177510) fixes: bz#1582531 Change-Id: If520922df42d6ce084c8df3046c138f8367164e5 Signed-off-by: Kotresh HR <khiremat@redhat.com> (cherry picked from commit e9e3699456e738635685c9f42d1c4206c6177510) 
With ctime feature enabled, the mtime is not
updated when it's set to time older than the
existing one. Fixed the same. But the ctime
is not allowed to change to older dates.

Backport of:
 > Patch: https://review.gluster.org/#/c/20055/
 > BUG: 1581035
 > Change-Id: If520922df42d6ce084c8df3046c138f8367164e5
(cherry picked from commit e9e3699456e738635685c9f42d1c4206c6177510)

fixes: bz#1582531
Change-Id: If520922df42d6ce084c8df3046c138f8367164e5
Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit e9e3699456e738635685c9f42d1c4206c6177510)
afr: fix bug-1363721.t failure 2018-05-25T12:57:45+00:00 Ravishankar N ravishankar@redhat.com 2018-05-18T10:08:29+00:00 c6f21697a52200bbbf9af05dff2b9c3ae0a99b43 Problem: In the .t, when the only good brick was brought down, writes on the fd were still succeeding on the bad bricks. The inflight split-brain check was marking the write as failure but since the write succeeded on all the bad bricks, afr_txn_nothing_failed() was set to true and we were unwinding writev with success to DHT and then catching the failure in post-op in the background. Fix: Don't wind the FOP phase if the write_subvol (which is populated with readable subvols obtained in pre-op cbk) does not have at least 1 good brick which was up when the transaction started. Note: This fix is not related to brick muliplexing. I ran the .t 10 times with this fix and brick-mux enabled without any failures. Change-Id: I915c9c366aa32cd342b1565827ca2d83cb02ae85 updates: bz#1581548 Signed-off-by: Ravishankar N <ravishankar@redhat.com> (cherry picked from commit 985a1d15db910e012ddc1dcdc2e333cc28a9968b) 
Problem:
In the .t, when the only good brick was brought down, writes on the fd were
still succeeding on the bad bricks. The inflight split-brain check was
marking the write as failure but since the write succeeded on all the
bad bricks, afr_txn_nothing_failed() was set to true and we were
unwinding writev with success to DHT and then catching the failure in
post-op in the background.

Fix:
Don't wind the FOP phase if the write_subvol (which is populated with readable
subvols obtained in pre-op cbk) does not have at least 1 good brick which was up
when the transaction started.

Note: This fix is not related to brick muliplexing. I ran the .t
10 times with this fix and brick-mux enabled without any failures.

Change-Id: I915c9c366aa32cd342b1565827ca2d83cb02ae85
updates: bz#1581548
Signed-off-by: Ravishankar N <ravishankar@redhat.com>
(cherry picked from commit 985a1d15db910e012ddc1dcdc2e333cc28a9968b)
rpc: Don't reset auth_value in disconnect 2018-05-25T12:57:27+00:00 Kotresh HR khiremat@redhat.com 2018-05-17T09:28:24+00:00 dbe0984d8a84e0ca0e0d42f84d856c6f1d2a5134 The auth_value was being reset to AUTH_GLUSTERFS_v2 during rpc disconnect. It shoud not be reset. The disconnect during portmap request can race with handshake. If handshake happens first and disconnect later, auth_value would set to default value and it never sets back to actual auth_value Back port of > BUG: 1579276 > Change-Id: Ib46c9e01a97f6defb3fd1e0423fdb4b899b4a361 > Signed-off-by: Kotresh HR <khiremat@redhat.com> (cherry picked from commit 2d5b179d1a545f5b7ae8b1b2274769691dd3468f) fixes: bz#1582063 Change-Id: Ib46c9e01a97f6defb3fd1e0423fdb4b899b4a361 Signed-off-by: Kotresh HR <khiremat@redhat.com> 
The auth_value was being reset to AUTH_GLUSTERFS_v2
during rpc disconnect. It shoud not be reset. The
disconnect during portmap request can race with
handshake. If handshake happens first and
disconnect later, auth_value would set to default
value and it never sets back to actual auth_value

Back port of
> BUG: 1579276
> Change-Id: Ib46c9e01a97f6defb3fd1e0423fdb4b899b4a361
> Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit 2d5b179d1a545f5b7ae8b1b2274769691dd3468f)

fixes: bz#1582063
Change-Id: Ib46c9e01a97f6defb3fd1e0423fdb4b899b4a361
Signed-off-by: Kotresh HR <khiremat@redhat.com>