glusterfs.git/api/src, branch release-3.9

libgfapi: revert addtion of glfs_ipc_xd()

2017-01-25T16:20:40+00:00

missed a couple of things

BUG: 1415288
Change-Id: I36117c6c85472a7ec278413ac59561e03eea30af
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: https://review.gluster.org/16449
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

gfapi: glfs_subvol_done should NOT wait for graph migration.

2017-01-07T13:58:33+00:00

In graph_setup function glfs_subvol_done is called which
is executed in an epoll thread. glfs_lock waits on other
thread to finish graph migration. This can lead to dead lock
if we consume all the epoll threads.

In general any call-back function executed in epoll thread
should not call any blocking call which waits on a network
reply either directly or indirectly, e.g. syncop functions
should not be called in these threads.

As a fix we should not wait for migration in the call-back path.

> Reviewed-on: http://review.gluster.org/15913
> NetBSD-regression: NetBSD Build System 
> Smoke: Gluster Build System 
> Reviewed-by: Niels de Vos 
> CentOS-regression: Gluster Build System 
(cherry picked from commit 17d10b42fc4041442e6cd0bfda45944edea498c6)

Change-Id: If96d0689fe1b4d74631e383048cdc30b01690dc2
BUG: 1399916
Signed-off-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/15978
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Niels de Vos

libglusterfs:Now mempool is added to ctx pool list under a lock

2016-11-28T09:10:39+00:00

mempool is added to ctx pool list without any lock. This can cause undefined
behaviour in case of multithreaded environment.

Fix: modify the list only under ctx->lock

> Reviewed-on: http://review.gluster.org/15842
> NetBSD-regression: NetBSD Build System 
> Smoke: Gluster Build System 
> CentOS-regression: Gluster Build System 
> Reviewed-by: Raghavendra Talur 
> Reviewed-by: Shyamsundar Ranganathan 
> Reviewed-by: Poornima G 
> Reviewed-by: Niels de Vos 
(cherry picked from commit 277008a3a8583ef10cec9e4182960792e56c5c10)

Change-Id: I7bdbb3db48a899bb0e41427e149b13c0facaedba
Signed-off-by: Rajesh Joseph 
BUG: 1397664
Reviewed-on: http://review.gluster.org/15908
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Poornima G 
Reviewed-by: Raghavendra Talur

gfapi: add glfs_free() to glfs.h

2016-11-23T02:03:54+00:00

Commit 4721188a154acd9a0a4c096d8d73e97f3bf1b2a9 introduces glfs_free()
but missed adding the function to the header. The symbol is correctly
available in the library though. Testcases do not seem to fail when a
function is missing for the headers...

The glusterfs-3.7.16 packages have been released with the missing
declaration in the header and symbol-maps. Still, the function is
available for applications:

    $ objdump -T usr/lib64/libgfapi.so.0 | grep -w glfs_free
    0000000000006aa0 g    DF .text	0000000000000035  GFAPI_3.7.16 glfs_free

Cherry picked from commit 5ab0b43ce67d8d131242542a80b6aa6b129ed5ee:
> Change-Id: Ia707ee957f090dbfca028192fcc81a83dfdf4ae0
> BUG: 1344714
> Reported-by: Jiffin Tony Thottan 
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/15653
> CentOS-regression: Gluster Build System 
> Smoke: Gluster Build System 
> Reviewed-by: jiffin tony Thottan 
> NetBSD-regression: NetBSD Build System 

Change-Id: Ia707ee957f090dbfca028192fcc81a83dfdf4ae0
BUG: 1397506
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/15907
Reviewed-by: soumya k 
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

gfapi: remove extra fd_unref

2016-11-11T15:45:15+00:00

Online gerrit rebase does not seem to be working. Commit
a3bade0976d9f976855baf0de479205aa50e2abd is not complete backport of
http://review.gluster.org/#/c/15768.


Change-Id: I5229d87c8c403106f20c50bc8a7f38dad9a2303d
BUG: 1392286
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/15829
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System

gfapi: async fops should unref in callbacks

2016-11-10T08:25:11+00:00

If fd is unref'd at the end of async call then the unref in cbks would
lead to double unref and possible crash. Removing duplicate unrefs.

Added unref only in failure cases.

A simple test case has been added to test async write case. Need to
extend the same for other async APIs too.

Details:
All glfd based calls in libgfapi, except for glfs_open and glfs_close,
behave in the same way. At the start of the operation, they take a ref
on glfd and fd. At the end of the operation, they unref it. Async calls
are a little different as they unref in the cbk function. A successfull
open call does not unref either the glfd or fd, thereby functioning as a
reference for a OPEN file object. glfs_close makes a syncop_flush call
sandwiched between a fd ref and unref(this can be removed, more on this
below), followed by a call to glfs_mark_glfd_for_deletion which unrefs
glfd and also calls glfs_fd_destroy as a release function thereby doing
a unref on fd too.

Functionally, there is no problem with how everything works when as
described above. However, it is a little non-intuitive that we need to
perform a fd_unref as a consequence of a implicit fd_ref that happens
within glfs_resolve_fd. As we perform a GF_REF_GET(glfd) at the start of
every operation, it would be worthwhile to remove the fd_ref that
glfs_resovle_fd takes and do away with explicit fd_unref()s at the end
of every operation. This is the same reason why we don't need the fd_ref
in glfs_close. This is however not in the scope of this patch.

Change-Id: I86b1d3b2ad846b16ea527d541dc82b5e90b0ba85
BUG: 1392286
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/15768
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Xavier Hernandez 
Reviewed-by: soumya k 
Reviewed-by: Prasanna Kumar Kalever 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
(cherry picked from commit e65738818dd22462ec00dda021566654d1c702b1)
Reviewed-on: http://review.gluster.org/15778

gfapi: Fix few fd ref leaks

2016-11-10T06:44:03+00:00

From the code inspection, have observed that there are fd ref
leaks for few fd-based gfapi fops. 'glfs_resolve_fd' returns
a fd (either existing or migrated) with an extra ref taken.
This needs to be unref'ed at the end of the operation.

Mainline reference:
> Change-Id: Id63394e3e7deafb0c8b06444f2ae847248b126db
> BUG: 1379285
> Signed-off-by: Soumya Koduri 
> Reviewed-on: http://review.gluster.org/15573
> Reviewed-by: Niels de Vos 
(cherry picked from commit d27cffab670858d7812bbb458a0833303d009b3b)

Change-Id: I17dd9e31eca7ffa1f60a9e3a66b1c7051ce9002f
BUG: 1379707
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/15584
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Raghavendra Talur

gfapi/upcall: Fix mismatch in few upcall API SYMVER

2016-11-06T13:24:35+00:00

There is mismatch in few of the upcall API routine
definitions and their corresponding symbol version
declarations. Fixed the same.

> Change-Id: I2edfd9546a4c6a9128757f3b68e3ae4edd2c7a79
> BUG: 1344714
> Signed-off-by: Soumya Koduri 
> Reviewed-on: http://review.gluster.org/15760
> Smoke: Gluster Build System 
> Reviewed-by: jiffin tony Thottan 
> Reviewed-by: Kaleb KEITHLEY 
> Tested-by: Kaleb KEITHLEY 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 
> (cherry picked from commit 5b453380b15f34c0841f453a02fdabc46ad2f7ef)

Change-Id: Ia9f5ab5d8d7d4ad77f1215e8249d346e31080573
BUG: 1378948
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/15774
Smoke: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

api: revert addition of glfs_ipc_xd()

2016-10-14T20:29:15+00:00

It is intended for 4.0

Cherry picked from commit f4e5841eb6f132174e65ccad91fd2f6021771f29:
> Change-Id: Ieffe1d966234652091a4a9ae0b2c4b23f1297147
> BUG: 1345977
> Signed-off-by: Kaleb S KEITHLEY 
> Reviewed-on: http://review.gluster.org/14716
> Smoke: Gluster Build System 
> Reviewed-by: Jeff Darcy 
> Reviewed-by: Shyamsundar Ranganathan 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Niels de Vos 
> CentOS-regression: Gluster Build System 

Note that this 'backport' is done on a patch from the release-3.8
branch, and it not part of the master branch.

Change-Id: Ieffe1d966234652091a4a9ae0b2c4b23f1297147
BUG: 1364529
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/15642
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

gfapi: warn when glfs_realpath() returned malloc'd memory

2016-10-11T18:54:21+00:00

glfs_realpath() may return memory allocated with malloc(). Depending on
the memory allocator that the application uses, calling free() on the
returned string can cause segmentation faults or other problems.

Functions that allocate memory, need to match the free'ing of the same
memory allocator and memory accounting. glibc/malloc and jemalloc/free
do not match together (other allocators could probably trigger these
problems as well).

Applications need to provide a pre-allocated buffer, or in case
glfs_realpath() allocates the memory, glfs_free() should be used to free
it.

Cherry picked from commit 85e959052148ec481823d55c8b91cdee36da2b43:
> Change-Id: I5d721a7425674aa700db8a7a436cbedb95a5927f
> BUG: 1370931
> Signed-off-by: Niels de Vos 
> Reviewed-on: http://review.gluster.org/15332
> CentOS-regression: Gluster Build System 
> Smoke: Gluster Build System 
> NetBSD-regression: NetBSD Build System 
> Reviewed-by: Kaleb KEITHLEY 

Change-Id: I5d721a7425674aa700db8a7a436cbedb95a5927f
BUG: 1383591
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/15621
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY