glusterfs.git/api/src, branch v3.11.0rc1

gfapi: Fix few severe coverity issues

2017-05-07T15:34:01+00:00

From https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-05-03-6484558c/html/
fixes coverity#189, 248, 250, 488, 546

This is backport of below mainline fix -
- https://review.gluster.org/17161

>Change-Id: I7c4aa5bf6c367344602748dfd736de27f341cca2
>BUG: 789278
>Signed-off-by: Soumya Koduri 
>Reviewed-on: https://review.gluster.org/17161
>Smoke: Gluster Build System 
>Reviewed-by: Niels de Vos 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Amar Tumballi 
>CentOS-regression: Gluster Build System 
>(cherry picked from commit fa10c8a3528b95dc575bfedd30bcd68cc2dff25b)

Change-Id: I7c4aa5bf6c367344602748dfd736de27f341cca2
BUG: 1447571
Signed-off-by: Soumya Koduri 
Reviewed-on: https://review.gluster.org/17194
Reviewed-by: Niels de Vos 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Smoke: Gluster Build System

gfapi/handleops: Introducing glfs_xreaddirplus_r() fop for handleops

2017-05-05T11:12:48+00:00

Its known that readdirplus operation fetches stat as well for each of the
dirents. But often applications may need extra information, like for eg.,
NFS-Ganesha which operates on handles needs handles for each of those
dirents returned. So this would require extra calls to the backend, in this
case LOOKUP (which is very expensive operation) resulting in very low
readdir performance.

To address that introducing this new API using which applications can
make request for any extra information to be returned as part of
readdirplus response.

Currently this new api returns stat and handles as demanded by application.
The synopsis of the API is noted in glfs.h.

@todo:
* Enhance test script using this new API

Below were the perf results on single brick volume with and without
these changes -

Dataset used -
10*100 directories and each directory containing 100 empty files.

I used NFS-Ganesha application to test these changes -
>for i in {1..5}; do systemctl restart nfs-ganesha; sleep 10; mount -t nfs -o vers=4 localhost:/brick_vol /mnt; cd /mnt; echo "ITERATION$i"; date; find . > tmp-nfs.log; date; cd /; umount /mnt; sleep 2; done;

Without these changes -
ITERATION1
Mon Mar 20 17:22:26 IST 2017
Mon Mar 20 17:23:18 IST 2017
ITERATION2
Mon Mar 20 17:23:39 IST 2017
Mon Mar 20 17:24:28 IST 2017
ITERATION3
Mon Mar 20 17:24:49 IST 2017
Mon Mar 20 17:25:36 IST 2017
ITERATION4
Mon Mar 20 17:30:57 IST 2017
Mon Mar 20 17:31:37 IST 2017
ITERATION5
Mon Mar 20 17:31:57 IST 2017
Mon Mar 20 17:32:40 IST 2017
[root@dhcp35-197 /]#

On an average ~46.2 sec

With these changes applied -
ITERATION1
Mon Mar 20 17:35:03 IST 2017
Mon Mar 20 17:35:15 IST 2017
ITERATION2
Mon Mar 20 17:35:36 IST 2017
Mon Mar 20 17:35:46 IST 2017
ITERATION3
Mon Mar 20 17:36:06 IST 2017
Mon Mar 20 17:36:17 IST 2017
ITERATION4
Mon Mar 20 17:41:38 IST 2017
Mon Mar 20 17:41:49 IST 2017
ITERATION5
Mon Mar 20 17:42:10 IST 2017
Mon Mar 20 17:42:20 IST 2017

On an average ~10.8 sec

This is backport of below upstream patch -
        https://review.gluster.org/15663

>Updates #174
>BUG: 1442950
>Change-Id: I0f74f74dc62085ca4c4a23c38e3edc84bd850876
>Signed-off-by: Soumya Koduri 
>Reviewed-on: https://review.gluster.org/15663
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>Reviewed-by: Niels de Vos 
>CentOS-regression: Gluster Build System 

BUG: 1447571
Change-Id: I0f74f74dc62085ca4c4a23c38e3edc84bd850876
Signed-off-by: Soumya Koduri 
Reviewed-on: https://review.gluster.org/17164
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

libgfapi: remove/revert glfs_ipc() changes targeted for 4.0

2017-05-03T12:32:50+00:00

revert glfs_ipc() to 3.7.0 signature and associated symbol versioning

Cherry picked from commit e549df2c0d8b5dbfa6e9c129109185aaf4cea11d:
> Change-Id: Ieffe1d966234652091a4a9ae0b2c4b23f1297147
> BUG: 1415279
> Signed-off-by: Kaleb S. KEITHLEY 
> Reviewed-on: https://review.gluster.org/16450
> Smoke: Gluster Build System 
> Reviewed-by: Shyamsundar Ranganathan 
> NetBSD-regression: NetBSD Build System 
> CentOS-regression: Gluster Build System 

Change-Id: Ieffe1d966234652091a4a9ae0b2c4b23f1297147
BUG: 1447543
Signed-off-by: Kaushal M 
Reviewed-on: https://review.gluster.org/17153
Smoke: Gluster Build System 
Reviewed-by: Niels de Vos 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

api: fix two typos of GFAPI_PUBLIC function define

2017-04-29T12:55:43+00:00

Change-Id: I2f9915b3572c4cbce6748e99a037daba439a187e
BUG: 1446273
Signed-off-by: Kinglong Mee 
Reviewed-on: https://review.gluster.org/17112
Reviewed-by: Niels de Vos 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
NetBSD-regression: NetBSD Build System

api: free the xattr data after using in glfs_volfile_fetch

2017-04-26T14:57:01+00:00

Change-Id: I89a7df93039e367301fd70df722c13f1d8b3484b
Signed-off-by: Kinglong Mee 
Reviewed-on: https://review.gluster.org/17091
Smoke: Gluster Build System 
Reviewed-by: Prashanth Pai 
Reviewed-by: Poornima G 
Tested-by: Poornima G 
Reviewed-by: Amar Tumballi 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy

api: fix bad release of dict causes memory leak

2017-04-25T15:04:09+00:00

Change-Id: Ic7169fd05aff7bf46108e8ac7b1f29688a7f2358
Signed-off-by: Kinglong Mee 
Reviewed-on: https://review.gluster.org/17092
Tested-by: Poornima G 
Reviewed-by: Poornima G 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Prashanth Pai 
Smoke: Gluster Build System 
Reviewed-by: Amar Tumballi

api: free all dynamic memory returned from xdr_to_generic

2017-04-21T20:08:02+00:00

Change-Id: I01235ffca80683e69e99da09a9fc1a6d3ffdcb65
Signed-off-by: Kinglong Mee 
Reviewed-on: https://review.gluster.org/17090
Tested-by: Poornima G 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Jeff Darcy 
Smoke: Gluster Build System

api: Fix incorrect strcmp() during fs initialisation

2017-04-18T20:32:49+00:00

Just chanced upon this while reading graph switch code in
libgfapi.

Change-Id: Ie62b410c22e6d0768a24187c5d587b6d3fc996bf
Signed-off-by: Krutika Dhananjay 
Reviewed-on: https://review.gluster.org/16319
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
Reviewed-by: Amar Tumballi 
CentOS-regression: Gluster Build System 
Reviewed-by: Vijay Bellur

gfapi: Fix inode ref leak in anonymous fd I/O APIs

2017-04-18T11:25:30+00:00

In the APIs to do I/Os using anonymous fd, there
is a ref taken for inode which hasn't been unreferenced
post the operation. This shall result in the leak.

Change-Id: I75ea952a6b2df58c385f4f53398e5562f255248d
BUG: 1438738
Signed-off-by: Soumya Koduri 
Reviewed-on: https://review.gluster.org/16989
Reviewed-by: Prashanth Pai 
Smoke: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Niels de Vos 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

gfapi: prevent off-by-one buffer overrun in glfs_sysrq()

2017-04-18T08:59:30+00:00

Coverity found a potential buffer overrun in the strncat() usage for
logging the help message with glfs_sysrq(). This seems to be an
off-by-one mistake and should be addressed by reducing the initial size
of the remainder calculation.

Change-Id: Ide14add1cb28e5200d2c0df6b3a5154999ef3ca9
BUG: 789278
Signed-off-by: Niels de Vos 
Reviewed-on: https://review.gluster.org/17024
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Amar Tumballi