glusterfs.git/api/src, branch v3.7.9

gfapi: return EINVAL for unsupported lseek() operations

2016-03-09T12:03:23+00:00

GlusterFS 3.8 contains support for SEEK_DATA/SEEK_HOLE. This protocol
extension is not available in 3.7. libgfapi needs to handle unsupported
SEEK_* operations correctly, by returning -1 and setting errno to
EINVAL.

This change is different from the patch in the master branch, it is only
needed to do the improved error checking in this version.

BUG: 1315557
Change-Id: I142dde11923244809b03fcca8cd4c2f7d5ff3929
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/13631
Smoke: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Vijay Bellur

gfapi: Add xlator_cbks fops in gfapi

2016-02-29T12:01:24+00:00

This is backport of the below fix -
 http://review.gluster.org/13499

Change-Id: I1fe5dd757e65206f92e0a867b43b49a3c0f2d4cf
BUG: 1311445
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/13499
Reviewed-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/13508
NetBSD-regression: NetBSD Build System 
Smoke: Gluster Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

gfapi: Use inode_forget in case of handle objects

2016-02-27T19:04:25+00:00

Currently with gfapi, even if applications release their
reference on paritular inode entries, those entries never
get destroyed as they shall always have positive nlookup
count unless inode_table exceeds lru limit.

Since inodes and their contexts can consume considerable
amount of memory, applications may end up consuming lot of
memory and may even get OOM killed.

To avoid that, have considered below approaches (for handle based access)-
a) Do 'inode_lookup' only if the corresponding inode is created
for the first time and forget it during close of the handle

This shall not work as multiple handle objects can refer to
same inode entry and inode_forget from second handle object
onwards shall result in assert.

b) Do 'inode_lookup' during a handle or fd creation

But this approach shall affect the performance of the fops which
operate on neither handle nor fd.

c) current approach taken-
Applications using glfs handle objects hold a reference
on corresponding inode entries. Hence it is safe to forget
those inodes and make nlookup count to '0' while trying to
delete those handle objects. That way the last unref (i.e,
from the last handle close) shall result in inode_destroy().

This is backport of the below patch
	- http://review.gluster.org/13096

Change-Id: Id2c7ab178894a10c0030c143ba71e7813df8d18c
Signed-off-by: Soumya Koduri 
BUG: 1311441
Reviewed-on: http://review.gluster.org/13096
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Niels de Vos 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-on: http://review.gluster.org/13506
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System

gfapi: send lookup if inode_ctx is not set

2016-02-27T18:49:49+00:00

During resolving of an entry or inode, if inode ctx
was not set, we will send a lookup to pupulate inode
ctx for every xlators

This patch also make sure that inode_ctx will be created
after every inode_link. We will store inode_ctx value as
LOOKUP_NEEDED if the inode is liked via readdirp, in all
other case we will store inode_ctx value as LOOKUP_NOT_NEEDED.

Back port of>
>Change-Id: I3a10c298944200fa3862127187ae8988e582d352
>BUG: 1297311
>Signed-off-by: Mohammed Rafi KC 
>Reviewed-on: http://review.gluster.org/13226
>Reviewed-by: Poornima G 
>Tested-by: NetBSD Build System 
>Reviewed-by: Shyamsundar Ranganathan 
>Reviewed-by: Dan Lambright 
>Tested-by: Dan Lambright 

Change-Id: Ifeabb5611fcaa3c41404f0cdc48a680a16600e68
BUG: 1306131
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/13414
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Poornima G 
Reviewed-by: Dan Lambright

gfapi : fixing listxattr call for handle ops

2016-02-25T19:58:02+00:00

Currently listxattr is called as part of glfs_h_getxattrs() when NULL is
passed to name field, but glfs_h_getxattrs_common() inside it will error
out if name is NULL. Therefore listxattr is broken for handle ops.

Upstream reference
>Change-Id: I9ced6e33525e1e1a50298972e4922c954fc2b223
>BUG: 1310620
>Signed-off-by: Jiffin Tony Thottan 
>Reviewed-on: http://review.gluster.org/13482
>Reviewed-by: Niels de Vos 
>Smoke: Gluster Build System 
>NetBSD-regression: NetBSD Build System 
>CentOS-regression: Gluster Build System 
>(cherry picked from commit 0bc54f3ea7a56040df4a67b8626200b47fa3d779)

Change-Id: Ib88c12e5c2a1841e96a65e672f40b44ac9f491a9
BUG: 1311411
Signed-off-by: Jiffin Tony Thottan 
Reviewed-on: http://review.gluster.org/13504
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY

api: Fix errno being set to EINVAL even on success

2016-02-23T12:48:46+00:00

BUG: 1296007
Change-Id: I7905ac70a537f23e1844c097a24eaa6cb762fb82
Signed-off-by: Prashanth Pai 
Reviewed-on: http://review.gluster.org/12909
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Kaushal M 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-on: http://review.gluster.org/13179
Smoke: Gluster Build System 
NetBSD-regression: NetBSD Build System 
CentOS-regression: Gluster Build System 
Reviewed-by: Niels de Vos

Upcall: Read gfid from iatt in case of invalid inode

2015-12-03T22:52:37+00:00

When any file/dir is looked upon for the first time, inode
created shall be invalid till it gets linked to the inode table.
In such cases, read the gfid from the iatt structure returned
as part of such fops for UPCALL processing.

This is backport of the below patch
 - http://review.gluster.org/12773

Change-Id: Ie5eb2f3be18c34cf7ef172e126c9db5ef7a8512b
BUG: 1287079
Signed-off-by: Soumya Koduri 
Reviewed-on: http://review.gluster.org/12773
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/12839
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System

libgfapi: To support set_volfile-server-transport type "unix"

2015-12-02T09:19:54+00:00

This patch helps libgfapi to get the volfile using Unix domain socket.
run the attachment file in the bug to test.
The patch checks if the glfs_set_volfile_server transport is of type "unix",
If It is then uses rpc_transport_unix_options_build to get the volfile.

Signed-off-by: Mohamed Ashiq 
Signed-off-by: Humble Devassy Chirammal 

>Change-Id: Ifd5d1e7c0d8cc9a906c3c3355b8977141e892a2f
>BUG: 1279739
>Signed-off-by: Mohamed Ashiq 
>Signed-off-by: Humble Devassy Chirammal 
>Reviewed-on: http://review.gluster.org/12563
>Tested-by: NetBSD Build System 
>Tested-by: Gluster Build System 
>Reviewed-by: Niels de Vos 
>Reviewed-by: Poornima G 
>Reviewed-by: Raghavendra Talur 
>Reviewed-by: Shyamsundar Ranganathan 

Change-Id: I0b3f2023e6698366d8c20d6574f5de7b8a641f30
BUG: 1283038
Reviewed-on: http://review.gluster.org/12645
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

gfapi: xattr key length check to avoid brick crash

2015-11-09T12:07:54+00:00

Added check to test if xattr key length > max allowed for OS
distribution and return:
EINVAL if xattr name pointer is NULL or 0 length
ENAMETOOLONG if xattr name length > max allowed for distribution

Function exit path for invalid input is via label "out:" for
mandatory __GLFS_EXIT_FS.

Typically the VFS does this in the kernel for us.  But since we are
bypassing the VFS by providing the libgfapi to talk directly to the
brick process, we need to add such checks.

Change-Id: I610a8440871200ae4640351902b752777a3ec0c2
BUG: 1272926
Signed-off-by: Milind Changire 
Reviewed-on: http://review.gluster.org/12207
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Tested-by: NetBSD Build System 
(cherry picked from commit 47d8d2fc9c88c95dfcae2c5c06e6eb3b1ce03a92)
Reviewed-on: http://review.gluster.org/12387
Reviewed-by: Kaleb KEITHLEY

libgfapi : port missing gf_log's to gf_msg

2015-09-01T05:30:50+00:00

        Backport of http://review.gluster.org/#/c/11891/

Cherry-picked from commit 1e0644031c7ac0fa28f0912e951a9238f7bbe8ab
> Change-Id: I0c5320c09b4a5ff1e9df61a86ac7bd47c1bb1bbb
> BUG: 1252807
> Signed-off-by: Manikandan Selvaganesh 
> Reviewed-on: http://review.gluster.org/11891
> Tested-by: NetBSD Build System 
> Reviewed-by: Raghavendra Talur 
> Reviewed-by: jiffin tony Thottan 
> Reviewed-by: Humble Devassy Chirammal 
> Reviewed-by: Raghavendra G 

Change-Id: I0c5320c09b4a5ff1e9df61a86ac7bd47c1bb1bbb
BUG: 1258406
Signed-off-by: Manikandan Selvaganesh 
Reviewed-on: http://review.gluster.org/12063
Tested-by: NetBSD Build System 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G