glusterfs.git/api, branch bug-deprecated

api: versioned symbols in libgfapi.so for compatibility

2015-01-09T17:34:04+00:00

Use versioned symbols to keep libgfapi at libgfapi.so.0.0.0

Revisited to address broken build on Mac OS X

See http://review.gluster.org/9036

Rebased to include http://review.gluster.org/#/c/9376/ (glfs_resolve())
but note that gerrit's "Rebase Change" couldn't do it.

N.B. noticed that glfs_get_volumeid() decl in glfs.h was missing
the __THROW, added it.

On systems using ELF and the GNU toolchain, symbol versions are created
with a .symver asm operand in the .c source file. Clang is claimed to
be compatible with gcc, so we'll pretend for now that this also works
with clang.

On Mac OS X, aliases are created with __asm "magic" in the .h header
file. In the normal case, when both the decl and defn match, that's
all that's needed. In our case though the decl and defn don't match ---
we have, e.g. a defn such as 'int glfs_foo(...)' and the corresponding
decl is 'int pub_glfs_foo(...)'. To make this work we create the necessary
aliases in the library at link time with the -alias_list link option.

Note that this results in there being pairs of symbols in the .dylib,
e.g. _pub_glfs_foo and _glfs_foo$GFAPI_3.4.0. We could use another
link option, -unexported_symbols_list to elide the _pub_glfs_* symbols.
(And we probably should.)

Linux symbol versioning was essentially copied from Solaris; in general
I would expect this to "just work" on Solaris, but until someone tries
we don't really know.

Change-Id: Icb96a3c2d80be7b6d7a6849bb9168f03a947f47c
BUG: 1160709
Signed-off-by: Kaleb S. KEITHLEY

api: export glfs_resolve()

2015-01-06T17:14:16+00:00

glfs_resolve() is an internal function in libgfapi. Export it so that it can be
used by glfs-heal.c. The change is done in line with the approach followed in
commit 7e497871d11a3a527e2ce192e4274322631f27d0 (http://review.gluster.org/9036)

This patch [2/3] is required as a part of afr automated split-brain resolution
implementation.

Change-Id: If9057f2a037fd25a0dfa231683bfbaa72d3cb1b2
BUG: 1136769
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/9376
Reviewed-by: Niels de Vos 
Reviewed-by: Shyamsundar Ranganathan 
Tested-by: Shyamsundar Ranganathan

libglusterfs: change signature of syncop_(f)getxattr

2015-01-06T06:00:09+00:00

Pass xdata dict to syncop_(f)getxattr calls.

This patch [1/3] is required as a part of afr automated split-brain resolution
implementation.

Change-Id: I3970b3dd6daf64681a031e37f8e9afb14fb3d668
BUG: 1136769
Signed-off-by: Ravishankar N 
Reviewed-on: http://review.gluster.org/9375
Reviewed-by: Pranith Kumar Karampuri 
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Vijay Bellur

gfapi: always close the fd in glfs_h_creat()

2014-12-20T10:20:56+00:00

When running stress and performance tests against nfs-ganesha, the
number of open file descriptors increases continously. If the tests run
long enough, the brick processes will eventually run out of file
descriptors.

This seems to be caused by glfs_h_creat() which allocates a 'struct
glfs_fd', but does not release it. A normal glfs_creat() returns the
file descriptor to the application, whereas glfs_h_creat() returns a
handle (struct glfs_object). The file descriptor associated with the
handle can not be release by glfapi-applications.

This fd-leak can be prevented by destroying the 'struct glfs_fd' before
returning the 'struct gfls_object' to the gfapi-application.

Change-Id: I32465077a35cd0449a8e584c53899b32f022e5af
BUG: 1176242
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/9318
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Shyamsundar Ranganathan 
Tested-by: Gluster Build System

gfapi: use different name for GETSPEC callback than the one used by glusterfsd

2014-12-15T15:21:38+00:00

Change-Id: Ibd5be1e1080f9da4ac1fb9112538b3320ef2ff28
BUG: 1174205
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/9277
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Atin Mukherjee 
Reviewed-by: Shyamsundar Ranganathan

api, glusterfsd: Cleanup upon failure in glusterfs_ctx_defaults_init()

2014-12-10T04:11:17+00:00

This got introduced due to 656711d935000c16. Coverity
also picked this up as CIDs 1256176, 1256178, 1256180.

Signed-off-by: Vijay Bellur 
Change-Id: If12fa0075634383975846181917a2f9650f790e3
BUG: 789278
Reviewed-on: http://review.gluster.org/9213
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Shyamsundar Ranganathan

gfapi: new inode created in glfs_resolve_component even if inode is in inode table

2014-12-08T15:32:46+00:00

problem: USS allows split-brain file to be accessed while main volume
         gives I/O error.

cause:
        AFR detects split-brain on lookup. It stores this information in
        inode context. open and readv fop checks this flag from inode context.
        open and readv fop fails if split-brain flag is set for the file.

        USS uses gfapi to access snapshot volume. During open call
        gfapi internally calls glfs_resolve_component. glfs_resolve_component
        generates a new inode even if inode is present for the file.
        Because of which afr_lookup acts on a new inode which does not
        contain the split-brain flag.

Bug: 1171615

Change-Id: I1b4fddf4bd3c734a319ecfae804a3439866d157c
Signed-off-by: Rajesh Joseph 
Reviewed-on: http://review.gluster.org/9253
Reviewed-by: Vijaikumar Mallikarjuna 
Reviewed-by: Raghavendra Talur 
Reviewed-by: Poornima G 
Reviewed-by: Pranith Kumar Karampuri 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos

libgfapi: Wait for GF_EVENT_CHILD_DOWN in glfs_fini()

2014-12-08T09:54:45+00:00

Whenever glfs_fini() is being called, currently no
check is made inside the function to determine whether
the child is already down or not. This patch will wait
for GF_EVENT_CHILD_DOWN for the active subvol and
then exits.

TBD:
Apart from the active subvol, wait for other CHILD_DOWN
events generated through operations like volume set in
future.

Change-Id: I81c64ac07b463bfed48bf306f9e8f46ba0f0a76f
BUG: 1153610
Signed-off-by: Anoop C S 
Reviewed-on: http://review.gluster.org/9060
Reviewed-by: Shyamsundar Ranganathan 
Tested-by: Gluster Build System 
Reviewed-by: Raghavendra G 
Reviewed-by: Niels de Vos

core: fix remaining *printf formation warnings on 32-bit

2014-11-26T08:26:53+00:00

This fixes a few lingering size_t problems. Of particular note are
some uses of off_t for size params in function calls.

There is no correct, _portable_ way to correctly print an off_t. The
best you can do is use a scratch int64_t/PRId64 or uint64_t/PRIu64.

Change-Id: I86f3cf4678c7dbe5cad156ae8d540a66545f000d
BUG: 1110916
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/8105
Tested-by: Gluster Build System 
Reviewed-by: Harshavardhana 
Reviewed-by: Raghavendra Bhat 
Reviewed-by: Niels de Vos 
Reviewed-by: Vijay Bellur

mem_acct : Check return value of xlator_mem_acct_init().

2014-11-15T18:13:06+00:00

some code does not check xlator_mem_acct_init() 
return, thus fails to capture wrong memory accounting
initialization. This patch fix the same.

Change-Id: I01eab19d6cef472afd850b0f964132c01523492a
BUG: 1123768
Signed-off-by: Humble Chirammal 
Reviewed-on: http://review.gluster.org/7728
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Kaleb KEITHLEY