glusterfs.git/api, branch v3.4.0beta2

gfapi: dict_unref() xattr_req in fop finish instead of dict_destroy()

2013-03-08T03:53:41+00:00

The current way of calling dict_destroy() at the end of an API fop assumes
that xattr_req is not stored/ref'd by any translators in the stack. However
when translators like DHT store xattr_req in dht_local_t with a dict_ref()
and perform dict_unref() in the unwind path, things get subject to a race.

The race is between the woken up thread (by syncop_wake) i.e, the gfapi
invoking thread and the thread where the FOP was unwound. As the C stack
of STACK_UNWIND unwinds back, dht_local_unref() gets invoked within the
DHT_STACK_UNWIND macro. This thread attempts dict_unref, which would
be "safe" if it wins the race against the gfapi invoking thread. However
if the gfapi invoking thread wins the race, it will perform dict_destroy()
first and therefore make dict_unref() within dht_local_unref perform
a double free.

This is the embarrassing on-screen bug which showed up in a roomful of people
during the gluster dev summit demo of qemu/libgfapi integration.

Change-Id: I284c93de87cdc128d5801f42c84aa87f753090d4
BUG: 839950
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/4645
Tested-by: Gluster Build System

Better mechanism to handle memory accounting

2013-03-03T14:18:59+00:00

Memory accounting will now be enabled if:

1) Any glusterfs process is spawned with argument --mem-accounting.
2) DEBUG is defined.

Change-Id: I3345e114127a57ce61916be0e2c4e0049a4c3432
BUG: 834465
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/4527
Reviewed-by: Raghavendra Bhat 
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy

Use proper libtool option -avoid-version instead of bogus -avoidversion

2013-02-07T23:12:56+00:00

Change-Id: I1c9541058c7d07786539a3266ca125a6a15287d8
BUG: 859835
Signed-off-by: Anand Avati 
Original-author: Kacper Kowalik (Xarthisius) 
Signed-off-by: Kacper Kowalik (Xarthisius) 
Reviewed-on: http://review.gluster.org/3967
Tested-by: Gluster Build System

glusterd,glusterfsd,libgfapi: Client op-version

2013-02-06T20:17:06+00:00

This patch introduces op-version support for glusterfs clients.
Now, a client sends its supported op-versions during the volfile fetch request
and glusterd will return the volfile only if the client can support the current
op-version of the cluster.

Change-Id: Iab1f1f1706802962bcf27058657c44e8a344d2f6
BUG: 907311
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/4247
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Anand Avati

gfapi: Mark fs->init status done in glfs_init_done for the case of glfs_init_async.

2013-02-03T20:11:31+00:00

This seen when we call glfs_init_async. The glfs_init_done function,
calls the call-back function without assigning 1 to fs->init. The problem
occurs when we call glfs_read or a similar api next time which checks if
fs->init is 1 and will enter into an infinite wait if it is zero.

Change-Id: I34a3d1652c80e737f5b05082a3fbb6e5978b14cd
BUG: 839950
Signed-off-by: Mohammed Junaid 
Reviewed-on: http://review.gluster.org/4445
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

core: fixes for gcc's '-pedantic' flag build

2013-01-22T06:17:36+00:00

* warnings on 'void *' arguments
* warnings on empty initializations
* warnings on empty array (array[0])

Change-Id: Iae440f54cbd59580eb69f3ecaed5a9926c0edf95
BUG: 875913
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4219
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

core: remove all the 'inner' functions in codebase

2012-12-20T07:35:29+00:00

* move 'dict_keys_join()' from api/glfs_fops.c to libglusterfs/dict.c
  - also added an argument which is treated as a filter function if
    required, currently useful for fuse.

* now 'make CFLAGS="-std=gnu99 -pedantic" 2>&1 | grep nested' gives
  no output.

Change-Id: I4e18496fbd93ae1d3942026ef4931889cba015e8
Signed-off-by: Amar Tumballi 
BUG: 875913
Reviewed-on: http://review.gluster.org/4187
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

api: update Python wrapper

2012-12-20T03:16:51+00:00

This brings us back to functional parity with the C example, and also makes
things more "Pythonic" (e.g. methods on Volume/File objects instead of bare
functions).

Change-Id: I46edfee46d91881e275de2f63e15d9f0a6448e80
BUG: 839950
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/4286
Tested-by: Gluster Build System 
Reviewed-by: Peter Portante 
Reviewed-by: Anand Avati

libgfapi: "tcp" is documented as the valid transport type instead of "socket".

2012-11-29T00:24:41+00:00

Change-Id: I066e9be7755a535f385c102cdd1822adeda7f319
BUG: 860203
Signed-off-by: Avra Sengupta 
Reviewed-on: http://review.gluster.org/4226
Reviewed-by: Jeff Darcy 
Tested-by: Gluster Build System

api/examples: updated examples to use new calls

2012-11-05T13:53:56+00:00

Change-Id: I865d0c52de268b27bbdb8786d3f4af5ef3ce3d9a
BUG: 839950
Signed-off-by: Anand Avati 
Reviewed-on: http://review.gluster.org/4023
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi 
Reviewed-by: Vijay Bellur