glusterfs.git/cli/src/cli-cmd-volume.c, branch v7.1

glusterd/thin-arbiter: Thin-arbiter integration with GD1

2019-07-04T07:42:11+00:00

gluster volume create  replica 2 thin-arbiter 1 : :
: [force]

The changes have been made in a way that the last brick in the bricks list
will be treated as the thin-arbiter.
GD1 will be manipulated to consider replica count to be as 2 and continue creating the
volume like any other replica 2 volume but since thin-arbiter volumes need ta-brick
client xlator entries for each subvolume in fuse volfile, volfile generation is
modified in a way to inject these entries seperately in the volfile for every subvolume.

Few more additions -
1- Save the volinfo with new fields ta_bricks list and thin_arbiter_count.
2- Introduce a new option client.ta-brick-port to add remote-port to ta-brick xlator entry
   in fuse volfiles. The option can be set using the following CLI syntax -
   gluster volume set  client.ta-brick-port 
3- Volume Info will contain a Thin-Arbiter-path entry to distinguish
   from other replicate volumes.

Change-Id: Ib434e2313b29716f32476c6c211d282c4ef39406
Updates #687
Signed-off-by: Vishal Pandey 
(cherry picked from commit 9b223b15ab69fce4076de036ee162f36a058bcd2)

cli: Remove-brick warning seems unnecessary

2019-06-12T16:08:19+00:00

As force-migration option is disabled by default,
the warning seems unnessary.

Rephrased the warning to make best sense out of it.

fixes: bz#1712668
Change-Id: Ia18c3c5e7b3fec808fce2194ca0504a837708822
Signed-off-by: Shwetha K Acharya

geo-rep: Geo-rep help text issue

2019-05-23T15:25:25+00:00

Modified Geo-rep help text for better sanity.

fixes: bz#1652887

Change-Id: I40ef7ef709eaecf0125ab4b4a7517e2c5d1ef4a0
Signed-off-by: Shwetha K Acharya

cli: Validate invalid slave url

2019-05-11T11:09:06+00:00

This patch validates the invalid slave url
in cli itself and throws appropriate error.

fixes: bz#1098991
Change-Id: I278e2a04a4d619d2c2d1db0dd56ab5bdf7e7f469
Signed-off-by: Kotresh HR

tier/cli: remove tier code to increase code coverage in cli

2019-04-25T10:38:20+00:00

Change-Id: I56cc09243dab23b3be86a7faac45001dda77181f
updates: bz#1693692
Signed-off-by: Sanju Rakonde

Multiple files: remove HAVE_BD_XLATOR related code.

2019-03-25T05:34:50+00:00

The BD translator was removed some time ago,
(in commit a907e468e724c32b9833ce59806fc215c7122d63).
This completes the work.

Compile-tested only!
updates: bz#1635688
Signed-off-by: Yaniv Kaul 

Change-Id: I999df52e479a72d3cc9523f22f9056de17eb559c

cli : fix mem leak during cli_cmd_volume_gsync_set_cbk

2019-02-19T04:09:33+00:00

This patch fixes mem-leak due to excessive use of gf_asprintf
to form dynamic growing string.

Problem: each call to asprintf/vsprintf for extending existing string causes
         a memory leak, because the blob at the original address of existing
         string is not freed and a new location is generated by asprintf.

Tracebacks:
    #2 0x7fdf191b8b3b in gf_vasprintf ../libglusterfs/src/mem-pool.c:236
    #3 0x7fdf191b8d0a in gf_asprintf ../libglusterfs/src/mem-pool.c:256
    #4 0x420cd3 in cli_cmd_volume_gsync_set_cbk ../cli/src/cli-cmd-volume.c:2576

SUMMARY: AddressSanitizer: 255 byte(s) leaked in 3 allocation(s).
....
SUMMARY: AddressSanitizer: 431 byte(s) leaked in 4 allocation(s).
....
SUMMARY: AddressSanitizer: 449 byte(s) leaked in 4 allocation(s).
....
SUMMARY: AddressSanitizer: 397 byte(s) leaked in 4 allocation(s).
....
SUMMARY: AddressSanitizer: 160 byte(s) leaked in 2 allocation(s).
....

updates: bz#1633930
Change-Id: I7e8902f0ed23e640dc17e3dcbdab7ae0579d2dc6
Signed-off-by: Sunny Kumar

cli: Added the group option for volume set

2019-02-04T12:56:00+00:00

gluster volume set  group  is used for setting multiple
pre-defined volume options, but this was undocumented. This patch doc-
ments this feature.

fixes: bz#1243991

Change-Id: Id346cf2537f85179caff32479f09555ce2e72e76
Signed-off-by: Rinku Kothiya

libglusterfs/src/mem-types.h: remove unused common enums from mem-types.h

2018-12-30T11:59:27+00:00

They were not used at all, just taking space.
I've also marked all those that are not common really, but used
in just one place - they probably should move there (in follow-up
patches)

As a test, I've removed from the stripe xlator unused private
enums and moved one that was in the common list, but only
used in the stripe code, to be a private enum.

Compile-tested only!

updates: bz#1193929
Signed-off-by: Yaniv Kaul 
Change-Id: I1158dc1d259f1fd3f69904336c46c9d83cea799f

cli: variable-length array declaration clang fix

2018-12-14T04:38:23+00:00

Problem: Declared variable-length array can have zero size

Added a goto statement to address this issue.

Updates: bz#1622665

Change-Id: Ibf80643490367a5f7e50f66f87e4296380be45de
Signed-off-by: Sheetal Pamecha