glusterfs.git/cli/src/cli-rpc-ops.c, branch v3.3.2qa1

localtime and ctime are not MT-SAFE

2013-02-08T20:04:42+00:00

There are a number of nit-level issues throughout the source with
the use of localtime and ctime. While they apparently aren't causing
too many problems, apart from the one in bz 828058, they ought to be
fixed. Among the "real" problems that are fixed in this patch:
1) general localtime and ctime not MT-SAFE. There's a non-zero chance
   that another thread calling localtime (or ctime) will over-write
   the static data about to be used in another thread
2) localtime(& <64-bit-type>) or ctime(& <64-bit-type>) generally
   not a problem on 64-bit or little-endian 32-bit. But even though
   we probably have zero users on big-ending 32-bit platforms, it's
   still incorrect.
3) multiple nested calls passed as params. Last one wins, i.e. over-
   writes result of prior calls.
4) Inconsistent error handling. Most of these calls are for logging,
   tracing, or dumping. I submit that if an error somehow occurs in
   the call to localtime or ctime, the log/trace/dump still should
   still occur.
5) Appliances should all have their clocks set to UTC, and all log
   entries, traces, and dumps should use GMT.
6) fix strtok(), change to strtok_r()

Other things this patch fixes/changes (that aren't bugs per se):
1) Change "%Y-%m-%d %H:%M:%S" and similar to their equivalent shorthand,
   e.g. "%F %T"
2) change sizeof(timestr) to sizeof timestr. sizeof is an operator,
   not a function. You don't use i +(32), why use sizeof().
   (And yes, you do use parens with sizeof().)
3) change 'char timestr[256]' to 'char timestr[32]' where appropriate.
   Per-thread stack is limited. Time strings are never longer than ~20
   characters, so why waste 220+ bytes on the stack?

Things this patch doesn't fix:
1) hodgepodge of %Y-%m-%d %H:%M:%S versus %Y/%m/%d-%H%M%S and other
   variations. It's not clear to me whether this ever matters, not to
   mention 3rd party log filtering tools may already rely on a
   particular format. Still it would be nice to have a single manifest
   constant and have every call to localtime/strftime consistently use
   the same format.

BUG: 832173

Change-Id: Iee9719db4576eacc6c75694d9107954d0912cba8
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/3613
Reviewed-by: Anand Avati 
Tested-by: Anand Avati

cli: Proper xml output for "gluster peer status"

2012-08-30T10:37:40+00:00

Change-Id: I90952ba2ea606552cf4ad67dd296a440f90592d6
BUG: 847760
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.org/3870
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cli/: Displaying the size in human readable format

2012-08-21T03:41:29+00:00

rebalance status displaying the size in bytes. Converted to
human readable

Change-Id: Id73b6e792c39b85480ddf1dc9c0c22fcaca29530
BUG: 825193
Signed-off-by: Varun Shastry 
Reviewed-on: http://review.gluster.org/3810
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M

calls to dict_allocate_and_serialize() are not 64-bit clean

2012-08-03T10:54:50+00:00

All calls to dict_allocate_and_serialize() pass the address of a 32-bit
type, but must cast it to the 64-bit pointer type (size_t *).

This happens to work on LE machines, but even if it's apparently benign,
it's still a bug. On BE machines it is not benign.

GF_PROTOCOL_DICT_SERIALIZE() hacks around it by creating a size_t temp
var, but that's, well, a hack, IMO when you consider that all the callers
are actually passing &; the param should just be a u_int * and
eliminate the buggy casts and the temp var in the macro.

Nobody apparently uses the Fedora/EPEL PPC RPMs, but they might. People
are trying to build gluster.org bits on SPARC and tripping over this.

Change-Id: I92ea139f9e3e91ddbbb32a51b96fa582a9515626
Signed-off-by: Kaleb S. KEITHLEY 
BUG: 838928
Reviewed-on: http://review.gluster.com/3643
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cli: Change cli output for heal commands

2012-08-02T06:28:32+00:00

BUG: 826406
Change-Id: Ic32c89b92314ee201ec67afc4617e412d4b4c21d
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3636
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cli: Fix time_t conversions

2012-06-13T15:28:01+00:00

Change-Id: I98eb76e5971ea800a249d21557d5dd4f093fdaaf
BUG: 828058
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3534
Reviewed-by: Kaleb KEITHLEY 
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Tested-by: Joe Julian 
Reviewed-by: Joe Julian 
Reviewed-by: Vijay Bellur

Self-heald: Print the time stamp of the event-history

2012-05-18T06:30:31+00:00

BUG: 796579
Change-Id: I4c738d9073b53fc3c4d4797b5f01e841dae1b4e9
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.com/3352
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

cli: fix remove-brick output behavior in failure cases

2012-05-04T04:28:37+00:00

earlier it was dependant on server sending the dict for knowing
the command. Now it preserves the dictionary in frame->local,
which is used to understand the command.

Change-Id: Ica675b497e466f77878f67792ae96b71f0704d6b
Signed-off-by: Amar Tumballi 
BUG: 815745
Reviewed-on: http://review.gluster.com/3235
Tested-by: Gluster Build System 
Reviewed-by: Shishir Gowda

cli: Make use of cli_err()

2012-04-27T05:50:38+00:00

Use cli_err() in case of errors instead of cli_out().

Change-Id: Ib0766e59516a1ccd56a2133f33fac3877c4384d6
BUG: 815194
Signed-off-by: Kaushal M 
Reviewed-on: http://review.gluster.com/3229
Tested-by: Gluster Build System 
Reviewed-by: Amar Tumballi

cli: implement a fn 'cli_err()' to send error messages to 'stderr'

2012-04-25T07:45:51+00:00

we were using 'cli_out()' to send all the possible msgs, which is not
very friendly with scripts, because if one want to get only valid
output with " 2>/error.log 1>/proper-info.log"

Change-Id: I008ebcbd90935c41dbfc1bd2adeb094ed21116cb
Signed-off-by: Amar Tumballi 
BUG: 815194
Reviewed-on: http://review.gluster.com/3208
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M 
Reviewed-by: Vijay Bellur