glusterfs.git/cli, branch bug-deprecated

cli: logging improvements

2015-01-06T04:08:58+00:00

1. cli used to log messages at all log levels. This is related to
a peculiar behavior of gcc which treats any enum variable whose type
has non-negative only defined values to be an unsigned integer.
This would cause cli's loglevel (defaulted from state->loglevel) to be
set as (uint)-1 previously and hence all log messages across
levels would appear in the cli log file. Now cli's loglevel defaults to
log level INFO.

2. Changed logging level of messages of type "Returning %d".. to DEBUG.

Change-Id: I05094e523fc277d9ad32cc9d76aee873c0fd3859
BUG: 1168809
Signed-off-by: Vijay Bellur 
Reviewed-on: http://review.gluster.org/9383
Reviewed-by: Atin Mukherjee 
Reviewed-by: Raghavendra Bhat 
Tested-by: Gluster Build System 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

core: fix Ubuntu code audit (cppcheck) results

2014-11-25T17:27:36+00:00

See also http://review.gluster.org/#/c/7693/, BZ 1091677

AFAICT these are false positives:

[geo-replication/src/gsyncd.c:100]: (error) Memory leak: str
[geo-replication/src/gsyncd.c:403]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1201]: (error) Possible null pointer dereference: fde
[xlators/cluster/afr/src/afr-self-heal-common.c:138]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:140]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:331]: (error) Possible null pointer dereference: __ptr

Test program:

[extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.
[tests/basic/fops-sanity.c:55]: (error) Buffer overrun possible for long command line arguments.

the remainder are fixed with this change-set:

[cli/src/cli-rpc-ops.c:8883]: (error) Possible null pointer dereference: local
[cli/src/cli-rpc-ops.c:8886]: (error) Possible null pointer dereference: local
[contrib/uuid/gen_uuid.c:369]: (warning) %ld in format string (no. 2) requires 'long *' but the argument type is 'unsigned long *'.
[contrib/uuid/gen_uuid.c:369]: (warning) %ld in format string (no. 3) requires 'long *' but the argument type is 'unsigned long *'.
[xlators/cluster/dht/src/dht-rebalance.c:1734]: (error) Possible null pointer dereference: ctx
[xlators/cluster/stripe/src/stripe.c:4940]: (error) Possible null pointer dereference: local
[xlators/mgmt/glusterd/src/glusterd-geo-rep.c:1718]: (error) Possible null pointer dereference: command
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:942]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-replace-brick.c:1026]: (error) Resource leak: file
[xlators/mgmt/glusterd/src/glusterd-sm.c:249]: (error) Possible null pointer dereference: new_ev_ctx
[xlators/mgmt/glusterd/src/glusterd-snapshot.c:6917]: (error) Possible null pointer dereference: volinfo
[xlators/mgmt/glusterd/src/glusterd-utils.c:4517]: (error) Possible null pointer dereference: this
[xlators/mgmt/glusterd/src/glusterd-utils.c:6662]: (error) Possible null pointer dereference: this
[xlators/mgmt/glusterd/src/glusterd-utils.c:7708]: (error) Possible null pointer dereference: this
[xlators/mount/fuse/src/fuse-bridge.c:4687]: (error) Uninitialized variable: finh
[xlators/mount/fuse/src/fuse-bridge.c:3080]: (error) Possible null pointer dereference: state
[xlators/nfs/server/src/nfs-common.c:89]: (error) Dangerous usage of 'volname' (strncpy doesn't always null-terminate it).
[xlators/performance/quick-read/src/quick-read.c:586]: (error) Possible null pointer dereference: iobuf

Rerunning cppcheck after fixing the above:

As before, test program:

[extras/test/test-ffop.c:27]: (error) Buffer overrun possible for long command line arguments.
[tests/basic/fops-sanity.c:55]: (error) Buffer overrun possible for long command line arguments.

As before, false positive:

[geo-replication/src/gsyncd.c:100]: (error) Memory leak: str
[geo-replication/src/gsyncd.c:403]: (error) Memory leak: argv
[xlators/nfs/server/src/nlm4.c:1201]: (error) Possible null pointer dereference: fde
[xlators/cluster/afr/src/afr-self-heal-common.c:138]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:140]: (error) Possible null pointer dereference: __ptr
[xlators/cluster/afr/src/afr-self-heal-common.c:331]: (error) Possible null pointer dereference: __ptr

False positive after fix:

[xlators/performance/quick-read/src/quick-read.c:584]: (error) Possible null pointer dereference: iobuf

Change-Id: I20e0e3ac1d600b2f2120b8d8536cd6d9e17023e8
BUG: 1109180
Signed-off-by: Kaleb S. KEITHLEY 
Reviewed-on: http://review.gluster.org/8064
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

rdma:Removing RDMA tech preview cli message.

2014-11-21T12:49:17+00:00

Creation of rdma and tcp,rdma volume will display a
warning message since it was in tech preview. This
patch will remove the warning message during the
volume creation.

Change-Id: I54f46097073bcb5a757ab047f540cd9b92553897
BUG: 1164079
Signed-off-by: Mohammed Rafi KC 
Reviewed-on: http://review.gluster.org/9141
Tested-by: Gluster Build System 
Reviewed-by: jiffin tony Thottan 
Reviewed-by: Raghavendra Talur 
Reviewed-by: Raghavendra G 
Tested-by: Raghavendra G

mem_acct : Check return value of xlator_mem_acct_init().

2014-11-15T18:13:06+00:00

some code does not check xlator_mem_acct_init() 
return, thus fails to capture wrong memory accounting
initialization. This patch fix the same.

Change-Id: I01eab19d6cef472afd850b0f964132c01523492a
BUG: 1123768
Signed-off-by: Humble Chirammal 
Reviewed-on: http://review.gluster.org/7728
Tested-by: Gluster Build System 
Reviewed-by: Niels de Vos 
Reviewed-by: Kaleb KEITHLEY

glusterd/snapshot: Snapshot should be deactivated when it is created

2014-11-12T12:36:11+00:00

By default snapshot should be deactivated and this should be a
configurable option.

This behaviour can be configured by the command below:
gluster snapshot config activate-on-create 

Change-Id: I1911595c32beed43bb2fca4bf99f0d264b422513
BUG: 1157991
Signed-off-by: vmallika 
Reviewed-on: http://review.gluster.org/8985
Tested-by: Gluster Build System 
Reviewed-by: Avra Sengupta 
Reviewed-by: Rajesh Joseph 
Reviewed-by: Kaushal M

cli: for rpc timeout throw a time out message

2014-11-11T06:43:31+00:00

Change-Id: I9660df1c3b2707583bd95806011b650cd1a2df1b
BUG: 1161037
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9017
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M

glusterd : release cluster wide locks in op-sm during failures

2014-11-06T11:03:55+00:00

glusterd op-sm infrastructure has some loophole in handing error cases in
locking/unlocking phases which ends up having stale locks restricting
further transactions to go through.

This patch still doesn't handle all possible unlocking error cases as the
framework neither has retry mechanism nor the lock timeout. For eg - if
unlocking fails in one of the peer, cluster wide lock is not released and
further transaction can not be made until and unless originator node/the node
where unlocking failed is restarted.

Following test cases were executed (with the help of gdb) after applying this
patch:

* RPC timesout in lock cbk
* Decoding of RPC response in lock cbk fails
* RPC response is received from unknown peer in lock cbk
* Setting peerinfo in dictionary fails while sending lock request for first peer
  in the list
* Setting peerinfo in dictionary fails while sending lock request for other
  peers
* Lock RPC could not be sent for peers

For all above test cases the success criteria is not to have any stale locks

Change-Id: Ia1550341c31005c7850ee1b2697161c9ca04b01a
BUG: 1154635
Signed-off-by: Atin Mukherjee 
Reviewed-on: http://review.gluster.org/9012
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M

gluster --xml: survive missing fields

2014-10-31T16:51:25+00:00

Do not fail gluster --xml volume status detail with an empty output
if some field is missing.

Required for NetBSD to pass tests/bugs/bug-861542.t

BUG: 1129939
Change-Id: I7e2097dee5e18a5f3bb8fe6f14be53b33f4aa6b1
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/9024
Tested-by: Gluster Build System 
Reviewed-by: Kaushal M

CLI: Show warning message only for remove-brick commit

2014-10-29T12:46:11+00:00

Earlier warning message for checking the removed-bricks for
any unmigrated files was thrown both for remove-brick commit
and force.

With this change the warning message will be shown only for
remove-brick commit.

Change-Id: Ib1fa47d831d5189088c77c5cf709a25ff36d7379
BUG: 1157974
Signed-off-by: Susant Palai 
Reviewed-on: http://review.gluster.org/8983
Reviewed-by: Atin Mukherjee 
Tested-by: Gluster Build System 
Reviewed-by: Shyamsundar Ranganathan 
Reviewed-by: Kaushal M

heal: glfs-heal implementation

2014-10-15T08:22:02+00:00

Thanks a lot to Niels for helping me to get build stuff right.

Change-Id: I634f24d90cd856ceab3cc0c6e9a91003f443403e
BUG: 1147462
Signed-off-by: Pranith Kumar K 
Reviewed-on: http://review.gluster.org/6529
Reviewed-by: Krutika Dhananjay 
Tested-by: Gluster Build System