glusterfs.git/contrib, branch v3.3.2qa3

glusterfs: add gf_mkostemp api and use it instead of mkostemp of libc

2013-05-14T16:02:11+00:00

Change-Id: Ia3d2f37ae1f7a7d87a75c82bedb4963729d45b6c
BUG: 764890
Signed-off-by: Raghavendra Bhat 
Reviewed-on: http://review.gluster.org/5004
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Detect python > 2.5, make sure MKDIR_P is substituted

2012-09-10T04:10:40+00:00

gluster build machine generate configure scripts unable to detect python > 2.5
This change include a more recent python.m4 so that newer python can be
correctly detected.

Build.gluster.com also produces a configure that fails to subsitute
MKDIR_P, leading to bugs at make install. Works this around by
introducing mkdirp.m4 from aclocal-1.11, with the autoconf version test
removed because build.gluster.com also has an outdated autoconf. And
we need a bit from a recent autoconf

This is a backport of I3ffac50cc7a10cb9e56dd490dbc2b550bba3fabd

BUG: 764655
Change-Id: I5ceeed957f30af4504701d789931f407b501eeb6
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/3923
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

Add missing contrib/libgen files to distribution

2012-09-09T18:20:44+00:00

This is a backport of I3f49eb4a1a186cb2d178539ada6a05c8c1aa8265

BUG: 764655
Change-Id: I32264acec0f122d045f369a254df17b488962b9f
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.org/3884
Tested-by: Gluster Build System 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Anand Avati

Switch to GNU basename_r() and dirname_r()

2012-07-09T12:39:33+00:00

This is a backport of Change-Id Ic9a159fffdc7bacc9408f8e90854e4c2db81930c
and Id874b9c7aacd9aa3a7a4bd6a92a9633f5b2d6ac0

BUG: 764655
Change-Id: I51aac601fb4cc9a0d87afcab2240dc7a1d131c93
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.com/3576
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

NetBSD build fixes.

2012-07-05T18:28:31+00:00

This is a backport of Change-Id: Ib8183d4b585465d05a7adf3a4ceae93ae1bded15

BUG: 764655
Change-Id: I552b87b72c234b3a11af6ffd4a03975879602363
Signed-off-by: Emmanuel Dreyfus 
Reviewed-on: http://review.gluster.com/3574
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

fuse, glusterfsd: mount logic fixes

2012-05-27T16:55:47+00:00

Commit 7d0397c2 introduced two issues:

 i) broke the libfuse derived mount logic (details below)
ii) in case of a daemonized glusterfs client is ran as daemon, parent
    process can return earlier than the mount is in place, which breaks
    agents that programmatically do a gluster mount via a direct call to
    glusterfs (ie. not via mount(8)).

This patch fixes these issues by a refactor that merges the approaches
sported by commits

  7d0397c2 fuse: allow requests during mount (needed for SELinux labels)
  c5d781e0 upon daemonizing, wait on mtab update to terminate in parent

Original daemonized libfuse event flow is as follows:

  try:
    fd = open("/dev/fuse")
    mount("-oopts,fd=%s" % fd ...)
    mount(8) -f    # manipulate mtab
  except:
    sp = socketpair()
    env _FUSE_COMMFD=sp fusermount -oopts
    fd = receive_fd(sp)

  where fusermount(1) does:
    fd = open("/dev/fuse")
    mount("-oopts,fd=%d" % fd ...)
    sp = atoi(getenv("_FUSE_COMMFD"))
    send_fd(sp, fd)

  daemonize(
    # in child
    fuse_loop(fd)
  )
  # in parent
  exit()

As of 013850c9 (instead of adopting FUSE's 47e61004¹), we went for async
mtab manipulation, and as of c5d781e0, still wanted keep that in sync
with termination of daemon parent, so we changed it to:

  try:
    fd = open("/dev/fuse")
    mount("-oopts,fd=%s" % fd ...)
    pid = fork(
      # in child
      mount(8) -f
    )
  except:
    sp = socketpair()
    env _FUSE_COMMFD=sp fusermount -oopts
    fd = receive_fd(sp)

  daemonize(
    fuse_loop(fd)
  )
  waitpid(pid)
  exit()

(Note the new approch came only to direct [privileged] mount, so fusermount
based mounting was already partially broken.)

As of 7d0397c2, with the purpose of facilitating async mount, the event flow
was practically reduced to:

  fd = open("/dev/fuse")
  fork(
    mount("-oopts,fd=%s" % fd ...)
    fork(
      mount(8) -n
    )
  )

  daemonize(
    fuse_loop(fd)
  )
  exit()

Thus fusermount based mounting become defunct; however, the dead
code was still kept around. So, we should either drop it or fix
it. Also, the mtab manipulator is forked into yet another child
with no purpose, while syncing with it in daemon parent is broken.
mount(2) is neither synced with parent.

Now we are coming to the following scheme:

  fd = open("/dev/fuse")
  pid = fork(
    try:
      mount("-oopts,fd=%s" % fd ...)
      mount(8) -n
    except:
      env _FUSE_DEVFD=fd fusermount -oopts
  )

  where fusermount(1) does:
    fd = getenv("_FUSE_DEVFD")
    mount("-oopts,fd=%s" % fd ...)

  daemonize(
    fuse_loop(fd)
  )
  waitpid(pid)
  exit()

Nb.:

- We can't help losing compatibility with upstream fusermount,
  as it sends back the fd only when mount(2) is completed,
  thus defeating the async mount approach. The
  'getenv("_FUSE_DEVFD")' mechanism is specfic to glusterfs'
  fusermount (at the moment -- sure we can talk about it with
  upstream)

- fusermount opens /dev/fuse at same privilege level as of
  original process², so we can bravely go on with doing the open
  unconditionally in original process

- Original mounting code actually tries to mount through
  fusermount _twice_: if first attempt fails, then, assuming
  subtype support is missing in kernel, it tries again subtype
  stripped. However, this is redundant, as fusermount internally
  also performs the subtype check³. Therefore we simplified the
  logic to have just a single fusermount call.

- we revert the changes to mount.glusterfs as of 7d0397c2, as
  now there is no issue with glusterfs to work around in that scope

¹ http://fuse.git.sourceforge.net/git/gitweb.cgi?p=fuse/fuse;a=blobdiff;f=ChangeLog;h=47e61004;hb=4c3d9b19;hpb=e61b775a
² http://fuse.git.sourceforge.net/git/gitweb.cgi?p=fuse/fuse;a=blob;f=util/fusermount.c;h=b2e87d95#l1023
³ http://fuse.git.sourceforge.net/git/gitweb.cgi?p=fuse/fuse;a=blob;f=util/fusermount.c;h=b2e87d95#l839

Change-Id: I0c4ab70e0c5ad7b27337228749b266bcd0ba941d
BUG: 811217
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.com/3428
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

fuse: allow requests during mount (needed for SELinux labels)

2012-05-27T16:55:05+00:00

Resurrecting Jeff's commit:

  commit 7d0397c2144810c8a396e00187a6617873c94002
  Author: Jeff Darcy 

      fuse: allow requests during mount (needed for SELinux labels)

that was reverted as of:

  commit 4ab1c326f3862714b960302f06c6323d6291b695
  Author: Vijay Bellur 

      Revert "fuse: allow requests during mount (needed for SELinux labels)"

BUG: 811217
Change-Id: Ia1af402897e6a7290acf79617c34fdc804751729
Signed-off-by: Csaba Henk 
Reviewed-on: http://review.gluster.com/3452
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Revert "fuse: allow requests during mount (needed for SELinux labels)"

2012-05-11T05:18:20+00:00

This reverts commit 7d0397c2144810c8a396e00187a6617873c94002.

contrib/rbtree: additional license from Richard Fontana

2012-04-30T18:19:08+00:00

BUG: 807724
Change-Id: I1e9a7aac7b535687b9e48bdb0e94c7f52dc6aad7
Signed-off-by: Kaleb KEITHLEY 
Reviewed-on: http://review.gluster.com/3252
Tested-by: Gluster Build System 
Reviewed-by: Anand Avati

contrib/rbtree license GPL -> LGPL

2012-04-25T20:19:47+00:00

The latest source of rb.c in the avl-2.0.3 package from GNU/FSF is
now licensed under LGPL, a better license for allowing our partners
to write translators and applications for gluster.

Resubmitting with a BZ. The real question is whether this is okay with
LGPL or whether we should go all the way to a BSD-licensed implementation.

Change-Id: Ifb9c344c84d960832671a2619d37b925e4dede2d
BUG: 807724
Signed-off-by: Kaleb KEITHLEY 
Reviewed-on: http://review.gluster.com/3008
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy