glusterfs.git/extras, branch bug-deprecated

Stop logrotate from complaining about missing files.

2014-12-11T08:04:36+00:00

Previously logrotate reported errors for files missing in
"/var/log/glusterfs/geo-replication-slaves/*/*.log". Fixed by reordering
directives in the example config.

Change-Id: I7cdb9e0d82f08aa27d5e26664660204fdeb8e98e
BUG: 1170825
Signed-off-by: Jan-Hendrik Zab 
Reviewed-on: http://review.gluster.org/9264
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System 
Reviewed-by: Lalatendu Mohanty

build: only install geo-rep scripts when enabled

2014-12-07T14:16:08+00:00

When geo-replication is not enabled, the related scripts should not get
installed. EPEL-5 does not support geo-replication, and the installed
but unpackaged scripts cause rebuilding for .el5 to fail.

BUG: 1169005
Change-Id: I1b6a352b73bd1ed1c5b330f54e26e81aed9a5a4e
Reported-by: Lalatendu Mohanty 
Signed-off-by: Niels de Vos 
Reviewed-on: http://review.gluster.org/9221
Reviewed-by: Humble Devassy Chirammal 
Tested-by: Gluster Build System

extras: geo-rep: Customize the generate gfid script to dirs list

2014-11-26T08:12:18+00:00

generate-gfid-file.sh now accepts dirs list file and generate
gfids only for those dirs list.

Change-Id: Ia78a0a744dc8a079db56c38578cc6fcac2a6fa90
Signed-off-by: Aravinda VK 
Reviewed-on: http://review.gluster.org/8540
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

extras/hookscripts: Fix set behaviour for user.cifs and user.smb

2014-11-12T06:39:05+00:00

Setting either of user.cifs or user.smb to disable should disable smb
shares when the smb share is already available.

Change-Id: I213ffca9cedc14107daeb30271d1f41dd9d7fcf4
BUG: 1105147
Signed-off-by: Raghavendra Talur 
Reviewed-on: http://review.gluster.org/9042
Reviewed-by: Lalatendu Mohanty 
Tested-by: Gluster Build System 
Reviewed-by: Jose A. Rivera 
Reviewed-by: Krishnan Parthasarathi 
Tested-by: Krishnan Parthasarathi

logrotate: gluster logrotate config should not be global

2014-10-29T17:40:32+00:00

Issue : Previously glusterfs logrotate config file pollutes
global config. So moved the directives inside the curly braces,
 so they don't pollute the global config state.

Change-Id: I8836893dfcdf457d9c5d766612d687bfce64e2ae
BUG: 1126802
Signed-off-by: Lalatendu Mohanty 
Reviewed-on: http://review.gluster.org/8994
Reviewed-by: Niels de Vos 
Tested-by: Gluster Build System

Hooks : Infinite while loop introduced by another change.

2014-10-24T08:16:54+00:00

A change made to all the hook scripts introduced an
infinite while loop in the script S31ganesha-reset.sh.
It resulted in 100% CPU usage by this script.

Change-Id: If62d8f0e065c6e6511363b8b26eae433f59bc5c3
BUG: 1155489
Signed-off-by: Meghana Madhusudhan 
Reviewed-on: http://review.gluster.org/8966
Reviewed-by: soumya k 
Reviewed-by: Raghavendra Talur 
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

Revert "extras: reverse test for '}' vs. following 'else' placement"

2014-10-14T13:43:32+00:00

This reverts commit 0a8371bdfdd88e662d09def717cc0b822feb64e8.

Change-Id: I946f449ad213cea70fbbd9cd3951f5838b9f82e5
BUG: 1120646
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.org/8927
Reviewed-by: Jeff Darcy 
Reviewed-by: Kaleb KEITHLEY 
Reviewed-by: Niels de Vos 
Tested-by: Niels de Vos

extras: reverse test for '}' vs. following 'else' placement

2014-10-02T14:01:15+00:00

The two-line form "}\nelse {" has been more common than the one-line
form "} else {" in our code for years, and IMO for good reason (see
the comment in the diff).

Change-Id: Ic22c76fe76f0d91300daff36e755a18a8db58852
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/8888
Tested-by: Gluster Build System 
Reviewed-by: Vijay Bellur

build: remove warnings for recommended style

2014-09-23T21:30:13+00:00

Specifically:

 * space before function arguments

 * brace around single statement

Ideally we would *reverse* these tests so they warn under the exact
opposite conditions, but that would mean learning the internals of a
script written in a defective language with cryptic variable names and
too few comments.  Life's too short.  For now, just cutting down on some
of the spam (which might obscure more serious issues) should suffice.

BUG: 1120646
Change-Id: I5ec684d0d788a34f29af9b1761743c8860973993
Signed-off-by: Jeff Darcy 
Reviewed-on: http://review.gluster.org/8813
Reviewed-by: Harshavardhana 
Tested-by: Gluster Build System 
Tested-by: Harshavardhana

extras/checkpatch.pl: update coding guidelines script

2014-09-23T19:29:17+00:00

- Allow 'quoted string split across lines' since its a
  GlusterFS common practice
- Remove a useless "+" - perl 5.20 complains with following
  warning "Useless use of greediness modifier '+'"

Change-Id: Ibaf276ec84757b3ecc3e6db7f5e720b8e8a12dff
BUG: 1120646
Signed-off-by: Harshavardhana 
Reviewed-on: http://review.gluster.org/8811
Tested-by: Gluster Build System 
Reviewed-by: Jeff Darcy